diff options
| author | gagansingh@google.com <gagansingh@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-08-24 04:59:41 +0000 |
|---|---|---|
| committer | gagansingh@google.com <gagansingh@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-08-24 04:59:41 +0000 |
| commit | 5c68d695f520f4f393ba6a9380dd4f7a4f8280c2 (patch) | |
| tree | f98483fc6ae971eae7192f0c34bd7992b322d146 | |
| parent | 625d9f8fc428a36e29e6868d3a9bc9f33245d810 (diff) | |
| download | chromium_src-5c68d695f520f4f393ba6a9380dd4f7a4f8280c2.zip chromium_src-5c68d695f520f4f393ba6a9380dd4f7a4f8280c2.tar.gz chromium_src-5c68d695f520f4f393ba6a9380dd4f7a4f8280c2.tar.bz2 | |
Trying to measure the impact of warmest socket from the following histograms:
Net.Transaction_Latency_b
Net.Transaction_Latency_Total
Net.HttpTimeToFirstByte
for the WarmSocketImpact field trial, which will have the following buckets:
last_accessed_socket
warmest_socket
warm_socket
Review URL: http://codereview.chromium.org/7686002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97991 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | net/http/http_network_transaction.cc | 19 | ||||
| -rw-r--r-- | net/url_request/url_request_http_job.cc | 13 |
2 files changed, 30 insertions, 2 deletions
diff --git a/net/http/http_network_transaction.cc b/net/http/http_network_transaction.cc index 055e6e1..f8e362f 100644 --- a/net/http/http_network_transaction.cc +++ b/net/http/http_network_transaction.cc @@ -1042,6 +1042,25 @@ void HttpNetworkTransaction::LogTransactionMetrics() const { total_duration, base::TimeDelta::FromMilliseconds(1), base::TimeDelta::FromMinutes(10), 100); + + static const bool use_warm_socket_impact_histogram = + base::FieldTrialList::TrialExists("WarmSocketImpact"); + if (use_warm_socket_impact_histogram) { + UMA_HISTOGRAM_CUSTOM_TIMES( + base::FieldTrial::MakeName("Net.Transaction_Latency_b", + "WarmSocketImpact"), + duration, + base::TimeDelta::FromMilliseconds(1), + base::TimeDelta::FromMinutes(10), + 100); + UMA_HISTOGRAM_CUSTOM_TIMES( + base::FieldTrial::MakeName("Net.Transaction_Latency_Total", + "WarmSocketImpact"), + total_duration, + base::TimeDelta::FromMilliseconds(1), + base::TimeDelta::FromMinutes(10), 100); + } + if (!stream_->IsConnectionReused()) { UMA_HISTOGRAM_CUSTOM_TIMES( "Net.Transaction_Latency_Total_New_Connection", diff --git a/net/url_request/url_request_http_job.cc b/net/url_request/url_request_http_job.cc index 5f30e55..ac3d779 100644 --- a/net/url_request/url_request_http_job.cc +++ b/net/url_request/url_request_http_job.cc @@ -1256,10 +1256,19 @@ void URLRequestHttpJob::RecordTimer() { base::TimeDelta to_start = base::Time::Now() - request_creation_time_; request_creation_time_ = base::Time(); + UMA_HISTOGRAM_MEDIUM_TIMES("Net.HttpTimeToFirstByte", to_start); + + static const bool use_warm_socket_impact_histogram = + base::FieldTrialList::TrialExists("WarmSocketImpact"); + if (use_warm_socket_impact_histogram) { + UMA_HISTOGRAM_MEDIUM_TIMES( + base::FieldTrial::MakeName("Net.HttpTimeToFirstByte", + "WarmSocketImpact"), + to_start); + } + static const bool use_prefetch_histogram = base::FieldTrialList::TrialExists("Prefetch"); - - UMA_HISTOGRAM_MEDIUM_TIMES("Net.HttpTimeToFirstByte", to_start); if (use_prefetch_histogram) { UMA_HISTOGRAM_MEDIUM_TIMES( base::FieldTrial::MakeName("Net.HttpTimeToFirstByte", |