diff options
author | erikwright@chromium.org <erikwright@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-12-21 13:29:06 +0000 |
---|---|---|
committer | erikwright@chromium.org <erikwright@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-12-21 13:29:06 +0000 |
commit | 24e6ebe1a70c7539a110be4c7916d3f35b3c2400 (patch) | |
tree | 470b2b508520d377200824fb9b5c7ad5a1a4bf33 | |
parent | 0807fec65a7047bb1059a0ccd2b181566d728079 (diff) | |
download | chromium_src-24e6ebe1a70c7539a110be4c7916d3f35b3c2400.zip chromium_src-24e6ebe1a70c7539a110be4c7916d3f35b3c2400.tar.gz chromium_src-24e6ebe1a70c7539a110be4c7916d3f35b3c2400.tar.bz2 |
Add an out-of-line destructor to this class.
They are needed because StringPiece is going to become a template instatiation, and according to the Chromium style-checking Clang plugins, that makes any class with a member StringPiece 'complex'.
See http://codereview.chromium.org/8659047/ for the changes to StringPiece.
R=aa@chromium.org
BUG=87634
TEST=
Review URL: http://codereview.chromium.org/9021001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115323 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r-- | chrome/renderer/static_v8_external_string_resource.cc | 3 | ||||
-rw-r--r-- | chrome/renderer/static_v8_external_string_resource.h | 1 |
2 files changed, 4 insertions, 0 deletions
diff --git a/chrome/renderer/static_v8_external_string_resource.cc b/chrome/renderer/static_v8_external_string_resource.cc index 6a0b5b4..4395ffc 100644 --- a/chrome/renderer/static_v8_external_string_resource.cc +++ b/chrome/renderer/static_v8_external_string_resource.cc @@ -9,6 +9,9 @@ StaticV8ExternalAsciiStringResource::StaticV8ExternalAsciiStringResource( : buffer_(buffer) { } +StaticV8ExternalAsciiStringResource::~StaticV8ExternalAsciiStringResource() { +} + const char* StaticV8ExternalAsciiStringResource::data() const { return buffer_.data(); } diff --git a/chrome/renderer/static_v8_external_string_resource.h b/chrome/renderer/static_v8_external_string_resource.h index 27a8cd2..e255a7d 100644 --- a/chrome/renderer/static_v8_external_string_resource.h +++ b/chrome/renderer/static_v8_external_string_resource.h @@ -17,6 +17,7 @@ class StaticV8ExternalAsciiStringResource : public v8::String::ExternalAsciiStringResource { public: explicit StaticV8ExternalAsciiStringResource(const base::StringPiece& buffer); + virtual ~StaticV8ExternalAsciiStringResource(); virtual const char* data() const OVERRIDE; virtual size_t length() const OVERRIDE; |