summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorsenorblanco@chromium.org <senorblanco@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-08-23 03:19:06 +0000
committersenorblanco@chromium.org <senorblanco@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-08-23 03:19:06 +0000
commit60c030acf39c5d60045eb6177e213e1c726af176 (patch)
tree7e8eceabd8586670dc53c72c819b4fbeea2b83e2
parentcd273121c86aa74e90a894906a091b84b79e61c9 (diff)
downloadchromium_src-60c030acf39c5d60045eb6177e213e1c726af176.zip
chromium_src-60c030acf39c5d60045eb6177e213e1c726af176.tar.gz
chromium_src-60c030acf39c5d60045eb6177e213e1c726af176.tar.bz2
Captain Ahab here, trying to catch a whale. Temporarily enabling
SK_DEBUG for release builds. This will be reverted after a few reliability runs. BUG=http://crbug.com/17569 TEST=None TBR=maruel git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24085 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--skia/config/SkUserConfig.h5
-rw-r--r--webkit/tools/layout_tests/test_expectations.txt14
2 files changed, 11 insertions, 8 deletions
diff --git a/skia/config/SkUserConfig.h b/skia/config/SkUserConfig.h
index e88e80c8..1261580 100644
--- a/skia/config/SkUserConfig.h
+++ b/skia/config/SkUserConfig.h
@@ -76,7 +76,10 @@
based on the presence or absence of NDEBUG, but that decision can be changed
here.
*/
-//#define SK_DEBUG
+
+// Force SK_DEBUG even in release, so we get SkASSERTs.
+// TODO(senorblanco): Remove this after a few reliability runs.
+#define SK_DEBUG
//#define SK_RELEASE
diff --git a/webkit/tools/layout_tests/test_expectations.txt b/webkit/tools/layout_tests/test_expectations.txt
index 8d31f77..1024b6b 100644
--- a/webkit/tools/layout_tests/test_expectations.txt
+++ b/webkit/tools/layout_tests/test_expectations.txt
@@ -2705,13 +2705,13 @@ BUG18794 WIN MAC : LayoutTests/http/tests/mime/standard-mode-does-not-load-style
BUG18802 WIN : LayoutTests/http/tests/misc/referrer.html = TIMEOUT PASS
// Test failures caused by re-enabling skia asserts.
-BUG18896 WIN DEBUG : LayoutTests/fast/backgrounds/svg-as-background-5.html = FAIL
-BUG18896 WIN LINUX DEBUG : LayoutTests/svg/batik/paints/gradientLimit.svg = FAIL
-BUG18896 WIN DEBUG : LayoutTests/svg/carto.net/window.svg = FAIL
-BUG18896 LINUX DEBUG : LayoutTests/svg/dynamic-updates/SVGClipPathElement-dom-clipPathUnits-attr.html = FAIL
-BUG18896 MAC WIN DEBUG : LayoutTests/svg/dynamic-updates/SVGClipPathElement-dom-clipPathUnits-attr.html = PASS CRASH
-BUG18896 LINUX DEBUG : LayoutTests/svg/dynamic-updates/SVGClipPathElement-svgdom-clipPathUnits-prop.html = FAIL
-BUG18896 LINUX DEBUG : LayoutTests/svg/css/crash-css-generated-content.xhtml = FAIL
+BUG18896 WIN : LayoutTests/fast/backgrounds/svg-as-background-5.html = FAIL
+BUG18896 WIN LINUX : LayoutTests/svg/batik/paints/gradientLimit.svg = FAIL
+BUG18896 WIN : LayoutTests/svg/carto.net/window.svg = FAIL
+BUG18896 LINUX : LayoutTests/svg/dynamic-updates/SVGClipPathElement-dom-clipPathUnits-attr.html = FAIL
+BUG18896 MAC WIN : LayoutTests/svg/dynamic-updates/SVGClipPathElement-dom-clipPathUnits-attr.html = PASS CRASH
+BUG18896 LINUX : LayoutTests/svg/dynamic-updates/SVGClipPathElement-svgdom-clipPathUnits-prop.html = FAIL
+BUG18896 LINUX : LayoutTests/svg/css/crash-css-generated-content.xhtml = FAIL
// Test failures from WebKit merge 46894 to 46977
BUG18939 : LayoutTests/fast/js/JSON-stringify-replacer.html = FAIL