diff options
author | tfarina@chromium.org <tfarina@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-02 03:01:43 +0000 |
---|---|---|
committer | tfarina@chromium.org <tfarina@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-02 03:01:43 +0000 |
commit | 1755f36c61d05c2443d4783b7e68a179b96a4a4f (patch) | |
tree | dcc1389d0dc4aeee6f6b39f41bd015195651b0fc | |
parent | 57853bbfe599827b28735d4eeb63ebb434ee3de4 (diff) | |
download | chromium_src-1755f36c61d05c2443d4783b7e68a179b96a4a4f.zip chromium_src-1755f36c61d05c2443d4783b7e68a179b96a4a4f.tar.gz chromium_src-1755f36c61d05c2443d4783b7e68a179b96a4a4f.tar.bz2 |
sync: Remove unused function ChromeModelHasUserCreatedNodes.
(Note: This was a TODO for akalin).
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/2867036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51483 0039d316-1c4b-4281-b951-d872f2087c98
20 files changed, 1 insertions, 127 deletions
diff --git a/chrome/browser/sync/glue/autofill_model_associator.cc b/chrome/browser/sync/glue/autofill_model_associator.cc index 127df31..6c500756 100644 --- a/chrome/browser/sync/glue/autofill_model_associator.cc +++ b/chrome/browser/sync/glue/autofill_model_associator.cc @@ -380,13 +380,6 @@ bool AutofillModelAssociator::SyncModelHasUserCreatedNodes(bool* has_nodes) { return true; } -bool AutofillModelAssociator::ChromeModelHasUserCreatedNodes(bool* has_nodes) { - DCHECK(has_nodes); - // Assume the autofill model always have user-created nodes. - *has_nodes = true; - return true; -} - void AutofillModelAssociator::AbortAssociation() { DCHECK(ChromeThread::CurrentlyOn(ChromeThread::UI)); AutoLock lock(abort_association_pending_lock_); diff --git a/chrome/browser/sync/glue/autofill_model_associator.h b/chrome/browser/sync/glue/autofill_model_associator.h index 0e110ea..7814273 100644 --- a/chrome/browser/sync/glue/autofill_model_associator.h +++ b/chrome/browser/sync/glue/autofill_model_associator.h @@ -77,10 +77,6 @@ class AutofillModelAssociator // than the permanent tagged nodes. virtual bool SyncModelHasUserCreatedNodes(bool* has_nodes); - // The has_nodes out param is true if the autofill model has any - // user-defined autofill entries. - virtual bool ChromeModelHasUserCreatedNodes(bool* has_nodes); - // See ModelAssociator interface. virtual void AbortAssociation(); diff --git a/chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc b/chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc index be12787..477cb3f 100644 --- a/chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc +++ b/chrome/browser/sync/glue/bookmark_data_type_controller_unittest.cc @@ -69,8 +69,6 @@ class BookmarkDataTypeControllerTest : public testing::Test { void SetAssociateExpectations() { EXPECT_CALL(*profile_sync_factory_, CreateBookmarkSyncComponents(_, _)); - EXPECT_CALL(*model_associator_, ChromeModelHasUserCreatedNodes(_)). - WillRepeatedly(DoAll(SetArgumentPointee<0>(false), Return(true))); EXPECT_CALL(*model_associator_, SyncModelHasUserCreatedNodes(_)). WillRepeatedly(DoAll(SetArgumentPointee<0>(true), Return(true))); EXPECT_CALL(*model_associator_, AssociateModels()). @@ -144,8 +142,6 @@ TEST_F(BookmarkDataTypeControllerTest, StartBusy) { TEST_F(BookmarkDataTypeControllerTest, StartOk) { SetStartExpectations(); SetAssociateExpectations(); - EXPECT_CALL(*model_associator_, ChromeModelHasUserCreatedNodes(_)). - WillRepeatedly(DoAll(SetArgumentPointee<0>(true), Return(true))); EXPECT_CALL(*model_associator_, SyncModelHasUserCreatedNodes(_)). WillRepeatedly(DoAll(SetArgumentPointee<0>(true), Return(true))); @@ -157,8 +153,6 @@ TEST_F(BookmarkDataTypeControllerTest, StartAssociationFailed) { SetStartExpectations(); // Set up association to fail. EXPECT_CALL(*profile_sync_factory_, CreateBookmarkSyncComponents(_, _)); - EXPECT_CALL(*model_associator_, ChromeModelHasUserCreatedNodes(_)). - WillRepeatedly(DoAll(SetArgumentPointee<0>(false), Return(true))); EXPECT_CALL(*model_associator_, SyncModelHasUserCreatedNodes(_)). WillRepeatedly(DoAll(SetArgumentPointee<0>(true), Return(true))); EXPECT_CALL(*model_associator_, AssociateModels()). @@ -174,8 +168,6 @@ TEST_F(BookmarkDataTypeControllerTest, SetStartExpectations(); // Set up association to fail with an unrecoverable error. EXPECT_CALL(*profile_sync_factory_, CreateBookmarkSyncComponents(_, _)); - EXPECT_CALL(*model_associator_, ChromeModelHasUserCreatedNodes(_)). - WillRepeatedly(DoAll(SetArgumentPointee<0>(false), Return(true))); EXPECT_CALL(*model_associator_, SyncModelHasUserCreatedNodes(_)). WillRepeatedly(DoAll(SetArgumentPointee<0>(false), Return(false))); EXPECT_CALL(start_callback_, Run(DataTypeController::UNRECOVERABLE_ERROR)); @@ -210,8 +202,6 @@ TEST_F(BookmarkDataTypeControllerTest, Stop) { TEST_F(BookmarkDataTypeControllerTest, OnUnrecoverableError) { SetStartExpectations(); SetAssociateExpectations(); - EXPECT_CALL(*model_associator_, ChromeModelHasUserCreatedNodes(_)). - WillRepeatedly(DoAll(SetArgumentPointee<0>(true), Return(true))); EXPECT_CALL(*model_associator_, SyncModelHasUserCreatedNodes(_)). WillRepeatedly(DoAll(SetArgumentPointee<0>(true), Return(true))); EXPECT_CALL(service_, OnUnrecoverableError(_,_)). diff --git a/chrome/browser/sync/glue/bookmark_model_associator.cc b/chrome/browser/sync/glue/bookmark_model_associator.cc index 26e50c2..fbbf8c3 100644 --- a/chrome/browser/sync/glue/bookmark_model_associator.cc +++ b/chrome/browser/sync/glue/bookmark_model_associator.cc @@ -222,16 +222,6 @@ void BookmarkModelAssociator::Disassociate(int64 sync_id) { dirty_associations_sync_ids_.erase(sync_id); } -bool BookmarkModelAssociator::ChromeModelHasUserCreatedNodes(bool* has_nodes) { - DCHECK(has_nodes); - BookmarkModel* model = sync_service_->profile()->GetBookmarkModel(); - DCHECK(model->IsLoaded()); - - *has_nodes = model->GetBookmarkBarNode()->GetChildCount() > 0 || - model->other_node()->GetChildCount() > 0; - return true; -} - bool BookmarkModelAssociator::SyncModelHasUserCreatedNodes(bool* has_nodes) { DCHECK(has_nodes); *has_nodes = false; diff --git a/chrome/browser/sync/glue/bookmark_model_associator.h b/chrome/browser/sync/glue/bookmark_model_associator.h index 4d0d640..5c725cc 100644 --- a/chrome/browser/sync/glue/bookmark_model_associator.h +++ b/chrome/browser/sync/glue/bookmark_model_associator.h @@ -57,11 +57,6 @@ class BookmarkModelAssociator // than the permanent tagged nodes. virtual bool SyncModelHasUserCreatedNodes(bool* has_nodes); - // The has_nodes out param is true if the bookmark model has user - // created nodes or not. That is, whether there are nodes in the - // bookmark model except the bookmark bar and other bookmarks. - virtual bool ChromeModelHasUserCreatedNodes(bool* has_nodes); - // Returns sync id for the given bookmark node id. // Returns sync_api::kInvalidId if the sync node is not found for the given // bookmark node id. diff --git a/chrome/browser/sync/glue/extension_data_type_controller_unittest.cc b/chrome/browser/sync/glue/extension_data_type_controller_unittest.cc index a8d4979..af9b356 100644 --- a/chrome/browser/sync/glue/extension_data_type_controller_unittest.cc +++ b/chrome/browser/sync/glue/extension_data_type_controller_unittest.cc @@ -54,8 +54,6 @@ class ExtensionDataTypeControllerTest : public testing::Test { } void SetAssociateExpectations() { - EXPECT_CALL(*model_associator_, ChromeModelHasUserCreatedNodes(_)). - WillRepeatedly(DoAll(SetArgumentPointee<0>(false), Return(true))); EXPECT_CALL(*model_associator_, SyncModelHasUserCreatedNodes(_)). WillRepeatedly(DoAll(SetArgumentPointee<0>(true), Return(true))); EXPECT_CALL(*model_associator_, AssociateModels()). @@ -106,8 +104,6 @@ TEST_F(ExtensionDataTypeControllerTest, StartOk) { SetStartExpectations(); SetAssociateExpectations(); SetActivateExpectations(); - EXPECT_CALL(*model_associator_, ChromeModelHasUserCreatedNodes(_)). - WillRepeatedly(DoAll(SetArgumentPointee<0>(true), Return(true))); EXPECT_CALL(*model_associator_, SyncModelHasUserCreatedNodes(_)). WillRepeatedly(DoAll(SetArgumentPointee<0>(true), Return(true))); @@ -130,8 +126,6 @@ TEST_F(ExtensionDataTypeControllerTest, StartAssociationTriggersUnrecoverableError) { SetStartExpectations(); // Set up association to fail with an unrecoverable error. - EXPECT_CALL(*model_associator_, ChromeModelHasUserCreatedNodes(_)). - WillRepeatedly(DoAll(SetArgumentPointee<0>(false), Return(true))); EXPECT_CALL(*model_associator_, SyncModelHasUserCreatedNodes(_)). WillRepeatedly(DoAll(SetArgumentPointee<0>(false), Return(false))); EXPECT_CALL(start_callback_, Run(DataTypeController::UNRECOVERABLE_ERROR)); @@ -159,8 +153,6 @@ TEST_F(ExtensionDataTypeControllerTest, OnUnrecoverableError) { SetStartExpectations(); SetAssociateExpectations(); SetActivateExpectations(); - EXPECT_CALL(*model_associator_, ChromeModelHasUserCreatedNodes(_)). - WillRepeatedly(DoAll(SetArgumentPointee<0>(true), Return(true))); EXPECT_CALL(*model_associator_, SyncModelHasUserCreatedNodes(_)). WillRepeatedly(DoAll(SetArgumentPointee<0>(true), Return(true))); EXPECT_CALL(service_, OnUnrecoverableError(_, _)). diff --git a/chrome/browser/sync/glue/extension_model_associator.cc b/chrome/browser/sync/glue/extension_model_associator.cc index 8a33951..3ff404d 100644 --- a/chrome/browser/sync/glue/extension_model_associator.cc +++ b/chrome/browser/sync/glue/extension_model_associator.cc @@ -196,15 +196,6 @@ bool ExtensionModelAssociator::SyncModelHasUserCreatedNodes(bool* has_nodes) { return true; } -bool ExtensionModelAssociator::ChromeModelHasUserCreatedNodes( - bool* has_nodes) { - DCHECK(ChromeThread::CurrentlyOn(ChromeThread::UI)); - CHECK(has_nodes); - // This is wrong, but this function is unused, anyway. - *has_nodes = true; - return true; -} - bool ExtensionModelAssociator::OnClientUpdate(const std::string& id) { sync_api::WriteTransaction trans( sync_service_->backend()->GetUserShareHandle()); diff --git a/chrome/browser/sync/glue/extension_model_associator.h b/chrome/browser/sync/glue/extension_model_associator.h index 98a16fb..d88be10 100644 --- a/chrome/browser/sync/glue/extension_model_associator.h +++ b/chrome/browser/sync/glue/extension_model_associator.h @@ -43,8 +43,6 @@ class ExtensionModelAssociator : public AssociatorInterface { virtual bool AssociateModels(); virtual bool DisassociateModels(); virtual bool SyncModelHasUserCreatedNodes(bool* has_nodes); - // TODO(akalin): Remove this unused function. - virtual bool ChromeModelHasUserCreatedNodes(bool* has_nodes); virtual void AbortAssociation() { // No implementation needed, this associator runs on the main // thread. diff --git a/chrome/browser/sync/glue/model_associator.h b/chrome/browser/sync/glue/model_associator.h index 70ff078..3c12659 100644 --- a/chrome/browser/sync/glue/model_associator.h +++ b/chrome/browser/sync/glue/model_associator.h @@ -39,11 +39,6 @@ class AssociatorInterface { // return false if an error occurred. virtual bool SyncModelHasUserCreatedNodes(bool* has_nodes) = 0; - // The has_nodes out parameter is set to true if the chrome model - // has user-created nodes. The method may return false if an error - // occurred. - virtual bool ChromeModelHasUserCreatedNodes(bool* has_nodes) = 0; - // Calling this method while AssociateModels() is in progress will // cause the method to exit early with a "false" return value. This // is useful for aborting model associations for shutdown. This diff --git a/chrome/browser/sync/glue/model_associator_mock.h b/chrome/browser/sync/glue/model_associator_mock.h index f8ffae7..766f01b 100644 --- a/chrome/browser/sync/glue/model_associator_mock.h +++ b/chrome/browser/sync/glue/model_associator_mock.h @@ -15,7 +15,6 @@ class ModelAssociatorMock : public AssociatorInterface { MOCK_METHOD0(AssociateModels, bool()); MOCK_METHOD0(DisassociateModels, bool()); MOCK_METHOD1(SyncModelHasUserCreatedNodes, bool(bool* has_nodes)); - MOCK_METHOD1(ChromeModelHasUserCreatedNodes, bool(bool* has_nodes)); MOCK_METHOD0(AbortAssociation, void()); }; diff --git a/chrome/browser/sync/glue/password_model_associator.cc b/chrome/browser/sync/glue/password_model_associator.cc index e4d2e05..fa2d9eb 100644 --- a/chrome/browser/sync/glue/password_model_associator.cc +++ b/chrome/browser/sync/glue/password_model_associator.cc @@ -191,21 +191,6 @@ bool PasswordModelAssociator::SyncModelHasUserCreatedNodes(bool* has_nodes) { return true; } -bool PasswordModelAssociator::ChromeModelHasUserCreatedNodes(bool* has_nodes) { - DCHECK(has_nodes); - std::vector<webkit_glue::PasswordForm*> passwords; - if (!password_store_->FillAutofillableLogins(&passwords) || - !password_store_->FillBlacklistLogins(&passwords)) { - STLDeleteElements(&passwords); - LOG(ERROR) << "Could not get the password entries."; - return false; - } - - *has_nodes = !passwords.empty(); - STLDeleteElements(&passwords); - return true; -} - void PasswordModelAssociator::AbortAssociation() { DCHECK(ChromeThread::CurrentlyOn(ChromeThread::UI)); AutoLock lock(abort_association_pending_lock_); diff --git a/chrome/browser/sync/glue/password_model_associator.h b/chrome/browser/sync/glue/password_model_associator.h index 42708ea..bfcd105 100644 --- a/chrome/browser/sync/glue/password_model_associator.h +++ b/chrome/browser/sync/glue/password_model_associator.h @@ -70,10 +70,6 @@ class PasswordModelAssociator // than the permanent tagged nodes. virtual bool SyncModelHasUserCreatedNodes(bool* has_nodes); - // The has_nodes out param is true if the autofill model has any - // user-defined password entries. - virtual bool ChromeModelHasUserCreatedNodes(bool* has_nodes); - // See ModelAssociator interface. virtual void AbortAssociation(); diff --git a/chrome/browser/sync/glue/preference_data_type_controller_unittest.cc b/chrome/browser/sync/glue/preference_data_type_controller_unittest.cc index 74b1a4b..b732716 100644 --- a/chrome/browser/sync/glue/preference_data_type_controller_unittest.cc +++ b/chrome/browser/sync/glue/preference_data_type_controller_unittest.cc @@ -53,8 +53,6 @@ class PreferenceDataTypeControllerTest : public testing::Test { } void SetAssociateExpectations() { - EXPECT_CALL(*model_associator_, ChromeModelHasUserCreatedNodes(_)). - WillRepeatedly(DoAll(SetArgumentPointee<0>(false), Return(true))); EXPECT_CALL(*model_associator_, SyncModelHasUserCreatedNodes(_)). WillRepeatedly(DoAll(SetArgumentPointee<0>(true), Return(true))); EXPECT_CALL(*model_associator_, AssociateModels()). @@ -104,8 +102,6 @@ TEST_F(PreferenceDataTypeControllerTest, StartOk) { SetStartExpectations(); SetAssociateExpectations(); SetActivateExpectations(); - EXPECT_CALL(*model_associator_, ChromeModelHasUserCreatedNodes(_)). - WillRepeatedly(DoAll(SetArgumentPointee<0>(true), Return(true))); EXPECT_CALL(*model_associator_, SyncModelHasUserCreatedNodes(_)). WillRepeatedly(DoAll(SetArgumentPointee<0>(true), Return(true))); @@ -128,8 +124,6 @@ TEST_F(PreferenceDataTypeControllerTest, StartAssociationTriggersUnrecoverableError) { SetStartExpectations(); // Set up association to fail with an unrecoverable error. - EXPECT_CALL(*model_associator_, ChromeModelHasUserCreatedNodes(_)). - WillRepeatedly(DoAll(SetArgumentPointee<0>(false), Return(true))); EXPECT_CALL(*model_associator_, SyncModelHasUserCreatedNodes(_)). WillRepeatedly(DoAll(SetArgumentPointee<0>(false), Return(false))); EXPECT_CALL(start_callback_, Run(DataTypeController::UNRECOVERABLE_ERROR)); @@ -156,8 +150,6 @@ TEST_F(PreferenceDataTypeControllerTest, OnUnrecoverableError) { SetStartExpectations(); SetAssociateExpectations(); SetActivateExpectations(); - EXPECT_CALL(*model_associator_, ChromeModelHasUserCreatedNodes(_)). - WillRepeatedly(DoAll(SetArgumentPointee<0>(true), Return(true))); EXPECT_CALL(*model_associator_, SyncModelHasUserCreatedNodes(_)). WillRepeatedly(DoAll(SetArgumentPointee<0>(true), Return(true))); EXPECT_CALL(service_, OnUnrecoverableError(_,_)). diff --git a/chrome/browser/sync/glue/preference_model_associator.cc b/chrome/browser/sync/glue/preference_model_associator.cc index 3e3c1ec..0695905 100644 --- a/chrome/browser/sync/glue/preference_model_associator.cc +++ b/chrome/browser/sync/glue/preference_model_associator.cc @@ -154,14 +154,6 @@ bool PreferenceModelAssociator::SyncModelHasUserCreatedNodes(bool* has_nodes) { return true; } -bool PreferenceModelAssociator::ChromeModelHasUserCreatedNodes( - bool* has_nodes) { - DCHECK(has_nodes); - // Assume the preferences model always have user-created nodes. - *has_nodes = true; - return true; -} - int64 PreferenceModelAssociator::GetSyncIdFromChromeId( const std::wstring preference_name) { PreferenceNameToSyncIdMap::const_iterator iter = diff --git a/chrome/browser/sync/glue/preference_model_associator.h b/chrome/browser/sync/glue/preference_model_associator.h index a91b5fe..4c86496 100644 --- a/chrome/browser/sync/glue/preference_model_associator.h +++ b/chrome/browser/sync/glue/preference_model_associator.h @@ -57,9 +57,6 @@ class PreferenceModelAssociator // nodes. virtual bool SyncModelHasUserCreatedNodes(bool* has_nodes); - // Returns whether the preference model has any user-defined preferences. - virtual bool ChromeModelHasUserCreatedNodes(bool* has_nodes); - virtual void AbortAssociation() { // No implementation needed, this associator runs on the main // thread. diff --git a/chrome/browser/sync/glue/theme_data_type_controller_unittest.cc b/chrome/browser/sync/glue/theme_data_type_controller_unittest.cc index 73496b3..80f31c5 100644 --- a/chrome/browser/sync/glue/theme_data_type_controller_unittest.cc +++ b/chrome/browser/sync/glue/theme_data_type_controller_unittest.cc @@ -53,8 +53,6 @@ class ThemeDataTypeControllerTest : public testing::Test { } void SetAssociateExpectations() { - EXPECT_CALL(*model_associator_, ChromeModelHasUserCreatedNodes(_)). - WillRepeatedly(DoAll(SetArgumentPointee<0>(false), Return(true))); EXPECT_CALL(*model_associator_, SyncModelHasUserCreatedNodes(_)). WillRepeatedly(DoAll(SetArgumentPointee<0>(true), Return(true))); EXPECT_CALL(*model_associator_, AssociateModels()). @@ -105,8 +103,6 @@ TEST_F(ThemeDataTypeControllerTest, StartOk) { SetStartExpectations(); SetAssociateExpectations(); SetActivateExpectations(); - EXPECT_CALL(*model_associator_, ChromeModelHasUserCreatedNodes(_)). - WillRepeatedly(DoAll(SetArgumentPointee<0>(true), Return(true))); EXPECT_CALL(*model_associator_, SyncModelHasUserCreatedNodes(_)). WillRepeatedly(DoAll(SetArgumentPointee<0>(true), Return(true))); @@ -129,8 +125,6 @@ TEST_F(ThemeDataTypeControllerTest, StartAssociationTriggersUnrecoverableError) { SetStartExpectations(); // Set up association to fail with an unrecoverable error. - EXPECT_CALL(*model_associator_, ChromeModelHasUserCreatedNodes(_)). - WillRepeatedly(DoAll(SetArgumentPointee<0>(false), Return(true))); EXPECT_CALL(*model_associator_, SyncModelHasUserCreatedNodes(_)). WillRepeatedly(DoAll(SetArgumentPointee<0>(false), Return(false))); EXPECT_CALL(start_callback_, Run(DataTypeController::UNRECOVERABLE_ERROR)); @@ -158,8 +152,6 @@ TEST_F(ThemeDataTypeControllerTest, OnUnrecoverableError) { SetStartExpectations(); SetAssociateExpectations(); SetActivateExpectations(); - EXPECT_CALL(*model_associator_, ChromeModelHasUserCreatedNodes(_)). - WillRepeatedly(DoAll(SetArgumentPointee<0>(true), Return(true))); EXPECT_CALL(*model_associator_, SyncModelHasUserCreatedNodes(_)). WillRepeatedly(DoAll(SetArgumentPointee<0>(true), Return(true))); EXPECT_CALL(service_, OnUnrecoverableError(_,_)). diff --git a/chrome/browser/sync/glue/theme_model_associator.cc b/chrome/browser/sync/glue/theme_model_associator.cc index c50ceb2..a20e669 100644 --- a/chrome/browser/sync/glue/theme_model_associator.cc +++ b/chrome/browser/sync/glue/theme_model_associator.cc @@ -94,11 +94,4 @@ bool ThemeModelAssociator::SyncModelHasUserCreatedNodes(bool* has_nodes) { return true; } -bool ThemeModelAssociator::ChromeModelHasUserCreatedNodes(bool* has_nodes) { - DCHECK(has_nodes); - // Assume the themes model always has user-created nodes. - *has_nodes = true; - return true; -} - } // namespace browser_sync diff --git a/chrome/browser/sync/glue/theme_model_associator.h b/chrome/browser/sync/glue/theme_model_associator.h index ff0cac9..54603cb 100644 --- a/chrome/browser/sync/glue/theme_model_associator.h +++ b/chrome/browser/sync/glue/theme_model_associator.h @@ -19,7 +19,7 @@ class UnrecoverableErrorHandler; // sync themes model. class ThemeModelAssociator : public AssociatorInterface { public: - ThemeModelAssociator(ProfileSyncService* sync_service); + explicit ThemeModelAssociator(ProfileSyncService* sync_service); virtual ~ThemeModelAssociator(); // Used by profile_sync_test_util.h. @@ -29,7 +29,6 @@ class ThemeModelAssociator : public AssociatorInterface { virtual bool AssociateModels(); virtual bool DisassociateModels(); virtual bool SyncModelHasUserCreatedNodes(bool* has_nodes); - virtual bool ChromeModelHasUserCreatedNodes(bool* has_nodes); virtual void AbortAssociation() { // No implementation needed, this associator runs on the main // thread. diff --git a/chrome/browser/sync/glue/typed_url_model_associator.cc b/chrome/browser/sync/glue/typed_url_model_associator.cc index f5c7e61..3cca88a 100644 --- a/chrome/browser/sync/glue/typed_url_model_associator.cc +++ b/chrome/browser/sync/glue/typed_url_model_associator.cc @@ -231,13 +231,6 @@ bool TypedUrlModelAssociator::SyncModelHasUserCreatedNodes(bool* has_nodes) { return true; } -bool TypedUrlModelAssociator::ChromeModelHasUserCreatedNodes(bool* has_nodes) { - DCHECK(has_nodes); - // Assume the typed_url model always have user-created nodes. - *has_nodes = true; - return true; -} - int64 TypedUrlModelAssociator::GetSyncIdFromChromeId( const std::string typed_url) { TypedUrlToSyncIdMap::const_iterator iter = id_map_.find(typed_url); diff --git a/chrome/browser/sync/glue/typed_url_model_associator.h b/chrome/browser/sync/glue/typed_url_model_associator.h index 7557596..dcaed25 100644 --- a/chrome/browser/sync/glue/typed_url_model_associator.h +++ b/chrome/browser/sync/glue/typed_url_model_associator.h @@ -75,10 +75,6 @@ class TypedUrlModelAssociator // than the permanent tagged nodes. virtual bool SyncModelHasUserCreatedNodes(bool* has_nodes); - // The has_nodes out param is true if the autofill model has any - // user-defined typed_url entries. - virtual bool ChromeModelHasUserCreatedNodes(bool* has_nodes); - virtual void AbortAssociation() { // TODO(zork): Implement this. } |