summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorarv@chromium.org <arv@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-05-09 19:17:55 +0000
committerarv@chromium.org <arv@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-05-09 19:17:55 +0000
commit029f88abbf673b91afb203cec3f5d94d15ee8c69 (patch)
treefeca1773262fa8f23dc83a147f01b35a68108f9b
parente355a89f35aa9b2b0c666d70ae80313716648248 (diff)
downloadchromium_src-029f88abbf673b91afb203cec3f5d94d15ee8c69.zip
chromium_src-029f88abbf673b91afb203cec3f5d94d15ee8c69.tar.gz
chromium_src-029f88abbf673b91afb203cec3f5d94d15ee8c69.tar.bz2
NTP: Fix issue where hiding the tips did not work.
BUG=43254 TEST=Open the drop down menu and toggle the tips. Review URL: http://codereview.chromium.org/1981001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46804 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--chrome/browser/resources/new_new_tab.css7
-rw-r--r--chrome/browser/resources/new_new_tab.html12
2 files changed, 10 insertions, 9 deletions
diff --git a/chrome/browser/resources/new_new_tab.css b/chrome/browser/resources/new_new_tab.css
index a8493d5..41a419e 100644
--- a/chrome/browser/resources/new_new_tab.css
+++ b/chrome/browser/resources/new_new_tab.css
@@ -272,12 +272,15 @@ html[dir=rtl] .item {
#tip-line {
-webkit-box-flex: 1;
+ -webkit-transition: opacity .15s;
-webkit-user-select: text;
+ border: 0;
cursor: text;
- text-align: end;
+ display: block; /* Since we are reusing the section display logic we need
+ to override the display for hidden tips. */
margin: 10px;
-webkit-margin-start: 50%;
- -webkit-transition: opacity .15s;
+ text-align: end;
}
.notification.hidden,
diff --git a/chrome/browser/resources/new_new_tab.html b/chrome/browser/resources/new_new_tab.html
index 3d3921b..63a3b35 100644
--- a/chrome/browser/resources/new_new_tab.html
+++ b/chrome/browser/resources/new_new_tab.html
@@ -127,8 +127,7 @@ if ('mode' in hashParams) {
<div id="main">
<div id=top-bar>
- <div id="tip-line"></div>
- <script>updateSimpleSection('tip-line', Section.TIPS)</script>
+ <div id="tip-line" class="section" section="TIPS"></div>
<input type="button" id="option-button"
i18n-values="title:pagedisplaytooltip">
</div>
@@ -180,11 +179,10 @@ if ('mode' in hashParams) {
</div>
<script>
- (function() {
- updateSimpleSection('recently-closed', Section.RECENT);
- updateSimpleSection('most-visited-section', Section.THUMB);
- updateSimpleSection('debug', Section.DEBUG);
- })();
+ updateSimpleSection('tip-line', Section.TIPS);
+ updateSimpleSection('recently-closed', Section.RECENT);
+ updateSimpleSection('most-visited-section', Section.THUMB);
+ updateSimpleSection('debug', Section.DEBUG);
</script>
<div id="sync-status">