Comments added to SSL unit tests.

Review URL: http://codereview.chromium.org/132081

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18835 0039d316-1c4b-4281-b951-d872f2087c98

2 files changed, 35 insertions, 0 deletions

diff --git a/net/base/ssl_client_socket_unittest.cc b/net/base/ssl_client_socket_unittest.cc
index ef308a1..2d764e9 100644
--- a/net/base/ssl_client_socket_unittest.cc
+++ b/net/base/ssl_client_socket_unittest.cc
@@ -54,6 +54,18 @@ class SSLClientSocketTest : public PlatformTest {
 //-----------------------------------------------------------------------------
 
 #if defined(OS_MACOSX)
+// Status 6/19/09:
+//
+// If these tests are enabled on OSX, we choke at the point
+// SSLHandshake() (Security framework call) is called from
+// SSLClientSocketMac::DoHandshake().  Return value is -9812 (cert
+// valid but root not trusted), but if you don't have the cert in your
+// keychain as documented on
+// http://dev.chromium.org/developers/testing, the -9812 becomes a
+// -9813 (no root cert).
+//
+// See related handshake failures exhibited by disabled tests in
+// net/url_request/url_request_unittest.cc.
 #define MAYBE_Connect DISABLED_Connect
 #define MAYBE_ConnectExpired DISABLED_ConnectExpired
 #define MAYBE_ConnectMismatched DISABLED_ConnectMismatched
diff --git a/net/url_request/url_request_unittest.cc b/net/url_request/url_request_unittest.cc
index 18ff111..fa29d32 100644
--- a/net/url_request/url_request_unittest.cc
+++ b/net/url_request/url_request_unittest.cc
@@ -219,6 +219,29 @@ class HTTPSRequestTest : public testing::Test {
 };
 
 #if defined(OS_MACOSX)
+// Status 6/19/09:
+//
+// If these tests are enabled on OSX, the first one (HTTPSGetTest)
+// will fail.  I didn't track it down explicitly, but did observe that
+// the testserver.py kills itself (e.g. "process_util_posix.cc(84)]
+// Unable to terminate process.").  tlslite and testserver.py are hard
+// to debug (redirection of stdout/stderr to a file so you can't see
+// errors; lots of naked "except:" statements, etc), but I did track
+// down an SSL auth failure as one cause of it deciding to die
+// silently.
+//
+// The next test, HTTPSMismatchedTest, will look like it hangs by
+// looping over calls to SSLHandshake() (Security framework call) as
+// called from SSLClientSocketMac::DoHandshake().  Return values are a
+// repeating pattern of -9803 (come back later) and -9812 (cert valid
+// but root not trusted).  If you don't have the cert in your keychain
+// as documented on http://dev.chromium.org/developers/testing, the
+// -9812 becomes a -9813 (no root cert).  Interestingly, the handshake
+// also appears to be a failure point for other disabled tests, such
+// as (SSLClientSocketTest,Connect) in
+// net/base/ssl_client_socket_unittest.cc.
+//
+// Old comment (not sure if obsolete):
 // ssl_client_socket_mac.cc crashes currently in GetSSLInfo
 // when called on a connection with an unrecognized certificate
 #define MAYBE_HTTPSGetTest        DISABLED_HTTPSGetTest