summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorrafaelw@chromium.org <rafaelw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-05-12 18:18:16 +0000
committerrafaelw@chromium.org <rafaelw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-05-12 18:18:16 +0000
commitcefc3bf5b4cc3bd7db35d3e274173cf1563a9372 (patch)
tree909fb8bd8f07c63a283bd497968f5dfd6d35c27c
parentc9f78ef7dbd2bb7d621f360f738be9cd33441ff3 (diff)
downloadchromium_src-cefc3bf5b4cc3bd7db35d3e274173cf1563a9372.zip
chromium_src-cefc3bf5b4cc3bd7db35d3e274173cf1563a9372.tar.gz
chromium_src-cefc3bf5b4cc3bd7db35d3e274173cf1563a9372.tar.bz2
Clean up old method signature of WebViewClient::createView.
https://bugs.webkit.org/show_bug.cgi?id=38301 has landed in webkit. Remove old call signature. Review URL: http://codereview.chromium.org/1955002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47046 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--chrome/renderer/render_view.cc6
-rw-r--r--chrome/renderer/render_view.h3
-rw-r--r--webkit/tools/test_shell/test_webview_delegate.cc6
-rw-r--r--webkit/tools/test_shell/test_webview_delegate.h3
4 files changed, 0 insertions, 18 deletions
diff --git a/chrome/renderer/render_view.cc b/chrome/renderer/render_view.cc
index a4dd898..0fb2593 100644
--- a/chrome/renderer/render_view.cc
+++ b/chrome/renderer/render_view.cc
@@ -1536,12 +1536,6 @@ void RenderView::OnMissingPluginStatus(
// WebKit::WebViewClient ------------------------------------------------------
-// TODO(rafaelw): remove when
-// WebViewClient::createView(WebFrame,WebWindowFeatures) lands.
-WebView* RenderView::createView(WebFrame* creator) {
- return createView(creator, WebWindowFeatures());
-}
-
WebView* RenderView::createView(
WebFrame* creator,
const WebWindowFeatures& features) {
diff --git a/chrome/renderer/render_view.h b/chrome/renderer/render_view.h
index bbf255a..f0c0048 100644
--- a/chrome/renderer/render_view.h
+++ b/chrome/renderer/render_view.h
@@ -204,9 +204,6 @@ class RenderView : public RenderWidget,
virtual void DnsPrefetch(const std::vector<std::string>& host_names);
// WebKit::WebViewClient
- // TODO(rafaelw): Remove this when
- // WebViewClient::createView(WebFrame,WebWindowFeatures&) lands.
- virtual WebKit::WebView* createView(WebKit::WebFrame* creator);
virtual WebKit::WebView* createView(
WebKit::WebFrame* creator,
const WebKit::WebWindowFeatures& features);
diff --git a/webkit/tools/test_shell/test_webview_delegate.cc b/webkit/tools/test_shell/test_webview_delegate.cc
index 6e5c8ce..82e7907 100644
--- a/webkit/tools/test_shell/test_webview_delegate.cc
+++ b/webkit/tools/test_shell/test_webview_delegate.cc
@@ -315,12 +315,6 @@ void TestWebViewDelegate::SetAuthorAndUserStylesEnabled(bool is_enabled) {
// WebViewClient -------------------------------------------------------------
-// TODO(rafaelw): remove when
-// WebViewClient::createView(WebFrame,WebWindowFeatures) lands.
-WebView* TestWebViewDelegate::createView(WebFrame* creator) {
- return createView(creator, WebWindowFeatures());
-}
-
WebView* TestWebViewDelegate::createView(
WebFrame* creator,
const WebWindowFeatures& window_features) {
diff --git a/webkit/tools/test_shell/test_webview_delegate.h b/webkit/tools/test_shell/test_webview_delegate.h
index e2b36c77..35c8b3cf 100644
--- a/webkit/tools/test_shell/test_webview_delegate.h
+++ b/webkit/tools/test_shell/test_webview_delegate.h
@@ -75,9 +75,6 @@ class TestWebViewDelegate : public WebKit::WebViewClient,
typedef std::vector<CapturedContextMenuEvent> CapturedContextMenuEvents;
// WebKit::WebViewClient
- // TODO(rafaelw): Remove this when
- // WebViewClient::createView(WebFrame,WebWindowFeatures&) lands.
- virtual WebKit::WebView* createView(WebKit::WebFrame* creator);
virtual WebKit::WebView* createView(
WebKit::WebFrame* creator,
const WebKit::WebWindowFeatures& window_features);