diff options
| author | jar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-05-21 23:00:17 +0000 |
|---|---|---|
| committer | jar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-05-21 23:00:17 +0000 |
| commit | e462cf5a08877ea4588e28221a5c03bca45ba67b (patch) | |
| tree | 74996a069fddfd2f3feff8440e3403afad1c4a8d | |
| parent | 73cef7cc9da81a929c6a44042bac03146d95079d (diff) | |
| download | chromium_src-e462cf5a08877ea4588e28221a5c03bca45ba67b.zip chromium_src-e462cf5a08877ea4588e28221a5c03bca45ba67b.tar.gz chromium_src-e462cf5a08877ea4588e28221a5c03bca45ba67b.tar.bz2 | |
Add virtual destructor to base class to resolve leak.
This appears to resolve the regression that might have
been instigated in 44435.
This was very significant on Windows, as the derived
class held a lot of data in file_version_info_win.cc.
BUG=44320
r=mbelshe
Review URL: http://codereview.chromium.org/2131023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47964 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | base/file_version_info.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/base/file_version_info.h b/base/file_version_info.h index def2ea5..9ab7a0d 100644 --- a/base/file_version_info.h +++ b/base/file_version_info.h @@ -17,6 +17,7 @@ class FilePath; class FileVersionInfo { public: + virtual ~FileVersionInfo() {} #if defined(OS_WIN) || defined(OS_MACOSX) // Creates a FileVersionInfo for the specified path. Returns NULL if something // goes wrong (typically the file does not exit or cannot be opened). The |