summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authoryosin@chromium.org <yosin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-02-07 04:55:57 +0000
committeryosin@chromium.org <yosin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-02-07 04:55:57 +0000
commitc6b94c384107f67d826cfaf67c86e75c877b957d (patch)
tree846cf8a66b6d1a795e4f3e903f50e28a6a8e97ae
parentfde9a3294997662c45b51cc13ae9bf1fa5954328 (diff)
downloadchromium_src-c6b94c384107f67d826cfaf67c86e75c877b957d.zip
chromium_src-c6b94c384107f67d826cfaf67c86e75c877b957d.tar.gz
chromium_src-c6b94c384107f67d826cfaf67c86e75c877b957d.tar.bz2
Disable Copy and Cut menu items when only editting item is selected.
BUG=173994 TEST=On bookmark manager, Select "Add Page", Enter text into title field, Hit Ctrl+A to select text in text field, Hit Ctrl+X Review URL: https://codereview.chromium.org/12220008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181209 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--chrome/browser/resources/bookmark_manager/js/main.js13
1 files changed, 11 insertions, 2 deletions
diff --git a/chrome/browser/resources/bookmark_manager/js/main.js b/chrome/browser/resources/bookmark_manager/js/main.js
index 32ed7d7..8d9f2c4 100644
--- a/chrome/browser/resources/bookmark_manager/js/main.js
+++ b/chrome/browser/resources/bookmark_manager/js/main.js
@@ -1045,6 +1045,15 @@ function canExecuteForList(e) {
return list.selectedItems.length == 1;
}
+ function canCopyItem(item) {
+ return item.id != 'new';
+ }
+
+ function canCopyItems() {
+ var selectedItems = list.selectedItems;
+ return selectedItems && selectedItems.some(canCopyItem);
+ }
+
function isRecentOrSearch() {
return list.isRecent() || list.isSearch();
}
@@ -1082,11 +1091,11 @@ function canExecuteForList(e) {
case 'delete-command':
case 'cut-command':
- e.canExecute = hasSelected() && canEdit;
+ e.canExecute = canCopyItems() && canEdit;
break;
case 'copy-command':
- e.canExecute = hasSelected();
+ e.canExecute = canCopyItems();
break;
case 'open-in-same-window-command':