Coverity: Initialize data members in constructor.

CID=12798, 12835, 12921, 12922, 12923, 13083, 1408, 7026, 7027, 13052, 13058, 8295, 2289, 13026, 13133, 13233, 13184, 13183
BUG=none
TEST=none

Patch by Kausalya Madhusudhanan <kmadhusu@chromium.org>

Review URL: http://codereview.chromium.org/3567011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61448 0039d316-1c4b-4281-b951-d872f2087c98

18 files changed, 27 insertions, 14 deletions

diff --git a/chrome/browser/extensions/crx_installer.cc b/chrome/browser/extensions/crx_installer.cc
index 1b0bbeb..3fa5484 100644
--- a/chrome/browser/extensions/crx_installer.cc
+++ b/chrome/browser/extensions/crx_installer.cc
@@ -79,6 +79,7 @@ CrxInstaller::CrxInstaller(const FilePath& install_directory,
       delete_source_(false),
       allow_privilege_increase_(false),
       limit_web_extent_to_download_host_(false),
+      create_app_shortcut_(false),
       frontend_(frontend),
       client_(client),
       apps_require_extension_mime_type_(false),
diff --git a/chrome/browser/extensions/extension_function.cc b/chrome/browser/extensions/extension_function.cc
index 50babe1..f285e9d 100644
--- a/chrome/browser/extensions/extension_function.cc
+++ b/chrome/browser/extensions/extension_function.cc
@@ -14,7 +14,8 @@ ExtensionFunction::ExtensionFunction()
     : request_id_(-1),
       profile_(NULL),
       has_callback_(false),
-      include_incognito_(false) {
+      include_incognito_(false),
+      user_gesture_(false) {
 }
 
 ExtensionFunction::~ExtensionFunction() {
diff --git a/chrome/browser/importer/importer_data_types.cc b/chrome/browser/importer/importer_data_types.cc
index 3b327a9..13ea994 100644
--- a/chrome/browser/importer/importer_data_types.cc
+++ b/chrome/browser/importer/importer_data_types.cc
@@ -6,7 +6,7 @@
 
 namespace importer {
 
-ProfileInfo::ProfileInfo() {
+ProfileInfo::ProfileInfo() : browser_type(NO_PROFILE_TYPE) {
 }
 
 ProfileInfo::~ProfileInfo() {
diff --git a/chrome/browser/importer/importer_data_types.h b/chrome/browser/importer/importer_data_types.h
index f937d40..51376c8 100644
--- a/chrome/browser/importer/importer_data_types.h
+++ b/chrome/browser/importer/importer_data_types.h
@@ -31,6 +31,7 @@ enum ImportItem {
 // settings and data from them.  Numbers added so that data can be
 // reliably cast to ints and passed across IPC.
 enum ProfileType {
+  NO_PROFILE_TYPE = -1,
 #if defined(OS_WIN)
   MS_IE = 0,
 #endif
diff --git a/chrome/browser/importer/importer_list.cc b/chrome/browser/importer/importer_list.cc
index ba2bf83..f529284 100644
--- a/chrome/browser/importer/importer_list.cc
+++ b/chrome/browser/importer/importer_list.cc
@@ -72,6 +72,9 @@ Importer* ImporterList::CreateImporterByType(importer::ProfileType type) {
     case importer::SAFARI:
       return new SafariImporter(mac_util::GetUserLibraryPath());
 #endif  // OS_MACOSX
+    case importer::NO_PROFILE_TYPE:
+      NOTREACHED();
+      return NULL;
   }
   NOTREACHED();
   return NULL;
diff --git a/chrome/browser/safe_browsing/safe_browsing_store_file.cc b/chrome/browser/safe_browsing/safe_browsing_store_file.cc
index 4e4136c..7402d9a 100644
--- a/chrome/browser/safe_browsing/safe_browsing_store_file.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_store_file.cc
@@ -173,7 +173,8 @@ bool FileHeaderSanityCheck(const FilePath& filename,
 
 SafeBrowsingStoreFile::SafeBrowsingStoreFile()
     : chunks_written_(0),
-      file_(NULL) {
+      file_(NULL),
+      empty_(false) {
 }
 SafeBrowsingStoreFile::~SafeBrowsingStoreFile() {
   Close();
diff --git a/chrome/browser/speech/speech_recognizer.cc b/chrome/browser/speech/speech_recognizer.cc
index ce1bfaa..a9f92e0 100644
--- a/chrome/browser/speech/speech_recognizer.cc
+++ b/chrome/browser/speech/speech_recognizer.cc
@@ -111,6 +111,7 @@ SpeechRecognizer::SpeechRecognizer(Delegate* delegate, int caller_id)
       caller_id_(caller_id),
       encoder_(new SpeexEncoder()),
       endpointer_(kAudioSampleRate),
+      num_samples_recorded_(0),
       audio_level_(0.0f) {
   endpointer_.set_speech_input_complete_silence_length(
       base::Time::kMicrosecondsPerSecond / 2);
diff --git a/chrome/browser/sync/glue/sync_backend_host.h b/chrome/browser/sync/glue/sync_backend_host.h
index 3da5648..d18bf26d 100644
--- a/chrome/browser/sync/glue/sync_backend_host.h
+++ b/chrome/browser/sync/glue/sync_backend_host.h
@@ -238,13 +238,10 @@ class SyncBackendHost : public browser_sync::ModelSafeWorkerRegistrar {
             setup_for_test_mode(setup_for_test_mode) {}
 
       GURL service_url;
-      bool attempt_last_user_authentication;
       sync_api::HttpPostProviderFactory* http_bridge_factory;
       sync_api::SyncCredentials credentials;
       std::string lsid;
       bool delete_sync_data_folder;
-      bool invalidate_sync_login;
-      bool invalidate_sync_xmpp_login;
       notifier::NotifierOptions notifier_options;
       std::string restored_key_for_bootstrapping;
       bool setup_for_test_mode;
diff --git a/chrome/browser/sync/token_migrator.h b/chrome/browser/sync/token_migrator.h
index e512509..81d6f6d 100644
--- a/chrome/browser/sync/token_migrator.h
+++ b/chrome/browser/sync/token_migrator.h
@@ -44,9 +44,6 @@ class TokenMigrator {
   // PostTokensBack is called.
   ProfileSyncService* service_;
 
-  // Pending tasks, stored so they can be canceled if this object is destroyed.
-  CancelableTask* loading_task_;
-
   // The directory to search for the user settings database.
   FilePath database_location_;
 
diff --git a/chrome/common/chrome_plugin_lib.cc b/chrome/common/chrome_plugin_lib.cc
index 1e74f4c..2b78ed25c 100644
--- a/chrome/common/chrome_plugin_lib.cc
+++ b/chrome/common/chrome_plugin_lib.cc
@@ -189,7 +189,8 @@ ChromePluginLib::ChromePluginLib(const FilePath& filename)
 #endif
       initialized_(false),
       CP_VersionNegotiate_(NULL),
-      CP_Initialize_(NULL) {
+      CP_Initialize_(NULL),
+      CP_Test_(NULL) {
   memset((void*)&plugin_funcs_, 0, sizeof(plugin_funcs_));
 }
 
diff --git a/chrome/common/deprecated/event_sys-inl.h b/chrome/common/deprecated/event_sys-inl.h
index 2699a58..835eabe 100644
--- a/chrome/common/deprecated/event_sys-inl.h
+++ b/chrome/common/deprecated/event_sys-inl.h
@@ -107,6 +107,7 @@ class EventChannel {
   // The shutdown event gets send in the EventChannel's destructor.
   explicit EventChannel(const EventType& shutdown_event)
     : current_listener_callback_(NULL),
+      current_listener_callback_message_loop_(NULL),
       callback_waiters_(NULL),
       shutdown_event_(shutdown_event) {
   }
diff --git a/chrome/common/file_system/webfilewriter_impl.cc b/chrome/common/file_system/webfilewriter_impl.cc
index 0d04741..f579e25 100644
--- a/chrome/common/file_system/webfilewriter_impl.cc
+++ b/chrome/common/file_system/webfilewriter_impl.cc
@@ -15,6 +15,7 @@ WebFileWriterImpl::WebFileWriterImpl(
      const WebKit::WebString& path, WebKit::WebFileWriterClient* client)
   : path_(webkit_glue::WebStringToFilePath(path)),
     client_(client),
+    request_id_(0),
     operation_(kOperationNone),
     cancel_state_(kCancelNotInProgress) {
 }
diff --git a/chrome/common/net/gaia/gaia_authenticator.cc b/chrome/common/net/gaia/gaia_authenticator.cc
index 7a7322c..563ee3a 100644
--- a/chrome/common/net/gaia/gaia_authenticator.cc
+++ b/chrome/common/net/gaia/gaia_authenticator.cc
@@ -30,7 +30,8 @@ GaiaAuthenticator::AuthResults::AuthResults() : auth_error(None) {}
 
 GaiaAuthenticator::AuthResults::~AuthResults() {}
 
-GaiaAuthenticator::AuthParams::AuthParams() {}
+GaiaAuthenticator::AuthParams::AuthParams() : authenticator(NULL),
+                                              request_id(0) {}
 
 GaiaAuthenticator::AuthParams::~AuthParams() {}
 
diff --git a/chrome/common/plugin_messages.cc b/chrome/common/plugin_messages.cc
index ab80827..aeb3905 100644
--- a/chrome/common/plugin_messages.cc
+++ b/chrome/common/plugin_messages.cc
@@ -12,7 +12,8 @@
 #include "ipc/ipc_message_impl_macros.h"
 
 PluginMsg_Init_Params::PluginMsg_Init_Params()
-    : load_manually(false),
+    : containing_window(0),
+      load_manually(false),
       host_render_view_routing_id(-1) {
 }
 
diff --git a/chrome/common/render_messages_params.cc b/chrome/common/render_messages_params.cc
index 1414b8a..074579b 100644
--- a/chrome/common/render_messages_params.cc
+++ b/chrome/common/render_messages_params.cc
@@ -40,6 +40,8 @@ ViewHostMsg_UpdateRect_Params::ViewHostMsg_UpdateRect_Params()
     : dx(0),
       dy(0),
       flags(0) {
+    // On windows, bitmap is of type "struct HandleAndSequenceNum"
+    memset(&bitmap, 0, sizeof(bitmap));
 }
 
 ViewHostMsg_UpdateRect_Params::~ViewHostMsg_UpdateRect_Params() {
@@ -181,7 +183,8 @@ ViewHostMsg_IDBFactoryOpen_Params::~ViewHostMsg_IDBFactoryOpen_Params() {
 ViewHostMsg_IDBDatabaseCreateObjectStore_Params::
     ViewHostMsg_IDBDatabaseCreateObjectStore_Params()
     : response_id_(0),
-      auto_increment_(false) {
+      auto_increment_(false),
+      idb_database_id_(0) {
 }
 
 ViewHostMsg_IDBDatabaseCreateObjectStore_Params::
diff --git a/chrome/gpu/media/fake_gl_video_decode_engine.cc b/chrome/gpu/media/fake_gl_video_decode_engine.cc
index b3d093f..4badc0e 100644
--- a/chrome/gpu/media/fake_gl_video_decode_engine.cc
+++ b/chrome/gpu/media/fake_gl_video_decode_engine.cc
@@ -10,7 +10,8 @@
 FakeGlVideoDecodeEngine::FakeGlVideoDecodeEngine()
     : width_(0),
       height_(0),
-      handler_(NULL) {
+      handler_(NULL),
+      context_(NULL) {
 }
 
 FakeGlVideoDecodeEngine::~FakeGlVideoDecodeEngine() {
diff --git a/chrome/renderer/extensions/extension_renderer_info.cc b/chrome/renderer/extensions/extension_renderer_info.cc
index 24d0064..ea12268 100644
--- a/chrome/renderer/extensions/extension_renderer_info.cc
+++ b/chrome/renderer/extensions/extension_renderer_info.cc
@@ -24,6 +24,7 @@ ExtensionRendererInfo::ExtensionRendererInfo(
   allowed_to_execute_script_everywhere_ =
       that.allowed_to_execute_script_everywhere_;
   host_permissions_ = that.host_permissions_;
+  location_ = that.location_;
 }
 
 ExtensionRendererInfo::~ExtensionRendererInfo() {
diff --git a/chrome/renderer/gpu_video_decoder_host.cc b/chrome/renderer/gpu_video_decoder_host.cc
index eda93c6..08e7d5d 100644
--- a/chrome/renderer/gpu_video_decoder_host.cc
+++ b/chrome/renderer/gpu_video_decoder_host.cc
@@ -20,6 +20,7 @@ GpuVideoDecoderHost::GpuVideoDecoderHost(GpuVideoServiceHost* service_host,
       input_buffer_busy_(false) {
   memset(&config_, 0, sizeof(config_));
   memset(&done_param_, 0, sizeof(done_param_));
+  memset(&decoder_info_, 0, sizeof(decoder_info_));
 }
 
 void GpuVideoDecoderHost::OnChannelError() {