summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authordcheng@chromium.org <dcheng@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-11-07 22:06:37 +0000
committerdcheng@chromium.org <dcheng@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-11-07 22:06:37 +0000
commitc7df61b00031cb61da53133ae145042fa5f77164 (patch)
tree2f7b0ec65ddd8fd8234314b69c3420bb1e516d00
parent562b8d289eb1db9b1253691c83b7c5fcc7138602 (diff)
downloadchromium_src-c7df61b00031cb61da53133ae145042fa5f77164.zip
chromium_src-c7df61b00031cb61da53133ae145042fa5f77164.tar.gz
chromium_src-c7df61b00031cb61da53133ae145042fa5f77164.tar.bz2
Cleanup old NotificationProvider::grantPermission overload.
BUG=94399 TEST=chrome, DumpRenderTree, and test_shell compile. Review URL: http://codereview.chromium.org/8492002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108921 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--chrome/browser/chrome_content_browser_client.cc4
-rw-r--r--content/renderer/notification_provider.cc10
-rw-r--r--content/renderer/notification_provider.h3
-rw-r--r--webkit/tools/test_shell/notification_presenter.cc9
-rw-r--r--webkit/tools/test_shell/notification_presenter.h1
5 files changed, 1 insertions, 26 deletions
diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
index 4909a7f..210e28a 100644
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -789,10 +789,8 @@ WebKit::WebNotificationPresenter::Permission
// Fall back to the regular notification preferences, which works on an
// origin basis.
- // TODO(dcheng): Change to just source_origin once WebKit side is cleaned up.
return io_data->GetNotificationService() ?
- io_data->GetNotificationService()->HasPermission(
- source_origin.GetOrigin()) :
+ io_data->GetNotificationService()->HasPermission(source_origin) :
WebKit::WebNotificationPresenter::PermissionNotAllowed;
}
diff --git a/content/renderer/notification_provider.cc b/content/renderer/notification_provider.cc
index 54e1fdf..7bf733f 100644
--- a/content/renderer/notification_provider.cc
+++ b/content/renderer/notification_provider.cc
@@ -66,16 +66,6 @@ WebNotificationPresenter::Permission NotificationProvider::checkPermission(
return static_cast<WebNotificationPresenter::Permission>(permission);
}
-WebNotificationPresenter::Permission NotificationProvider::checkPermission(
- const WebURL& origin) {
- int permission;
- Send(new DesktopNotificationHostMsg_CheckPermission(
- routing_id(),
- origin,
- &permission));
- return static_cast<WebNotificationPresenter::Permission>(permission);
-}
-
void NotificationProvider::requestPermission(
const WebSecurityOrigin& origin,
WebNotificationPermissionCallback* callback) {
diff --git a/content/renderer/notification_provider.h b/content/renderer/notification_provider.h
index 6664388..1e100b1 100644
--- a/content/renderer/notification_provider.h
+++ b/content/renderer/notification_provider.h
@@ -35,9 +35,6 @@ class NotificationProvider : public content::RenderViewObserver,
virtual void objectDestroyed(const WebKit::WebNotification& proxy);
virtual WebKit::WebNotificationPresenter::Permission checkPermission(
const WebKit::WebSecurityOrigin& origin);
- // Deprecated, and will be removed after the WebKit roll.
- virtual WebKit::WebNotificationPresenter::Permission checkPermission(
- const WebKit::WebURL& origin);
virtual void requestPermission(const WebKit::WebSecurityOrigin& origin,
WebKit::WebNotificationPermissionCallback* callback);
diff --git a/webkit/tools/test_shell/notification_presenter.cc b/webkit/tools/test_shell/notification_presenter.cc
index cd0a177..7e7967e 100644
--- a/webkit/tools/test_shell/notification_presenter.cc
+++ b/webkit/tools/test_shell/notification_presenter.cc
@@ -104,15 +104,6 @@ WebNotificationPresenter::Permission TestNotificationPresenter::checkPermission(
: WebNotificationPresenter::PermissionDenied;
}
-WebNotificationPresenter::Permission TestNotificationPresenter::checkPermission(
- const WebURL& url) {
- // Check with the layout test controller
- std::string origin = static_cast<GURL>(url).GetOrigin().spec();
- bool allowed = allowed_origins_.find(origin) != allowed_origins_.end();
- return allowed ? WebNotificationPresenter::PermissionAllowed
- : WebNotificationPresenter::PermissionDenied;
-}
-
void TestNotificationPresenter::requestPermission(
const WebSecurityOrigin& origin,
WebNotificationPermissionCallback* callback) {
diff --git a/webkit/tools/test_shell/notification_presenter.h b/webkit/tools/test_shell/notification_presenter.h
index 734f221..9e3fcff 100644
--- a/webkit/tools/test_shell/notification_presenter.h
+++ b/webkit/tools/test_shell/notification_presenter.h
@@ -29,7 +29,6 @@ class TestNotificationPresenter : public WebKit::WebNotificationPresenter {
virtual void cancel(const WebKit::WebNotification&);
virtual void objectDestroyed(const WebKit::WebNotification&);
virtual Permission checkPermission(const WebKit::WebSecurityOrigin& origin);
- virtual Permission checkPermission(const WebKit::WebURL& url);
virtual void requestPermission(const WebKit::WebSecurityOrigin& origin,
WebKit::WebNotificationPermissionCallback* callback);