summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorbattre@chromium.org <battre@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-04-05 12:36:48 +0000
committerbattre@chromium.org <battre@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-04-05 12:36:48 +0000
commitd1b967badb523fc47d6f445978c9e57738b9146b (patch)
tree55211777a167d7f38771d18ee6900181f9a44850
parentb563f739ca907961b5322afb59eda80d1b17865b (diff)
downloadchromium_src-d1b967badb523fc47d6f445978c9e57738b9146b.zip
chromium_src-d1b967badb523fc47d6f445978c9e57738b9146b.tar.gz
chromium_src-d1b967badb523fc47d6f445978c9e57738b9146b.tar.bz2
Get rid of PrefService::GetMutableDictionary/GetMutableList
BUG=77914 TEST=none, trybots remain green Review URL: http://codereview.chromium.org/6735027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80443 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--chrome/browser/notifications/desktop_notification_service_unittest.cc14
1 files changed, 6 insertions, 8 deletions
diff --git a/chrome/browser/notifications/desktop_notification_service_unittest.cc b/chrome/browser/notifications/desktop_notification_service_unittest.cc
index 5e700d5..0ad39cb 100644
--- a/chrome/browser/notifications/desktop_notification_service_unittest.cc
+++ b/chrome/browser/notifications/desktop_notification_service_unittest.cc
@@ -198,20 +198,18 @@ TEST_F(DesktopNotificationServiceTest, DenyPermissionSentToCache) {
TEST_F(DesktopNotificationServiceTest, PrefChangesSentToCache) {
PrefService* prefs = profile()->GetPrefs();
- ListValue* allowed_sites =
- prefs->GetMutableList(prefs::kDesktopNotificationAllowedOrigins);
{
- allowed_sites->Append(new StringValue(GURL("http://allowed.com").spec()));
- ScopedUserPrefUpdate updateAllowed(
+ ListPrefUpdate update_allowed_origins(
prefs, prefs::kDesktopNotificationAllowedOrigins);
+ ListValue* allowed_origins = update_allowed_origins.Get();
+ allowed_origins->Append(new StringValue(GURL("http://allowed.com").spec()));
}
- ListValue* denied_sites =
- prefs->GetMutableList(prefs::kDesktopNotificationDeniedOrigins);
{
- denied_sites->Append(new StringValue(GURL("http://denied.com").spec()));
- ScopedUserPrefUpdate updateDenied(
+ ListPrefUpdate update_denied_origins(
prefs, prefs::kDesktopNotificationDeniedOrigins);
+ ListValue* denied_origins = update_denied_origins.Get();
+ denied_origins->Append(new StringValue(GURL("http://denied.com").spec()));
}
EXPECT_EQ(WebKit::WebNotificationPresenter::PermissionAllowed,