summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorkkania@chromium.org <kkania@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-06-01 00:36:42 +0000
committerkkania@chromium.org <kkania@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-06-01 00:36:42 +0000
commita9030b828efc3b1312264875c1f76b35708eb000 (patch)
tree2379a404a2305df6b5dd756d7fd627f30cbc81ed
parent2cbb7dc21783219787b41dcc829b4020e221cc5a (diff)
downloadchromium_src-a9030b828efc3b1312264875c1f76b35708eb000.zip
chromium_src-a9030b828efc3b1312264875c1f76b35708eb000.tar.gz
chromium_src-a9030b828efc3b1312264875c1f76b35708eb000.tar.bz2
[chromedriver] Release ChromeDriver 2.0.
BUG=none NOTRY=true Review URL: https://chromiumcodereview.appspot.com/15968013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203532 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--chrome/test/chromedriver/chrome/version.cc3
-rwxr-xr-xchrome/test/chromedriver/run_buildbot_steps.py17
2 files changed, 16 insertions, 4 deletions
diff --git a/chrome/test/chromedriver/chrome/version.cc b/chrome/test/chromedriver/chrome/version.cc
index abf9af8..5b481572 100644
--- a/chrome/test/chromedriver/chrome/version.cc
+++ b/chrome/test/chromedriver/chrome/version.cc
@@ -8,12 +8,13 @@
namespace {
+// This variable must be able to be found and parsed by the upload script.
const int kMinimumSupportedChromeVersion[] = {27, 0, 1453, 0};
} // namespace
// This variable must be able to be found and parsed by the upload script.
-const char kChromeDriverVersion[] = "0.9";
+const char kChromeDriverVersion[] = "2.0";
const int kMinimumSupportedChromeBuildNo = kMinimumSupportedChromeVersion[2];
diff --git a/chrome/test/chromedriver/run_buildbot_steps.py b/chrome/test/chromedriver/run_buildbot_steps.py
index 75c56d4..9fbab4f 100755
--- a/chrome/test/chromedriver/run_buildbot_steps.py
+++ b/chrome/test/chromedriver/run_buildbot_steps.py
@@ -80,14 +80,22 @@ def Download():
def MaybeRelease(revision):
# Version is embedded as: const char kChromeDriverVersion[] = "0.1";
+ # Minimum supported Chrome version is embedded as:
+ # const int kMinimumSupportedChromeVersion[] = {27, 0, 1453, 0};
with open(os.path.join(_THIS_DIR, 'chrome', 'version.cc'), 'r') as f:
- version_line = filter(lambda x: 'kChromeDriverVersion' in x, f.readlines())
+ lines = f.readlines()
+ version_line = filter(lambda x: 'kChromeDriverVersion' in x, lines)
+ chrome_min_version_line = filter(
+ lambda x: 'kMinimumSupportedChromeVersion' in x, lines)
version = version_line[0].split('"')[1]
+ chrome_min_version = chrome_min_version_line[0].split('{')[1].split(',')[0]
+ with open(os.path.join(chrome_paths.GetSrc(), 'chrome', 'VERSION'), 'r') as f:
+ chrome_max_version = f.readlines()[0].split('=')[1]
bitness = '32'
if util.IsLinux() and platform.architecture()[0] == '64bit':
bitness = '64'
- zip_name = 'chromedriver2_%s%s_%s.zip' % (
+ zip_name = 'chromedriver_%s%s_%s.zip' % (
util.GetPlatformName(), bitness, version)
site = 'https://code.google.com/p/chromedriver/downloads/list'
@@ -119,7 +127,10 @@ def MaybeRelease(revision):
sys.executable,
os.path.join(_THIS_DIR, 'third_party', 'googlecode',
'googlecode_upload.py'),
- '--summary', 'version of ChromeDriver2 r%s' % revision,
+ '--summary',
+ 'ChromeDriver server for %s%s (v%s.%s.dyu) supports Chrome v%s-%s' % (
+ util.GetPlatformName(), bitness, version, revision,
+ chrome_min_version, chrome_max_version),
'--project', 'chromedriver',
'--user', 'chromedriver.bot@gmail.com',
zip_path