diff options
author | sadrul@chromium.org <sadrul@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-09-07 03:21:04 +0000 |
---|---|---|
committer | sadrul@chromium.org <sadrul@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-09-07 03:21:04 +0000 |
commit | bb99d70f77e537ffc7ec0921d90c13e3cf689615 (patch) | |
tree | 931c34246bed527a838c19a52864483b114335f4 | |
parent | 214a88cc01c887c3b3d7d21b76867871203087dd (diff) | |
download | chromium_src-bb99d70f77e537ffc7ec0921d90c13e3cf689615.zip chromium_src-bb99d70f77e537ffc7ec0921d90c13e3cf689615.tar.gz chromium_src-bb99d70f77e537ffc7ec0921d90c13e3cf689615.tar.bz2 |
gtk: Allow building both the X11 and Gtk message-pumps for gtk.
This patch allows both the X11 and the Gtk message-pumps to be built
in a linux-gtk build. A subsequent patch will use the X11 message-pump
for the GPU process, while continue to use the Gtk message-pump for the
browser process.
BUG=145600
R=ccameron@chromium.org, oshima@chromium.org, piman@chromium.org, thakis@chromium.org
Review URL: https://codereview.chromium.org/23880006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221873 0039d316-1c4b-4281-b951-d872f2087c98
26 files changed, 120 insertions, 114 deletions
diff --git a/ash/display/mirror_window_controller.cc b/ash/display/mirror_window_controller.cc index 8fa0833..32d3874 100644 --- a/ash/display/mirror_window_controller.cc +++ b/ash/display/mirror_window_controller.cc @@ -43,7 +43,7 @@ namespace { void DisableInput(XID window) { long event_mask = ExposureMask | VisibilityChangeMask | StructureNotifyMask | PropertyChangeMask; - XSelectInput(base::MessagePumpAuraX11::GetDefaultXDisplay(), + XSelectInput(base::MessagePumpX11::GetDefaultXDisplay(), window, event_mask); } #endif diff --git a/ash/shell.cc b/ash/shell.cc index 12a547f..badb7e4 100644 --- a/ash/shell.cc +++ b/ash/shell.cc @@ -116,7 +116,7 @@ #include "ash/display/display_error_observer_chromeos.h" #include "ash/display/output_configurator_animation.h" #include "base/chromeos/chromeos_version.h" -#include "base/message_loop/message_pump_aurax11.h" +#include "base/message_loop/message_pump_x11.h" #include "chromeos/display/output_configurator.h" #include "content/public/browser/gpu_data_manager.h" #include "gpu/config/gpu_feature_type.h" @@ -230,11 +230,11 @@ Shell::Shell(ShellDelegate* delegate) output_configurator_->Init(!is_panel_fitting_disabled); - base::MessagePumpAuraX11::Current()->AddDispatcherForRootWindow( + base::MessagePumpX11::Current()->AddDispatcherForRootWindow( output_configurator()); // We can't do this with a root window listener because XI_HierarchyChanged // messages don't have a target window. - base::MessagePumpAuraX11::Current()->AddObserver(output_configurator()); + base::MessagePumpX11::Current()->AddObserver(output_configurator()); #endif // defined(OS_CHROMEOS) AddPreTargetHandler(this); @@ -329,9 +329,9 @@ Shell::~Shell() { output_configurator_->RemoveObserver(output_configurator_animation_.get()); if (display_error_observer_) output_configurator_->RemoveObserver(display_error_observer_.get()); - base::MessagePumpAuraX11::Current()->RemoveDispatcherForRootWindow( + base::MessagePumpX11::Current()->RemoveDispatcherForRootWindow( output_configurator()); - base::MessagePumpAuraX11::Current()->RemoveObserver(output_configurator()); + base::MessagePumpX11::Current()->RemoveObserver(output_configurator()); display_change_observer_.reset(); #endif // defined(OS_CHROMEOS) diff --git a/base/base.gyp b/base/base.gyp index 2272d56..94bb2f3 100644 --- a/base/base.gyp +++ b/base/base.gyp @@ -257,12 +257,12 @@ 'message_loop/message_pump_io_ios.cc', 'message_loop/message_pump_io_ios.h', 'message_loop/message_pump_observer.h', - 'message_loop/message_pump_aurax11.cc', - 'message_loop/message_pump_aurax11.h', 'message_loop/message_pump_libevent.cc', 'message_loop/message_pump_libevent.h', 'message_loop/message_pump_mac.h', 'message_loop/message_pump_mac.mm', + 'message_loop/message_pump_x11.cc', + 'message_loop/message_pump_x11.h', 'metrics/field_trial.cc', 'metrics/field_trial.h', 'posix/file_descriptor_shuffle.cc', diff --git a/base/base.gypi b/base/base.gypi index d34b39d..1a0b719 100644 --- a/base/base.gypi +++ b/base/base.gypi @@ -690,7 +690,7 @@ 'sources!': [ 'atomicops_internals_x86_gcc.cc', 'message_loop/message_pump_glib.cc', - 'message_loop/message_pump_aurax11.cc', + 'message_loop/message_pump_x11.cc', ], }], ['<(toolkit_uses_gtk)==0 or >(nacl_untrusted_build)==1', { @@ -856,7 +856,7 @@ ['<(use_ozone) == 1', { 'sources!': [ 'message_loop/message_pump_glib.cc', - 'message_loop/message_pump_aurax11.cc', + 'message_loop/message_pump_x11.cc', ] }], ['OS == "linux" and >(nacl_untrusted_build)==0', { diff --git a/base/message_loop/message_loop.h b/base/message_loop/message_loop.h index de602af..bdad1b2 100644 --- a/base/message_loop/message_loop.h +++ b/base/message_loop/message_loop.h @@ -36,7 +36,7 @@ #if !defined(OS_MACOSX) && !defined(OS_ANDROID) #if defined(USE_AURA) && defined(USE_X11) && !defined(OS_NACL) -#include "base/message_loop/message_pump_aurax11.h" +#include "base/message_loop/message_pump_x11.h" #elif defined(USE_OZONE) && !defined(OS_NACL) #include "base/message_loop/message_pump_ozone.h" #else @@ -600,7 +600,7 @@ class BASE_EXPORT MessageLoopForUI : public MessageLoop { protected: #if defined(USE_AURA) && defined(USE_X11) && !defined(OS_NACL) - friend class MessagePumpAuraX11; + friend class MessagePumpX11; #endif #if defined(USE_OZONE) && !defined(OS_NACL) friend class MessagePumpOzone; diff --git a/base/message_loop/message_pump_observer.h b/base/message_loop/message_pump_observer.h index cb46fa3..333a75f 100644 --- a/base/message_loop/message_pump_observer.h +++ b/base/message_loop/message_pump_observer.h @@ -19,11 +19,11 @@ enum EventStatus { // A MessagePumpObserver is an object that receives global // notifications from the UI MessageLoop with MessagePumpWin or -// MessagePumpAuraX11. +// MessagePumpX11. // // NOTE: An Observer implementation should be extremely fast! // -// For use with MessagePumpAuraX11, please see message_pump_glib.h for more +// For use with MessagePumpX11, please see message_pump_glib.h for more // info about how this is invoked in this environment. class BASE_EXPORT MessagePumpObserver { public: diff --git a/base/message_loop/message_pump_aurax11.cc b/base/message_loop/message_pump_x11.cc index 54be49f..7e780b2 100644 --- a/base/message_loop/message_pump_aurax11.cc +++ b/base/message_loop/message_pump_x11.cc @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "base/message_loop/message_pump_aurax11.h" +#include "base/message_loop/message_pump_x11.h" #include <glib.h> #include <X11/X.h> @@ -17,7 +17,7 @@ namespace base { namespace { gboolean XSourcePrepare(GSource* source, gint* timeout_ms) { - if (XPending(MessagePumpAuraX11::GetDefaultXDisplay())) + if (XPending(MessagePumpX11::GetDefaultXDisplay())) *timeout_ms = 0; else *timeout_ms = -1; @@ -25,13 +25,13 @@ gboolean XSourcePrepare(GSource* source, gint* timeout_ms) { } gboolean XSourceCheck(GSource* source) { - return XPending(MessagePumpAuraX11::GetDefaultXDisplay()); + return XPending(MessagePumpX11::GetDefaultXDisplay()); } gboolean XSourceDispatch(GSource* source, GSourceFunc unused_func, gpointer data) { - MessagePumpAuraX11* pump = static_cast<MessagePumpAuraX11*>(data); + MessagePumpX11* pump = static_cast<MessagePumpX11*>(data); return pump->DispatchXEvents(); } @@ -43,18 +43,18 @@ GSourceFuncs XSourceFuncs = { }; // The connection is essentially a global that's accessed through a static -// method and destroyed whenever ~MessagePumpAuraX11() is called. We do this +// method and destroyed whenever ~MessagePumpX11() is called. We do this // for historical reasons so user code can call // MessagePumpForUI::GetDefaultXDisplay() where MessagePumpForUI is a typedef // to whatever type in the current build. // // TODO(erg): This can be changed to something more sane like -// MessagePumpAuraX11::Current()->display() once MessagePumpGtk goes away. +// MessagePumpX11::Current()->display() once MessagePumpGtk goes away. Display* g_xdisplay = NULL; int g_xinput_opcode = -1; bool InitializeXInput2Internal() { - Display* display = MessagePumpAuraX11::GetDefaultXDisplay(); + Display* display = MessagePumpX11::GetDefaultXDisplay(); if (!display) return false; @@ -103,7 +103,7 @@ bool InitializeXInput2() { } bool InitializeXkb() { - Display* display = MessagePumpAuraX11::GetDefaultXDisplay(); + Display* display = MessagePumpX11::GetDefaultXDisplay(); if (!display) return false; @@ -128,7 +128,7 @@ bool InitializeXkb() { } // namespace -MessagePumpAuraX11::MessagePumpAuraX11() : MessagePumpGlib(), +MessagePumpX11::MessagePumpX11() : MessagePumpGlib(), x_source_(NULL) { InitializeXInput2(); InitializeXkb(); @@ -139,7 +139,7 @@ MessagePumpAuraX11::MessagePumpAuraX11() : MessagePumpGlib(), x_root_window_ = DefaultRootWindow(g_xdisplay); } -MessagePumpAuraX11::~MessagePumpAuraX11() { +MessagePumpX11::~MessagePumpX11() { g_source_destroy(x_source_); g_source_unref(x_source_); XCloseDisplay(g_xdisplay); @@ -147,52 +147,54 @@ MessagePumpAuraX11::~MessagePumpAuraX11() { } // static -Display* MessagePumpAuraX11::GetDefaultXDisplay() { +Display* MessagePumpX11::GetDefaultXDisplay() { if (!g_xdisplay) g_xdisplay = XOpenDisplay(NULL); return g_xdisplay; } // static -bool MessagePumpAuraX11::HasXInput2() { +bool MessagePumpX11::HasXInput2() { return InitializeXInput2(); } +#if !defined(TOOLKIT_GTK) // static -MessagePumpAuraX11* MessagePumpAuraX11::Current() { +MessagePumpX11* MessagePumpX11::Current() { MessageLoopForUI* loop = MessageLoopForUI::current(); - return static_cast<MessagePumpAuraX11*>(loop->pump_ui()); + return static_cast<MessagePumpX11*>(loop->pump_ui()); } +#endif -void MessagePumpAuraX11::AddDispatcherForWindow( +void MessagePumpX11::AddDispatcherForWindow( MessagePumpDispatcher* dispatcher, unsigned long xid) { dispatchers_.insert(std::make_pair(xid, dispatcher)); } -void MessagePumpAuraX11::RemoveDispatcherForWindow(unsigned long xid) { +void MessagePumpX11::RemoveDispatcherForWindow(unsigned long xid) { dispatchers_.erase(xid); } -void MessagePumpAuraX11::AddDispatcherForRootWindow( +void MessagePumpX11::AddDispatcherForRootWindow( MessagePumpDispatcher* dispatcher) { root_window_dispatchers_.AddObserver(dispatcher); } -void MessagePumpAuraX11::RemoveDispatcherForRootWindow( +void MessagePumpX11::RemoveDispatcherForRootWindow( MessagePumpDispatcher* dispatcher) { root_window_dispatchers_.RemoveObserver(dispatcher); } -void MessagePumpAuraX11::AddObserver(MessagePumpObserver* observer) { +void MessagePumpX11::AddObserver(MessagePumpObserver* observer) { observers_.AddObserver(observer); } -void MessagePumpAuraX11::RemoveObserver(MessagePumpObserver* observer) { +void MessagePumpX11::RemoveObserver(MessagePumpObserver* observer) { observers_.RemoveObserver(observer); } -bool MessagePumpAuraX11::DispatchXEvents() { +bool MessagePumpX11::DispatchXEvents() { Display* display = GetDefaultXDisplay(); DCHECK(display); MessagePumpDispatcher* dispatcher = @@ -209,7 +211,7 @@ bool MessagePumpAuraX11::DispatchXEvents() { return TRUE; } -void MessagePumpAuraX11::BlockUntilWindowMapped(unsigned long xid) { +void MessagePumpX11::BlockUntilWindowMapped(unsigned long xid) { XEvent event; Display* display = GetDefaultXDisplay(); @@ -226,7 +228,7 @@ void MessagePumpAuraX11::BlockUntilWindowMapped(unsigned long xid) { } while (event.type != MapNotify); } -void MessagePumpAuraX11::InitXSource() { +void MessagePumpX11::InitXSource() { // CHECKs are to help track down crbug.com/113106. CHECK(!x_source_); Display* display = GetDefaultXDisplay(); @@ -243,7 +245,7 @@ void MessagePumpAuraX11::InitXSource() { g_source_attach(x_source_, g_main_context_default()); } -bool MessagePumpAuraX11::ProcessXEvent(MessagePumpDispatcher* dispatcher, +bool MessagePumpX11::ProcessXEvent(MessagePumpDispatcher* dispatcher, XEvent* xev) { bool should_quit = false; @@ -268,7 +270,7 @@ bool MessagePumpAuraX11::ProcessXEvent(MessagePumpDispatcher* dispatcher, return should_quit; } -bool MessagePumpAuraX11::WillProcessXEvent(XEvent* xevent) { +bool MessagePumpX11::WillProcessXEvent(XEvent* xevent) { if (!observers().might_have_observers()) return false; ObserverListBase<MessagePumpObserver>::Iterator it(observers()); @@ -280,18 +282,18 @@ bool MessagePumpAuraX11::WillProcessXEvent(XEvent* xevent) { return false; } -void MessagePumpAuraX11::DidProcessXEvent(XEvent* xevent) { +void MessagePumpX11::DidProcessXEvent(XEvent* xevent) { FOR_EACH_OBSERVER(MessagePumpObserver, observers(), DidProcessEvent(xevent)); } -MessagePumpDispatcher* MessagePumpAuraX11::GetDispatcherForXEvent( +MessagePumpDispatcher* MessagePumpX11::GetDispatcherForXEvent( const NativeEvent& xev) const { ::Window x_window = FindEventTarget(xev); DispatchersMap::const_iterator it = dispatchers_.find(x_window); return it != dispatchers_.end() ? it->second : NULL; } -bool MessagePumpAuraX11::Dispatch(const NativeEvent& xev) { +bool MessagePumpX11::Dispatch(const NativeEvent& xev) { // MappingNotify events (meaning that the keyboard or pointer buttons have // been remapped) aren't associated with a window; send them to all // dispatchers. diff --git a/base/message_loop/message_pump_aurax11.h b/base/message_loop/message_pump_x11.h index 52647c3..6f2c609 100644 --- a/base/message_loop/message_pump_aurax11.h +++ b/base/message_loop/message_pump_x11.h @@ -2,8 +2,8 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#ifndef BASE_MESSAGE_LOOP_MESSAGE_PUMP_AURAX11_H -#define BASE_MESSAGE_LOOP_MESSAGE_PUMP_AURAX11_H +#ifndef BASE_MESSAGE_LOOP_MESSAGE_PUMP_X11_H +#define BASE_MESSAGE_LOOP_MESSAGE_PUMP_X11_H #include <bitset> #include <map> @@ -31,11 +31,11 @@ namespace base { // If there's a current dispatcher given through RunWithDispatcher(), that // dispatcher receives events. Otherwise, we route to messages to dispatchers // who have subscribed to messages from a specific X11 window. -class BASE_EXPORT MessagePumpAuraX11 : public MessagePumpGlib, - public MessagePumpDispatcher { +class BASE_EXPORT MessagePumpX11 : public MessagePumpGlib, + public MessagePumpDispatcher { public: - MessagePumpAuraX11(); - virtual ~MessagePumpAuraX11(); + MessagePumpX11(); + virtual ~MessagePumpX11(); // Returns default X Display. static Display* GetDefaultXDisplay(); @@ -43,8 +43,10 @@ class BASE_EXPORT MessagePumpAuraX11 : public MessagePumpGlib, // Returns true if the system supports XINPUT2. static bool HasXInput2(); +#if !defined(TOOLKIT_GTK) // Returns the UI message pump. - static MessagePumpAuraX11* Current(); + static MessagePumpX11* Current(); +#endif // Adds/Removes |dispatcher| for the |xid|. This will route all messages from // the window |xid| to |dispatcher. @@ -122,11 +124,13 @@ class BASE_EXPORT MessagePumpAuraX11 : public MessagePumpGlib, unsigned long x_root_window_; - DISALLOW_COPY_AND_ASSIGN(MessagePumpAuraX11); + DISALLOW_COPY_AND_ASSIGN(MessagePumpX11); }; -typedef MessagePumpAuraX11 MessagePumpForUI; +#if !defined(TOOLKIT_GTK) +typedef MessagePumpX11 MessagePumpForUI; +#endif } // namespace base -#endif // BASE_MESSAGE_LOOP_MESSAGE_PUMP_AURAX11_H +#endif // BASE_MESSAGE_LOOP_MESSAGE_PUMP_X11_H diff --git a/chromeos/display/output_util.cc b/chromeos/display/output_util.cc index 4800a2d..45f9b6a 100644 --- a/chromeos/display/output_util.cc +++ b/chromeos/display/output_util.cc @@ -39,7 +39,7 @@ bool IsRandRAvailable() { int randr_version_major = 0; int randr_version_minor = 0; static bool is_randr_available = XRRQueryVersion( - base::MessagePumpAuraX11::GetDefaultXDisplay(), + base::MessagePumpX11::GetDefaultXDisplay(), &randr_version_major, &randr_version_minor); return is_randr_available; } @@ -53,10 +53,10 @@ bool GetEDIDProperty(XID output, unsigned long* nitems, unsigned char** prop) { if (!IsRandRAvailable()) return false; - Display* display = base::MessagePumpAuraX11::GetDefaultXDisplay(); + Display* display = base::MessagePumpX11::GetDefaultXDisplay(); static Atom edid_property = XInternAtom( - base::MessagePumpAuraX11::GetDefaultXDisplay(), + base::MessagePumpX11::GetDefaultXDisplay(), RR_PROPERTY_RANDR_EDID, false); bool has_edid_property = false; diff --git a/chromeos/display/real_output_configurator_delegate.cc b/chromeos/display/real_output_configurator_delegate.cc index 6d0c782..2788bd3 100644 --- a/chromeos/display/real_output_configurator_delegate.cc +++ b/chromeos/display/real_output_configurator_delegate.cc @@ -16,7 +16,7 @@ #include <utility> #include "base/logging.h" -#include "base/message_loop/message_pump_aurax11.h" +#include "base/message_loop/message_pump_x11.h" #include "chromeos/dbus/dbus_thread_manager.h" #include "chromeos/dbus/power_manager_client.h" #include "chromeos/display/output_util.h" @@ -41,7 +41,7 @@ RRMode GetOutputNativeMode(const XRROutputInfo* output_info) { } // namespace RealOutputConfiguratorDelegate::RealOutputConfiguratorDelegate() - : display_(base::MessagePumpAuraX11::GetDefaultXDisplay()), + : display_(base::MessagePumpX11::GetDefaultXDisplay()), window_(DefaultRootWindow(display_)), screen_(NULL), is_panel_fitting_enabled_(false) { diff --git a/content/browser/power_save_blocker_x11.cc b/content/browser/power_save_blocker_x11.cc index d955643..624e222 100644 --- a/content/browser/power_save_blocker_x11.cc +++ b/content/browser/power_save_blocker_x11.cc @@ -33,7 +33,7 @@ #if defined(TOOLKIT_GTK) #include "base/message_loop/message_pump_gtk.h" #else -#include "base/message_loop/message_pump_aurax11.h" +#include "base/message_loop/message_pump_x11.h" #endif namespace { diff --git a/ui/aura/bench/bench_main.cc b/ui/aura/bench/bench_main.cc index c6b03eb..912216a 100644 --- a/ui/aura/bench/bench_main.cc +++ b/ui/aura/bench/bench_main.cc @@ -36,7 +36,7 @@ #include "third_party/khronos/GLES2/gl2ext.h" #if defined(USE_X11) -#include "base/message_loop/message_pump_aurax11.h" +#include "base/message_loop/message_pump_x11.h" #endif using base::TimeTicks; diff --git a/ui/aura/demo/demo_main.cc b/ui/aura/demo/demo_main.cc index 9bd8ad0..b2fd97e 100644 --- a/ui/aura/demo/demo_main.cc +++ b/ui/aura/demo/demo_main.cc @@ -24,7 +24,7 @@ #include "ui/gfx/rect.h" #if defined(USE_X11) -#include "base/message_loop/message_pump_aurax11.h" +#include "base/message_loop/message_pump_x11.h" #endif namespace { diff --git a/ui/aura/env.cc b/ui/aura/env.cc index 6b2b3e0..38d3320 100644 --- a/ui/aura/env.cc +++ b/ui/aura/env.cc @@ -12,7 +12,7 @@ #include "ui/compositor/compositor_switches.h" #if defined(USE_X11) -#include "base/message_loop/message_pump_aurax11.h" +#include "base/message_loop/message_pump_x11.h" #endif namespace aura { @@ -30,7 +30,7 @@ Env::Env() Env::~Env() { #if defined(USE_X11) - base::MessagePumpAuraX11::Current()->RemoveObserver( + base::MessagePumpX11::Current()->RemoveObserver( &device_list_updater_aurax11_); #endif @@ -65,7 +65,7 @@ void Env::RemoveObserver(EnvObserver* observer) { #if !defined(OS_MACOSX) base::MessageLoop::Dispatcher* Env::GetDispatcher() { #if defined(USE_X11) - return base::MessagePumpAuraX11::Current(); + return base::MessagePumpX11::Current(); #else return dispatcher_.get(); #endif @@ -87,7 +87,7 @@ void Env::Init() { #if defined(USE_X11) // We can't do this with a root window listener because XI_HierarchyChanged // messages don't have a target window. - base::MessagePumpAuraX11::Current()->AddObserver( + base::MessagePumpX11::Current()->AddObserver( &device_list_updater_aurax11_); #endif ui::Compositor::Initialize(); diff --git a/ui/aura/root_window_host_x11.cc b/ui/aura/root_window_host_x11.cc index d2ca841..56f311b 100644 --- a/ui/aura/root_window_host_x11.cc +++ b/ui/aura/root_window_host_x11.cc @@ -20,7 +20,7 @@ #include "base/command_line.h" #include "base/debug/trace_event.h" #include "base/message_loop/message_loop.h" -#include "base/message_loop/message_pump_aurax11.h" +#include "base/message_loop/message_pump_x11.h" #include "base/stl_util.h" #include "base/strings/string_number_conversions.h" #include "base/strings/string_util.h" @@ -363,7 +363,7 @@ class RootWindowHostX11::MouseMoveFilter { RootWindowHostX11::RootWindowHostX11(const gfx::Rect& bounds) : delegate_(NULL), - xdisplay_(base::MessagePumpAuraX11::GetDefaultXDisplay()), + xdisplay_(base::MessagePumpX11::GetDefaultXDisplay()), xwindow_(0), x_root_window_(DefaultRootWindow(xdisplay_)), current_cursor_(ui::kCursorNull), @@ -388,8 +388,8 @@ RootWindowHostX11::RootWindowHostX11(const gfx::Rect& bounds) CopyFromParent, // visual CWBackPixmap | CWOverrideRedirect, &swa); - base::MessagePumpAuraX11::Current()->AddDispatcherForWindow(this, xwindow_); - base::MessagePumpAuraX11::Current()->AddDispatcherForRootWindow(this); + base::MessagePumpX11::Current()->AddDispatcherForWindow(this, xwindow_); + base::MessagePumpX11::Current()->AddDispatcherForRootWindow(this); long event_mask = ButtonPressMask | ButtonReleaseMask | FocusChangeMask | KeyPressMask | KeyReleaseMask | @@ -440,8 +440,8 @@ RootWindowHostX11::RootWindowHostX11(const gfx::Rect& bounds) RootWindowHostX11::~RootWindowHostX11() { Env::GetInstance()->RemoveObserver(this); - base::MessagePumpAuraX11::Current()->RemoveDispatcherForRootWindow(this); - base::MessagePumpAuraX11::Current()->RemoveDispatcherForWindow(xwindow_); + base::MessagePumpX11::Current()->RemoveDispatcherForRootWindow(this); + base::MessagePumpX11::Current()->RemoveDispatcherForWindow(xwindow_); UnConfineCursor(); @@ -630,7 +630,7 @@ void RootWindowHostX11::Show() { // We now block until our window is mapped. Some X11 APIs will crash and // burn if passed |xwindow_| before the window is mapped, and XMapWindow is // asynchronous. - base::MessagePumpAuraX11::Current()->BlockUntilWindowMapped(xwindow_); + base::MessagePumpX11::Current()->BlockUntilWindowMapped(xwindow_); window_mapped_ = true; } } @@ -854,7 +854,7 @@ void RootWindowHostX11::OnDeviceScaleFactorChanged( } void RootWindowHostX11::PrepareForShutdown() { - base::MessagePumpAuraX11::Current()->RemoveDispatcherForWindow(xwindow_); + base::MessagePumpX11::Current()->RemoveDispatcherForWindow(xwindow_); } void RootWindowHostX11::OnWindowInitialized(Window* window) { @@ -1090,7 +1090,7 @@ RootWindowHost* RootWindowHost::Create(const gfx::Rect& bounds) { // static gfx::Size RootWindowHost::GetNativeScreenSize() { - ::Display* xdisplay = base::MessagePumpAuraX11::GetDefaultXDisplay(); + ::Display* xdisplay = base::MessagePumpX11::GetDefaultXDisplay(); return gfx::Size(DisplayWidth(xdisplay, 0), DisplayHeight(xdisplay, 0)); } diff --git a/ui/aura/test/ui_controls_factory_aurax11.cc b/ui/aura/test/ui_controls_factory_aurax11.cc index 28e1f0f..5dc8577a 100644 --- a/ui/aura/test/ui_controls_factory_aurax11.cc +++ b/ui/aura/test/ui_controls_factory_aurax11.cc @@ -11,7 +11,7 @@ #endif #include "base/logging.h" -#include "base/message_loop/message_pump_aurax11.h" +#include "base/message_loop/message_pump_x11.h" #include "ui/aura/client/screen_position_client.h" #include "ui/aura/env.h" #include "ui/aura/root_window.h" @@ -73,7 +73,7 @@ class EventWaiter : public base::MessageLoopForUI::Observer { // Returns atom that indidates that the XEvent is marker event. Atom MarkerEventAtom() { - return XInternAtom(base::MessagePumpAuraX11::GetDefaultXDisplay(), + return XInternAtom(base::MessagePumpX11::GetDefaultXDisplay(), "marker_event", False); } @@ -117,7 +117,7 @@ class UIControlsX11 : public UIControlsAura { if (alt) SetKeycodeAndSendThenMask(&xevent, XK_Alt_L, Mod1Mask); xevent.xkey.keycode = - XKeysymToKeycode(base::MessagePumpAuraX11::GetDefaultXDisplay(), + XKeysymToKeycode(base::MessagePumpX11::GetDefaultXDisplay(), ui::XKeysymForWindowsKeyCode(key, shift)); root_window_->PostNativeEvent(&xevent); @@ -227,7 +227,7 @@ class UIControlsX11 : public UIControlsAura { KeySym keysym, unsigned int mask) { xevent->xkey.keycode = - XKeysymToKeycode(base::MessagePumpAuraX11::GetDefaultXDisplay(), + XKeysymToKeycode(base::MessagePumpX11::GetDefaultXDisplay(), keysym); root_window_->PostNativeEvent(xevent); xevent->xkey.state |= mask; @@ -238,7 +238,7 @@ class UIControlsX11 : public UIControlsAura { KeySym keysym) { xevent->xkey.state ^= mask; xevent->xkey.keycode = - XKeysymToKeycode(base::MessagePumpAuraX11::GetDefaultXDisplay(), + XKeysymToKeycode(base::MessagePumpX11::GetDefaultXDisplay(), keysym); root_window_->PostNativeEvent(xevent); } diff --git a/ui/base/clipboard/clipboard_aurax11.cc b/ui/base/clipboard/clipboard_aurax11.cc index e32961a..a2ceb99 100644 --- a/ui/base/clipboard/clipboard_aurax11.cc +++ b/ui/base/clipboard/clipboard_aurax11.cc @@ -15,8 +15,8 @@ #include "base/memory/ref_counted_memory.h" #include "base/memory/scoped_ptr.h" #include "base/memory/singleton.h" -#include "base/message_loop/message_pump_aurax11.h" #include "base/message_loop/message_pump_observer.h" +#include "base/message_loop/message_pump_x11.h" #include "base/stl_util.h" #include "base/strings/utf_string_conversions.h" #include "third_party/skia/include/core/SkBitmap.h" @@ -106,7 +106,7 @@ SelectionChangeObserver::SelectionChangeObserver() XFixesSelectionWindowDestroyNotifyMask | XFixesSelectionClientCloseNotifyMask); - base::MessagePumpAuraX11::Current()->AddObserver(this); + base::MessagePumpX11::Current()->AddObserver(this); } } @@ -332,11 +332,11 @@ Clipboard::AuraX11Details::AuraX11Details() XStoreName(x_display_, x_window_, "Chromium clipboard"); XSelectInput(x_display_, x_window_, PropertyChangeMask); - base::MessagePumpAuraX11::Current()->AddDispatcherForWindow(this, x_window_); + base::MessagePumpX11::Current()->AddDispatcherForWindow(this, x_window_); } Clipboard::AuraX11Details::~AuraX11Details() { - base::MessagePumpAuraX11::Current()->RemoveDispatcherForWindow(x_window_); + base::MessagePumpX11::Current()->RemoveDispatcherForWindow(x_window_); XDestroyWindow(x_display_, x_window_); } diff --git a/ui/base/dragdrop/os_exchange_data_provider_aurax11.cc b/ui/base/dragdrop/os_exchange_data_provider_aurax11.cc index 55841c7..214a35a 100644 --- a/ui/base/dragdrop/os_exchange_data_provider_aurax11.cc +++ b/ui/base/dragdrop/os_exchange_data_provider_aurax11.cc @@ -6,7 +6,7 @@ #include "base/logging.h" #include "base/memory/ref_counted_memory.h" -#include "base/message_loop/message_pump_aurax11.h" +#include "base/message_loop/message_pump_x11.h" #include "base/strings/string_util.h" #include "base/strings/utf_string_conversions.h" #include "net/base/net_util.h" @@ -77,12 +77,12 @@ OSExchangeDataProviderAuraX11::OSExchangeDataProviderAuraX11() XStoreName(x_display_, x_window_, "Chromium Drag & Drop Window"); - base::MessagePumpAuraX11::Current()->AddDispatcherForWindow(this, x_window_); + base::MessagePumpX11::Current()->AddDispatcherForWindow(this, x_window_); } OSExchangeDataProviderAuraX11::~OSExchangeDataProviderAuraX11() { if (own_window_) { - base::MessagePumpAuraX11::Current()->RemoveDispatcherForWindow(x_window_); + base::MessagePumpX11::Current()->RemoveDispatcherForWindow(x_window_); XDestroyWindow(x_display_, x_window_); } } diff --git a/ui/base/x/events_x.cc b/ui/base/x/events_x.cc index 22c3f689..a0fa2e9 100644 --- a/ui/base/x/events_x.cc +++ b/ui/base/x/events_x.cc @@ -11,7 +11,7 @@ #include "base/logging.h" #include "base/memory/singleton.h" -#include "base/message_loop/message_pump_aurax11.h" +#include "base/message_loop/message_pump_x11.h" #include "ui/base/events/event_utils.h" #include "ui/base/keycodes/keyboard_code_conversion_x.h" #include "ui/base/touch/touch_factory_x11.h" @@ -261,7 +261,7 @@ double GetTouchParamFromXEvent(XEvent* xev, Atom GetNoopEventAtom() { return XInternAtom( - base::MessagePumpAuraX11::GetDefaultXDisplay(), + base::MessagePumpX11::GetDefaultXDisplay(), "noop", False); } diff --git a/ui/base/x/selection_requestor.cc b/ui/base/x/selection_requestor.cc index 405c059..059ea3f 100644 --- a/ui/base/x/selection_requestor.cc +++ b/ui/base/x/selection_requestor.cc @@ -4,7 +4,7 @@ #include "ui/base/x/selection_requestor.h" -#include "base/message_loop/message_pump_aurax11.h" +#include "base/message_loop/message_pump_x11.h" #include "base/run_loop.h" #include "ui/base/x/selection_utils.h" #include "ui/base/x/x11_util.h" @@ -56,7 +56,7 @@ bool SelectionRequestor::PerformBlockingConvertSelection( // for a response. base::MessageLoopForUI* loop = base::MessageLoopForUI::current(); base::MessageLoop::ScopedNestableTaskAllower allow_nested(loop); - base::RunLoop run_loop(base::MessagePumpAuraX11::Current()); + base::RunLoop run_loop(base::MessagePumpX11::Current()); current_target_ = target; in_nested_loop_ = true; diff --git a/ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc b/ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc index 1870e11..0f4ebae 100644 --- a/ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc +++ b/ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc @@ -236,14 +236,14 @@ DesktopDragDropClientAuraX11::X11DragContext::X11DragContext( if (!client) { // The window doesn't have a DesktopDragDropClientAuraX11, that means it's // created by some other process. Listen for messages on it. - base::MessagePumpAuraX11::Current()->AddDispatcherForWindow( + base::MessagePumpX11::Current()->AddDispatcherForWindow( this, source_window_); - XSelectInput(base::MessagePumpAuraX11::GetDefaultXDisplay(), + XSelectInput(base::MessagePumpX11::GetDefaultXDisplay(), source_window_, PropertyChangeMask); // We must perform a full sync here because we could be racing // |source_window_|. - XSync(base::MessagePumpAuraX11::GetDefaultXDisplay(), False); + XSync(base::MessagePumpX11::GetDefaultXDisplay(), False); } else { // This drag originates from an aura window within our process. This means // that we can shortcut the X11 server and ask the owning SelectionOwner @@ -260,7 +260,7 @@ DesktopDragDropClientAuraX11::X11DragContext::~X11DragContext() { DesktopDragDropClientAuraX11::GetForWindow(source_window_); if (!client) { // Unsubscribe from message events. - base::MessagePumpAuraX11::Current()->RemoveDispatcherForWindow( + base::MessagePumpX11::Current()->RemoveDispatcherForWindow( source_window_); } } @@ -289,7 +289,7 @@ void DesktopDragDropClientAuraX11::X11DragContext::RequestNextTarget() { ::Atom target = unfetched_targets_.back(); unfetched_targets_.pop_back(); - XConvertSelection(base::MessagePumpAuraX11::GetDefaultXDisplay(), + XConvertSelection(base::MessagePumpX11::GetDefaultXDisplay(), atom_cache_->GetAtom(kXdndSelection), target, atom_cache_->GetAtom(kChromiumDragReciever), diff --git a/ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc b/ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc index e398383..e405bf6 100644 --- a/ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc +++ b/ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc @@ -10,7 +10,7 @@ #include <X11/Xregion.h> #include <X11/Xutil.h> -#include "base/message_loop/message_pump_aurax11.h" +#include "base/message_loop/message_pump_x11.h" #include "base/strings/stringprintf.h" #include "base/strings/utf_string_conversions.h" #include "third_party/skia/include/core/SkPath.h" @@ -114,7 +114,7 @@ DesktopRootWindowHostX11::DesktopRootWindowHostX11( DesktopNativeWidgetAura* desktop_native_widget_aura, const gfx::Rect& initial_bounds) : close_widget_factory_(this), - xdisplay_(base::MessagePumpAuraX11::GetDefaultXDisplay()), + xdisplay_(base::MessagePumpX11::GetDefaultXDisplay()), xwindow_(0), x_root_window_(DefaultRootWindow(xdisplay_)), atom_cache_(xdisplay_, kAtomsToCache), @@ -232,7 +232,7 @@ void DesktopRootWindowHostX11::CloseNow() { open_windows().remove(xwindow_); // Actually free our native resources. - base::MessagePumpAuraX11::Current()->RemoveDispatcherForWindow(xwindow_); + base::MessagePumpX11::Current()->RemoveDispatcherForWindow(xwindow_); XDestroyWindow(xdisplay_, xwindow_); xwindow_ = None; @@ -561,7 +561,7 @@ void DesktopRootWindowHostX11::Show() { // We now block until our window is mapped. Some X11 APIs will crash and // burn if passed |xwindow_| before the window is mapped, and XMapWindow is // asynchronous. - base::MessagePumpAuraX11::Current()->BlockUntilWindowMapped(xwindow_); + base::MessagePumpX11::Current()->BlockUntilWindowMapped(xwindow_); window_mapped_ = true; } } @@ -793,7 +793,7 @@ void DesktopRootWindowHostX11::InitX11Window( CopyFromParent, // visual attribute_mask, &swa); - base::MessagePumpAuraX11::Current()->AddDispatcherForWindow(this, xwindow_); + base::MessagePumpX11::Current()->AddDispatcherForWindow(this, xwindow_); // TODO(erg): Maybe need to set a ViewProp here like in RWHL::RWHL(). diff --git a/ui/views/widget/desktop_aura/x11_desktop_handler.cc b/ui/views/widget/desktop_aura/x11_desktop_handler.cc index 4c38fa7..6b2d3b5 100644 --- a/ui/views/widget/desktop_aura/x11_desktop_handler.cc +++ b/ui/views/widget/desktop_aura/x11_desktop_handler.cc @@ -38,11 +38,11 @@ X11DesktopHandler* X11DesktopHandler::get() { } X11DesktopHandler::X11DesktopHandler() - : xdisplay_(base::MessagePumpAuraX11::GetDefaultXDisplay()), + : xdisplay_(base::MessagePumpX11::GetDefaultXDisplay()), x_root_window_(DefaultRootWindow(xdisplay_)), current_window_(None), atom_cache_(xdisplay_, kAtomsToCache) { - base::MessagePumpAuraX11::Current()->AddDispatcherForRootWindow(this); + base::MessagePumpX11::Current()->AddDispatcherForRootWindow(this); aura::Env::GetInstance()->AddObserver(this); XWindowAttributes attr; @@ -54,11 +54,11 @@ X11DesktopHandler::X11DesktopHandler() X11DesktopHandler::~X11DesktopHandler() { aura::Env::GetInstance()->RemoveObserver(this); - base::MessagePumpAuraX11::Current()->RemoveDispatcherForRootWindow(this); + base::MessagePumpX11::Current()->RemoveDispatcherForRootWindow(this); } void X11DesktopHandler::ActivateWindow(::Window window) { - DCHECK_EQ(base::MessagePumpAuraX11::GetDefaultXDisplay(), xdisplay_); + DCHECK_EQ(base::MessagePumpX11::GetDefaultXDisplay(), xdisplay_); XEvent xclient; memset(&xclient, 0, sizeof(xclient)); diff --git a/ui/views/widget/desktop_aura/x11_desktop_window_move_client.cc b/ui/views/widget/desktop_aura/x11_desktop_window_move_client.cc index d28de21..73f2cc2d 100644 --- a/ui/views/widget/desktop_aura/x11_desktop_window_move_client.cc +++ b/ui/views/widget/desktop_aura/x11_desktop_window_move_client.cc @@ -10,7 +10,7 @@ #include "base/debug/stack_trace.h" #include "base/message_loop/message_loop.h" -#include "base/message_loop/message_pump_aurax11.h" +#include "base/message_loop/message_pump_x11.h" #include "base/run_loop.h" #include "ui/aura/env.h" #include "ui/aura/root_window.h" diff --git a/ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc b/ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc index d04dd88..2c26580 100644 --- a/ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc +++ b/ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc @@ -10,7 +10,7 @@ #include "base/debug/stack_trace.h" #include "base/message_loop/message_loop.h" -#include "base/message_loop/message_pump_aurax11.h" +#include "base/message_loop/message_pump_x11.h" #include "base/run_loop.h" #include "ui/aura/env.h" #include "ui/aura/root_window.h" @@ -64,7 +64,7 @@ bool X11WholeScreenMoveLoop::RunMoveLoop(aura::Window* source, DCHECK(!in_move_loop_); // Can only handle one nested loop at a time. in_move_loop_ = true; - Display* display = base::MessagePumpAuraX11::GetDefaultXDisplay(); + Display* display = base::MessagePumpX11::GetDefaultXDisplay(); // Creates an invisible, InputOnly toplevel window. This window will receive // all mouse movement for drags. It turns out that normal windows doing a @@ -83,12 +83,12 @@ bool X11WholeScreenMoveLoop::RunMoveLoop(aura::Window* source, -100, -100, 10, 10, 0, 0, InputOnly, CopyFromParent, attribute_mask, &swa); - base::MessagePumpAuraX11::Current()->AddDispatcherForWindow( + base::MessagePumpX11::Current()->AddDispatcherForWindow( this, grab_input_window_); // Wait for the window to be mapped. If we don't, XGrabPointer fails. XMapRaised(display, grab_input_window_); - base::MessagePumpAuraX11::Current()->BlockUntilWindowMapped( + base::MessagePumpX11::Current()->BlockUntilWindowMapped( grab_input_window_); if (!GrabPointerWithCursor(cursor)) @@ -116,10 +116,10 @@ void X11WholeScreenMoveLoop::EndMoveLoop() { // the chrome process. // Ungrab before we let go of the window. - Display* display = base::MessagePumpAuraX11::GetDefaultXDisplay(); + Display* display = base::MessagePumpX11::GetDefaultXDisplay(); XUngrabPointer(display, CurrentTime); - base::MessagePumpAuraX11::Current()->RemoveDispatcherForWindow( + base::MessagePumpX11::Current()->RemoveDispatcherForWindow( grab_input_window_); delegate_->OnMoveLoopEnded(); XDestroyWindow(display, grab_input_window_); @@ -129,7 +129,7 @@ void X11WholeScreenMoveLoop::EndMoveLoop() { } bool X11WholeScreenMoveLoop::GrabPointerWithCursor(gfx::NativeCursor cursor) { - Display* display = base::MessagePumpAuraX11::GetDefaultXDisplay(); + Display* display = base::MessagePumpX11::GetDefaultXDisplay(); XGrabServer(display); XUngrabPointer(display, CurrentTime); int ret = XGrabPointer( diff --git a/ui/views/widget/desktop_aura/x11_window_event_filter.cc b/ui/views/widget/desktop_aura/x11_window_event_filter.cc index 5d040c9..109bbdd 100644 --- a/ui/views/widget/desktop_aura/x11_window_event_filter.cc +++ b/ui/views/widget/desktop_aura/x11_window_event_filter.cc @@ -9,7 +9,7 @@ #include <X11/Xatom.h> #include <X11/Xlib.h> -#include "base/message_loop/message_pump_aurax11.h" +#include "base/message_loop/message_pump_x11.h" #include "ui/aura/root_window.h" #include "ui/aura/window_delegate.h" #include "ui/base/events/event.h" @@ -59,7 +59,7 @@ namespace views { X11WindowEventFilter::X11WindowEventFilter( aura::RootWindow* root_window) - : xdisplay_(base::MessagePumpAuraX11::GetDefaultXDisplay()), + : xdisplay_(base::MessagePumpX11::GetDefaultXDisplay()), xwindow_(root_window->GetAcceleratedWidget()), x_root_window_(DefaultRootWindow(xdisplay_)), atom_cache_(xdisplay_, kAtomsToCache), @@ -76,7 +76,7 @@ void X11WindowEventFilter::SetUseHostWindowBorders(bool use_os_border) { motif_hints.decorations = use_os_border ? 1 : 0; ::Atom hint_atom = atom_cache_.GetAtom("_MOTIF_WM_HINTS"); - XChangeProperty(base::MessagePumpAuraX11::GetDefaultXDisplay(), + XChangeProperty(base::MessagePumpX11::GetDefaultXDisplay(), xwindow_, hint_atom, hint_atom, |