summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorhbono@chromium.org <hbono@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-07-14 07:03:46 +0000
committerhbono@chromium.org <hbono@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-07-14 07:03:46 +0000
commit955cd1e7208c4b952fa2a74d4667d4612e2f62ca (patch)
tree48f588d309336cec6ffd171ca4da4e320deb27cf
parent8b10fb1d322e67c791026e4e97005b4063a3ddc5 (diff)
downloadchromium_src-955cd1e7208c4b952fa2a74d4667d4612e2f62ca.zip
chromium_src-955cd1e7208c4b952fa2a74d4667d4612e2f62ca.tar.gz
chromium_src-955cd1e7208c4b952fa2a74d4667d4612e2f62ca.tar.bz2
A quick fix for Issue 16597.
Our autofill code handles keyboard events by itself and it prevents dispatch a return key to WebKit when the key is comsumed by the autofill. Unfortunately, this code is enclosed with "#if defined(OS_WIN)" and "#endif". This change just activates this code on Linux. BUG=16597 "Prevents submitting a form when pressing a return key in an auto-fill popup" TEST=Type a return key on an auto-fill popup and verify this is not submitted. Review URL: http://codereview.chromium.org/149517 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20612 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--webkit/glue/webview_impl.cc2
1 files changed, 1 insertions, 1 deletions
diff --git a/webkit/glue/webview_impl.cc b/webkit/glue/webview_impl.cc
index fe9348d..a29836d 100644
--- a/webkit/glue/webview_impl.cc
+++ b/webkit/glue/webview_impl.cc
@@ -669,7 +669,7 @@ bool WebViewImpl::AutocompleteHandleKeyEvent(const WebKeyboardEvent& event) {
return false;
if (autocomplete_popup_->handleKeyEvent(MakePlatformKeyboardEvent(event))) {
-#if defined(OS_WIN)
+#if defined(OS_WIN) || defined(OS_LINUX)
// We need to ignore the next Char event after this otherwise pressing
// enter when selecting an item in the menu will go to the page.
if (WebInputEvent::RawKeyDown == event.type)