diff options
author | rch@chromium.org <rch@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-25 21:21:14 +0000 |
---|---|---|
committer | rch@chromium.org <rch@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-25 21:21:14 +0000 |
commit | 987a2c599af0ee79c767bc8bf214853649726402 (patch) | |
tree | d3dece1cc260e01680955f6d15fc070faae90e49 | |
parent | 6aecc5d4c47ff20cf2653d0b77edfe979c48c439 (diff) | |
download | chromium_src-987a2c599af0ee79c767bc8bf214853649726402.zip chromium_src-987a2c599af0ee79c767bc8bf214853649726402.tar.gz chromium_src-987a2c599af0ee79c767bc8bf214853649726402.tar.bz2 |
Add a new histogram to track the number of total of QUIC streams created when a QUIC session crypto handshake timed out.
Net.QuicSession.ConnectionClose.NumTotalStreams.HandshakeTimedOut
Review URL: https://codereview.chromium.org/44613002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231120 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r-- | net/quic/quic_client_session.cc | 9 | ||||
-rw-r--r-- | tools/metrics/histograms/histograms.xml | 8 |
2 files changed, 16 insertions, 1 deletions
diff --git a/net/quic/quic_client_session.cc b/net/quic/quic_client_session.cc index 4c34b65..dfff3a0 100644 --- a/net/quic/quic_client_session.cc +++ b/net/quic/quic_client_session.cc @@ -351,9 +351,16 @@ void QuicClientSession::ConnectionClose(QuicErrorCode error, bool from_peer) { } if (error == QUIC_CONNECTION_TIMED_OUT) { - UMA_HISTOGRAM_SPARSE_SLOWLY( + UMA_HISTOGRAM_COUNTS( "Net.QuicSession.ConnectionClose.NumOpenStreams.TimedOut", GetNumOpenStreams()); + if (!IsCryptoHandshakeConfirmed()) { + // If there have been any streams created, they were 0-RTT speculative + // requests that have not be serviced. + UMA_HISTOGRAM_COUNTS( + "Net.QuicSession.ConnectionClose.NumTotalStreams.HandshakeTimedOut", + num_total_streams_); + } } UMA_HISTOGRAM_SPARSE_SLOWLY("Net.QuicSession.QuicVersion", diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml index 8b4fcd9..fa58fa1 100644 --- a/tools/metrics/histograms/histograms.xml +++ b/tools/metrics/histograms/histograms.xml @@ -8401,6 +8401,14 @@ other types of suffix sets. <summary>The number of streams open when a QUIC session timed out.</summary> </histogram> +<histogram + name="Net.QuicSession.ConnectionClose.NumTotalStreams.HandshakeTimedOut"> + <summary> + The number of total streams created when a QUIC session crypto handshake + timed out. + </summary> +</histogram> + <histogram name="Net.QuicSession.ConnectionCloseErrorCode" enum="QuicErrorCodes"> <summary> |