diff options
| author | mtomasz@chromium.org <mtomasz@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-11-21 01:02:05 +0000 |
|---|---|---|
| committer | mtomasz@chromium.org <mtomasz@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-11-21 01:02:05 +0000 |
| commit | 33fa0ea01f1dd4b24c49a2e63aab4ab2cc702d79 (patch) | |
| tree | d13af9223a59b152d54bf168899561998ec97cbd | |
| parent | 26c95ed83d2f6b0cb50d5471457733965de1af3b (diff) | |
| download | chromium_src-33fa0ea01f1dd4b24c49a2e63aab4ab2cc702d79.zip chromium_src-33fa0ea01f1dd4b24c49a2e63aab4ab2cc702d79.tar.gz chromium_src-33fa0ea01f1dd4b24c49a2e63aab4ab2cc702d79.tar.bz2 | |
Merge 234993 "Fix tabbing within iframes in the Files app."
> Fix tabbing within iframes in the Files app.
>
> This patch fixes the regression by not having underlying contents while showing a iframe. This problem is gone by adding the missing 'overlay-visible' attribute, what hides underlying contens while an iframe is visible, and therefore locks the tab within the iframe.
>
> TEST=Try to delete an image from the photo viewer. Tab several times within the confirmation dialog.
> BUG=315560
>
> Review URL: https://codereview.chromium.org/69963002
TBR=mtomasz@chromium.org
Review URL: https://codereview.chromium.org/79963002
git-svn-id: svn://svn.chromium.org/chrome/branches/1700/src@236361 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/browser/resources/file_manager/foreground/js/file_manager.js | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/chrome/browser/resources/file_manager/foreground/js/file_manager.js b/chrome/browser/resources/file_manager/foreground/js/file_manager.js index 8048a7f..c3210c7 100644 --- a/chrome/browser/resources/file_manager/foreground/js/file_manager.js +++ b/chrome/browser/resources/file_manager/foreground/js/file_manager.js @@ -1826,6 +1826,7 @@ var BOTTOM_MARGIN_FOR_PREVIEW_PANEL_PX = 52; this.dialogDom_.insertBefore( this.filePopup_, this.dialogDom_.querySelector('#iframe-drag-area')); this.filePopup_.focus(); + this.document_.body.setAttribute('overlay-visible', ''); this.document_.querySelector('#iframe-drag-area').hidden = false; }; |