base: Remove CreateBinaryValue() function as it's redundant.

It does the same thing of BinaryValue::Create(), it's more verbose,
and used only in unittest.

BUG=None
TEST=None

R=evan@chromium.org

Review URL: http://codereview.chromium.org/7623017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96413 0039d316-1c4b-4281-b951-d872f2087c98

3 files changed, 2 insertions, 11 deletions

diff --git a/base/values.cc b/base/values.cc
index 126d7f3..d56cbe5 100644
--- a/base/values.cc
+++ b/base/values.cc
@@ -96,11 +96,6 @@ StringValue* Value::CreateStringValue(const string16& in_value) {
   return new StringValue(in_value);
 }
 
-// static
-BinaryValue* Value::CreateBinaryValue(char* buffer, size_t size) {
-  return BinaryValue::Create(buffer, size);
-}
-
 bool Value::GetAsBoolean(bool* out_value) const {
   return false;
 }
diff --git a/base/values.h b/base/values.h
index bf54bd1..8f427ab 100644
--- a/base/values.h
+++ b/base/values.h
@@ -76,10 +76,6 @@ class BASE_EXPORT Value {
   static StringValue* CreateStringValue(const std::string& in_value);
   static StringValue* CreateStringValue(const string16& in_value);
 
-  // This one can return NULL if the input isn't valid.  If the return value
-  // is non-null, the new object has taken ownership of the buffer pointer.
-  static BinaryValue* CreateBinaryValue(char* buffer, size_t size);
-
   // Returns the type of the value stored by the current Value object.
   // Each type will be implemented by only one subclass of Value, so it's
   // safe to use the ValueType to determine whether you can cast from
diff --git a/base/values_unittest.cc b/base/values_unittest.cc
index 78163fd..b5bcbe1 100644
--- a/base/values_unittest.cc
+++ b/base/values_unittest.cc
@@ -341,7 +341,7 @@ TEST(ValuesTest, DeepCopy) {
 
   char* original_buffer = new char[42];
   memset(original_buffer, '!', 42);
-  BinaryValue* original_binary = Value::CreateBinaryValue(original_buffer, 42);
+  BinaryValue* original_binary = BinaryValue::Create(original_buffer, 42);
   original_dict.Set("binary", original_binary);
 
   ListValue* original_list = new ListValue();
@@ -533,7 +533,7 @@ TEST(ValuesTest, DeepCopyCovariantReturnTypes) {
 
   char* original_buffer = new char[42];
   memset(original_buffer, '!', 42);
-  BinaryValue* original_binary = Value::CreateBinaryValue(original_buffer, 42);
+  BinaryValue* original_binary = BinaryValue::Create(original_buffer, 42);
   original_dict.Set("binary", original_binary);
 
   ListValue* original_list = new ListValue();