summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2008-10-18 00:14:24 +0000
committerananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2008-10-18 00:14:24 +0000
commit5ab78644f9d8237553aab6c0b6b97463ecd67bda (patch)
tree8cec6f078e548c79a5bbb4969bd80f8ca19dd277
parent7321e58f2c6c308e7ff117443acad9a73b5b7592 (diff)
downloadchromium_src-5ab78644f9d8237553aab6c0b6b97463ecd67bda.zip
chromium_src-5ab78644f9d8237553aab6c0b6b97463ecd67bda.tar.gz
chromium_src-5ab78644f9d8237553aab6c0b6b97463ecd67bda.tar.bz2
Re-baselining the geturlnotify-from-npp-destroystream.html as the behavior of this test is correct. The test basically uses the plugin object retreived off the dom after the object has been destroyed. This results in an exception being printed to the console, which is ok. This test used to pass before as our layout test plugin never invoked the destroystream handler on the page. This is changed with Dean's fixes to get the layout test plugin on par
with the one in webkit. R=tony Review URL: http://codereview.chromium.org/7645 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3581 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--webkit/data/layout_test_results/common/LayoutTests/http/tests/plugins/geturlnotify-from-npp-destroystream-expected.txt3
-rw-r--r--webkit/tools/layout_tests/test_lists/tests_fixable.txt5
2 files changed, 3 insertions, 5 deletions
diff --git a/webkit/data/layout_test_results/common/LayoutTests/http/tests/plugins/geturlnotify-from-npp-destroystream-expected.txt b/webkit/data/layout_test_results/common/LayoutTests/http/tests/plugins/geturlnotify-from-npp-destroystream-expected.txt
new file mode 100644
index 0000000..0da5725
--- /dev/null
+++ b/webkit/data/layout_test_results/common/LayoutTests/http/tests/plugins/geturlnotify-from-npp-destroystream-expected.txt
@@ -0,0 +1,3 @@
+CONSOLE MESSAGE: line 5: Uncaught TypeError: Object #<an HTMLEmbedElement> has no method 'getURL'
+This tests that a plug-in that calls NPP_GetURLNotify from its NPP_DestroyStream during teardown will not cause a crash.
+SUCCESS! Did not crash!
diff --git a/webkit/tools/layout_tests/test_lists/tests_fixable.txt b/webkit/tools/layout_tests/test_lists/tests_fixable.txt
index 25a924b..a4ff083 100644
--- a/webkit/tools/layout_tests/test_lists/tests_fixable.txt
+++ b/webkit/tools/layout_tests/test_lists/tests_fixable.txt
@@ -1150,8 +1150,3 @@ V8 | KJS # LayoutTests/fast/dom/gc-1.html = CRASH | PASS
// Post-merge flakey on debug builds (passes consistently on release)
V8 | KJS # LayoutTests/http/tests/navigation/redirect302-subframeload.html = FAIL | PASS
V8 | KJS # LayoutTests/http/tests/navigation/relativeanchor-basic.html = FAIL | PASS
-
-// This one is flakey and might be related.
-V8 # LayoutTests/http/tests/plugins/geturlnotify-from-npp-destroystream.html = FAIL | PASS
-
-