diff options
| author | sgk@google.com <sgk@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-14 05:51:46 +0000 |
|---|---|---|
| committer | sgk@google.com <sgk@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-14 05:51:46 +0000 |
| commit | 64a68f93d28045ef9062c9e225b80b72e1fa5505 (patch) | |
| tree | 5456d605483169aaaadba9b437044a4d7722de03 | |
| parent | 31512d445b77695d2f16ceaf2bfac51cebd19164 (diff) | |
| download | chromium_src-64a68f93d28045ef9062c9e225b80b72e1fa5505.zip chromium_src-64a68f93d28045ef9062c9e225b80b72e1fa5505.tar.gz chromium_src-64a68f93d28045ef9062c9e225b80b72e1fa5505.tar.bz2 | |
Convert chrome.dll to gyp generation.
Remove unnecessary addition of urlmon.lib to AdditionalDepenedencies
of activex_shim.
Add activex_shim as a dependency of default_plugin (so the things
that link against it get urlmon.lib from the link_settings of
activex_shim).
Add urlmon.lib to AdditionalDependencies in unittests.vcproj
(which is going away soon, but this makes the
transition smooth).
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/126073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18359 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/chrome.gyp | 1 | ||||
| -rw-r--r-- | chrome/test/unit/unittests.vcproj | 4 | ||||
| -rw-r--r-- | webkit/activex_shim/activex_shim.gyp | 6 | ||||
| -rw-r--r-- | webkit/default_plugin/default_plugin.gyp | 5 |
4 files changed, 5 insertions, 11 deletions
diff --git a/chrome/chrome.gyp b/chrome/chrome.gyp index a2a8162..95baaec 100644 --- a/chrome/chrome.gyp +++ b/chrome/chrome.gyp @@ -3953,7 +3953,6 @@ 'type': 'shared_library', 'product_name': 'chrome', 'msvs_guid': 'C0A7EE2C-2A6D-45BE-BA78-6D006FDF52D9', - 'msvs_existing_vcproj': 'app/chrome_dll.vcproj', 'include_dirs': [ 'third_party/wtl/include', ], diff --git a/chrome/test/unit/unittests.vcproj b/chrome/test/unit/unittests.vcproj index f0a8040..2e35b33 100644 --- a/chrome/test/unit/unittests.vcproj +++ b/chrome/test/unit/unittests.vcproj @@ -56,7 +56,7 @@ /> <Tool Name="VCLinkerTool" - AdditionalDependencies="winmm.lib" + AdditionalDependencies="urlmon.lib winmm.lib" LinkIncremental="1" /> <Tool @@ -123,7 +123,7 @@ /> <Tool Name="VCLinkerTool" - AdditionalDependencies="winmm.lib" + AdditionalDependencies="urlmon.lib winmm.lib" /> <Tool Name="VCALinkTool" diff --git a/webkit/activex_shim/activex_shim.gyp b/webkit/activex_shim/activex_shim.gyp index 7f08aaf..585be5b 100644 --- a/webkit/activex_shim/activex_shim.gyp +++ b/webkit/activex_shim/activex_shim.gyp @@ -42,12 +42,6 @@ 'web_activex_site.cc', 'web_activex_site.h', ], - # TODO(bradnelson): Add direct support for this kind of thing to gyp. - 'msvs_settings': { - 'VCLibrarianTool': { - 'AdditionalDependencies': 'urlmon.lib', - }, - }, 'link_settings': { 'libraries': [ '-lurlmon.lib', diff --git a/webkit/default_plugin/default_plugin.gyp b/webkit/default_plugin/default_plugin.gyp index dd4ca16..2aeac4e 100644 --- a/webkit/default_plugin/default_plugin.gyp +++ b/webkit/default_plugin/default_plugin.gyp @@ -15,13 +15,14 @@ 'target_name': 'default_plugin', 'type': '<(library)', 'dependencies': [ - '../../third_party/libxml/libxml.gyp:libxml', + '../../net/net.gyp:net_resources', '../../third_party/icu38/icu38.gyp:icui18n', '../../third_party/icu38/icu38.gyp:icuuc', + '../../third_party/libxml/libxml.gyp:libxml', '../../third_party/npapi/npapi.gyp:npapi', + '../activex_shim/activex_shim.gyp:activex_shim', '../webkit.gyp:webkit_resources', '../webkit.gyp:webkit_strings', - '../../net/net.gyp:net_resources', ], 'include_dirs': [ '../..', |