diff options
author | avi@chromium.org <avi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-02-12 19:55:19 +0000 |
---|---|---|
committer | avi@chromium.org <avi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-02-12 19:55:19 +0000 |
commit | 69cdaf7fac503a8ef862b5e50f80f7d3c1b985cc (patch) | |
tree | 9030a07839a44db7a863354419601192ff794f07 | |
parent | e8c7a833772c375257edf5b4710ca801ecfa9a84 (diff) | |
download | chromium_src-69cdaf7fac503a8ef862b5e50f80f7d3c1b985cc.zip chromium_src-69cdaf7fac503a8ef862b5e50f80f7d3c1b985cc.tar.gz chromium_src-69cdaf7fac503a8ef862b5e50f80f7d3c1b985cc.tar.bz2 |
Resizing is good as we do it today; alter the comment and close a bug.
BUG=http://crbug.com/8285
TEST=comment change; no behavior change
Review URL: http://codereview.chromium.org/606026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38922 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r-- | chrome/browser/renderer_host/render_widget_host_view_mac.mm | 15 |
1 files changed, 7 insertions, 8 deletions
diff --git a/chrome/browser/renderer_host/render_widget_host_view_mac.mm b/chrome/browser/renderer_host/render_widget_host_view_mac.mm index ac76e90..babafc4 100644 --- a/chrome/browser/renderer_host/render_widget_host_view_mac.mm +++ b/chrome/browser/renderer_host/render_widget_host_view_mac.mm @@ -188,14 +188,13 @@ void RenderWidgetHostViewMac::SetSize(const gfx::Size& size) { if (is_hidden_) return; - // TODO(avi): the TabContents object uses this method to size the newly - // created widget to the correct size. For that instance, we're not yet in the - // view hierarchy so |size| ends up being 0x0. However, this works for us - // because we're using the Cocoa view struture and resizer flags to fix things - // up as soon as the view gets added to the hierarchy. Figure out if we want - // to keep this flow or switch back to the flow Windows uses which sets the - // size upon creation. <http://crbug.com/8285>. However, if the size is not - // 0x0, this is a valid request. + // During the initial creation of the RenderWidgetHostView in + // TabContents::CreateRenderViewForRenderManager, SetSize is called with an + // empty size. In the Windows code flow, it is not ignored because subsequent + // sizing calls from the OS flow through TCVW::WasSized which calls SetSize() + // again. On Cocoa, we rely on the Cocoa view struture and resizer flags to + // keep things sized properly. On the other hand, if the size is not empty + // then this is a valid request for a pop-up. if (size.IsEmpty()) return; |