summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authoravi@chromium.org <avi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-07-23 14:58:56 +0000
committeravi@chromium.org <avi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-07-23 14:58:56 +0000
commit92e813aaeaea1b496b68b89165d4c2cc3791dad3 (patch)
tree44841798d46378c08fad3182e2d7da0047324152
parent0e2aad680a9b410101108f3604df896dbd0305ac (diff)
downloadchromium_src-92e813aaeaea1b496b68b89165d4c2cc3791dad3.zip
chromium_src-92e813aaeaea1b496b68b89165d4c2cc3791dad3.tar.gz
chromium_src-92e813aaeaea1b496b68b89165d4c2cc3791dad3.tar.bz2
Make sure the multiplication sign is encoded properly.
BUG=http://crbug.com/17454 TEST=as bug Review URL: http://codereview.chromium.org/159209 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21382 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--webkit/api/src/LocalizedStrings.cpp12
1 files changed, 10 insertions, 2 deletions
diff --git a/webkit/api/src/LocalizedStrings.cpp b/webkit/api/src/LocalizedStrings.cpp
index 33faa9b..e5a297a 100644
--- a/webkit/api/src/LocalizedStrings.cpp
+++ b/webkit/api/src/LocalizedStrings.cpp
@@ -34,6 +34,7 @@
#include "IntSize.h"
#include "NotImplemented.h"
#include "PlatformString.h"
+#include "StringBuilder.h"
#include "WebKit.h"
#include "WebKitClient.h"
@@ -190,8 +191,15 @@ String keygenMenuMediumGradeKeySize()
// Used in ImageDocument.cpp as the title for pages when that page is an image.
String imageTitle(const String& filename, const IntSize& size)
{
- // C3 97 is UTF-8 for U+00D7 (multiplication sign).
- return filename + String::format(" (%d\xC3\x97%d)", size.width(), size.height());
+ // Note that we cannot use String::format because it works for ASCII only.
+ StringBuilder result;
+ result.append(filename);
+ result.append(" (");
+ result.append(String::number(size.width()));
+ result.append(static_cast<UChar>(0xD7)); // U+00D7 (multiplication sign)
+ result.append(String::number(size.height()));
+ result.append(")");
+ return result.toString();
}
// We don't use these strings, so they return an empty String. We can't just