summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorskerner@chromium.org <skerner@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-01-15 16:41:01 +0000
committerskerner@chromium.org <skerner@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-01-15 16:41:01 +0000
commitc7df381fcaea795f78863f5c1cc1b335fabcae48 (patch)
tree08bb6ab3eed98103f4674837ba0501c4e9138c0d
parente1bb054cc438a1625ff4f66886d6639a57fb65f0 (diff)
downloadchromium_src-c7df381fcaea795f78863f5c1cc1b335fabcae48.zip
chromium_src-c7df381fcaea795f78863f5c1cc1b335fabcae48.tar.gz
chromium_src-c7df381fcaea795f78863f5c1cc1b335fabcae48.tar.bz2
Nit pick changes to make lint and editors happy. No change in behavior.
Remove ; Avoid variable named 'file'. Return success (however the OS defines it) from main. BUG=NONE TEST=Manually ran. Review URL: http://codereview.chromium.org/551028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36358 0039d316-1c4b-4281-b951-d872f2087c98
-rwxr-xr-xchrome/common/extensions/docs/build/build.py22
1 files changed, 11 insertions, 11 deletions
diff --git a/chrome/common/extensions/docs/build/build.py b/chrome/common/extensions/docs/build/build.py
index 08970c5..6795754 100755
--- a/chrome/common/extensions/docs/build/build.py
+++ b/chrome/common/extensions/docs/build/build.py
@@ -43,13 +43,13 @@ def RenderPage(name, test_shell):
result to .../docs/<name>.html
"""
if not name:
- raise Exception("RenderPage called with empty name");
+ raise Exception("RenderPage called with empty name")
generator_url = "file:" + urllib.pathname2url(_generator_html) + "?" + name
input_file = _base_dir + "/" + name + ".html"
# Copy page_shell to destination output and move aside original, if it exists.
- original = None;
+ original = None
if (os.path.isfile(input_file)):
original = open(input_file, 'rb').read()
os.remove(input_file)
@@ -87,7 +87,7 @@ def RenderPage(name, test_shell):
result = result.replace('\r', '')
# Write output
- open(input_file, 'wb').write(result);
+ open(input_file, 'wb').write(result)
if (original and result == original):
return None
else:
@@ -149,15 +149,15 @@ def GetAPIModuleNames():
def GetStaticFileNames():
static_files = os.listdir(_static_dir)
- return set(os.path.splitext(file)[0]
- for file in static_files
- if file.endswith(".html"))
+ return set(os.path.splitext(file_name)[0]
+ for file_name in static_files
+ if file_name.endswith(".html"))
def main():
# Prevent windows from using cygwin python.
if (sys.platform == "cygwin"):
raise Exception("Building docs not supported for cygwin python.\n"
- "Please run the build.bat script.");
+ "Please run the build.bat script.")
parser = OptionParser()
parser.add_option("--test-shell-path", dest="test_shell_path")
@@ -191,16 +191,16 @@ def main():
"into source control (ideally in the same changelist as the\n" +
"underlying files that resulting in their changing).")
for f in modified_files:
- print f;
+ print f
# Hack. Sleep here, otherwise windows doesn't properly close the debug.log
# and the os.remove will fail with a "Permission denied".
- time.sleep(1);
- debug_log = os.path.normpath(_build_dir + "/" + "debug.log");
+ time.sleep(1)
+ debug_log = os.path.normpath(_build_dir + "/" + "debug.log")
if (os.path.isfile(debug_log)):
os.remove(debug_log)
- return 0;
+ return os.EX_OK
if __name__ == '__main__':
sys.exit(main())