diff options
author | jknotten@chromium.org <jknotten@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-11-30 22:32:49 +0000 |
---|---|---|
committer | jknotten@chromium.org <jknotten@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-11-30 22:32:49 +0000 |
commit | f424a058fb12e8143d59b372e13d32cb14c786cf (patch) | |
tree | d3b1ac11da6303f3a967f0b133f2469598411eb5 | |
parent | 6bb9613a05b4ed5ebeb5f63a37a2dfd862d8b016 (diff) | |
download | chromium_src-f424a058fb12e8143d59b372e13d32cb14c786cf.zip chromium_src-f424a058fb12e8143d59b372e13d32cb14c786cf.tar.gz chromium_src-f424a058fb12e8143d59b372e13d32cb14c786cf.tar.bz2 |
[Android] Remove onUrlStarChanged method from WebContentsDelegateAndroid.
This method is unused in Chromium and downstream, so remove it.
BUG=149477
Review URL: https://chromiumcodereview.appspot.com/11412274
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170578 0039d316-1c4b-4281-b951-d872f2087c98
4 files changed, 0 insertions, 23 deletions
diff --git a/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java b/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java index 02eaa25..8e425a9 100644 --- a/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java +++ b/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java @@ -127,11 +127,6 @@ public abstract class AwContentsClient extends ContentViewClient { } @Override - public void onUrlStarredChanged(boolean starred) { - // TODO: implement - } - - @Override public void showRepostFormWarningDialog(ContentViewCore contentViewCore) { Message dontResend = mHandler.obtainMessage(CANCEL_PENDING_RELOAD, contentViewCore); Message resend = mHandler.obtainMessage(CONTINUE_PENDING_RELOAD, contentViewCore); diff --git a/content/components/web_contents_delegate_android/java/src/org/chromium/content/components/web_contents_delegate_android/WebContentsDelegateAndroid.java b/content/components/web_contents_delegate_android/java/src/org/chromium/content/components/web_contents_delegate_android/WebContentsDelegateAndroid.java index a4614cb..b67f3e5 100644 --- a/content/components/web_contents_delegate_android/java/src/org/chromium/content/components/web_contents_delegate_android/WebContentsDelegateAndroid.java +++ b/content/components/web_contents_delegate_android/java/src/org/chromium/content/components/web_contents_delegate_android/WebContentsDelegateAndroid.java @@ -48,10 +48,6 @@ public class WebContentsDelegateAndroid { } @CalledByNative - public void onUrlStarredChanged(boolean starred) { - } - - @CalledByNative public void onLoadStarted() { } diff --git a/content/components/web_contents_delegate_android/web_contents_delegate_android.cc b/content/components/web_contents_delegate_android/web_contents_delegate_android.cc index f3db704..46fcf16 100644 --- a/content/components/web_contents_delegate_android/web_contents_delegate_android.cc +++ b/content/components/web_contents_delegate_android/web_contents_delegate_android.cc @@ -218,17 +218,6 @@ bool WebContentsDelegateAndroid::AddMessageToConsole( jsource_id.obj()); } -// TODO(merge): WARNING! method no longer available on the base class. -// See http://crbug.com/149477 -void WebContentsDelegateAndroid::URLStarredChanged(WebContents* source, - bool starred) { - JNIEnv* env = AttachCurrentThread(); - ScopedJavaLocalRef<jobject> obj = GetJavaDelegate(env); - if (obj.is_null()) - return; - Java_WebContentsDelegateAndroid_onUrlStarredChanged(env, obj.obj(), starred); -} - // This is either called from TabContents::DidNavigateMainFramePostCommit() with // an empty GURL or responding to RenderViewHost::OnMsgUpateTargetURL(). In // Chrome, the latter is not always called, especially not during history diff --git a/content/components/web_contents_delegate_android/web_contents_delegate_android.h b/content/components/web_contents_delegate_android/web_contents_delegate_android.h index 2702961..74291e3 100644 --- a/content/components/web_contents_delegate_android/web_contents_delegate_android.h +++ b/content/components/web_contents_delegate_android/web_contents_delegate_android.h @@ -79,9 +79,6 @@ class WebContentsDelegateAndroid : public WebContentsDelegate { const string16& message, int32 line_no, const string16& source_id) OVERRIDE; - // TODO(merge): WARNING! method no longer available on the base class. - // See http://crbug.com/149477 - virtual void URLStarredChanged(WebContents* source, bool starred); virtual void UpdateTargetURL(WebContents* source, int32 page_id, const GURL& url) OVERRIDE; |