diff options
| author | dhollowa@chromium.org <dhollowa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-05-14 19:41:01 +0000 |
|---|---|---|
| committer | dhollowa@chromium.org <dhollowa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-05-14 19:41:01 +0000 |
| commit | f980fd87d260c930408cf8094522c379a94997e6 (patch) | |
| tree | f04ebc65e4eea2885dbe58deb422b1c7129592de | |
| parent | ee0e2d945e34a794f5268137f71fc9e7d1cdc82b (diff) | |
| download | chromium_src-f980fd87d260c930408cf8094522c379a94997e6.zip chromium_src-f980fd87d260c930408cf8094522c379a94997e6.tar.gz chromium_src-f980fd87d260c930408cf8094522c379a94997e6.tar.bz2 | |
Compile fix for CL: Form AutoFill Phone number should be displayed as xxx-xxx-xxxx
Modifies the AutoFill label inferencing logic to skip over <img> tags when deriving labels. It is common to use
small images as spacers between elements. Also, extends the phone number heuristics to recognize numbers that are
split into three fields of the form [xxx]-[yyy]-[zzzz] where xxx is the area code, yyy is the phone number prefix and zzz
is the phone number suffix.
Note: This change has a dependency on WebKit change: https://bugs.webkit.org/show_bug.cgi?id=38825.
Will need to wait for that to land before committing this change.
BUG=38218
TEST=FormManagerTest.LabelsInferredWithImageTags:FormStructureTest.ThreePartPhoneNumber:PhoneFieldTest.ThreePartPhoneNumber
Review URL: http://codereview.chromium.org/2107004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47298 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | webkit/glue/webpasswordautocompletelistener_unittest.cc | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/webkit/glue/webpasswordautocompletelistener_unittest.cc b/webkit/glue/webpasswordautocompletelistener_unittest.cc index c2bb758..53acc20 100644 --- a/webkit/glue/webpasswordautocompletelistener_unittest.cc +++ b/webkit/glue/webpasswordautocompletelistener_unittest.cc @@ -107,11 +107,13 @@ class PasswordManagerAutocompleteTests : public testing::Test { data_.basic_data.fields.push_back(FormField(string16(), string16(), username1_, - string16())); + string16(), + 0)); data_.basic_data.fields.push_back(FormField(string16(), string16(), password1_, - string16())); + string16(), + 0)); data_.additional_logins[username2_] = password2_; testing::Test::SetUp(); } |