Fix some review comments I missed in the previous checkin of this file.

Previous review: http://codereview.chromium.org/113909/diff/16/17
Patch my Meelap Shah

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17256 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 11 insertions, 4 deletions

diff --git a/chrome/browser/thumbnail_store.h b/chrome/browser/thumbnail_store.h
index af41c97..bfff59a 100644
--- a/chrome/browser/thumbnail_store.h
+++ b/chrome/browser/thumbnail_store.h
@@ -24,8 +24,8 @@ class ThumbnailStore {
   ~ThumbnailStore();
 
   // Must be called after creation but before other methods are called.
-  // file_path is where a new database should be created or the
-  // location of an existing databse.
+  // file_path is a directory where a new database should be created
+  // or the location of an existing databse.
   // If false is returned, no other methods should be called.
   bool Init(const FilePath& file_path);
 
@@ -39,13 +39,20 @@ class ThumbnailStore {
   // Returns false if there is not data for the given url or some other
   // error occurred.
   bool GetPageThumbnail(const GURL& url,
-                        SkBitmap* thumbnail,
-                        ThumbnailScore* score);
+                        SkBitmap** thumbnail,
+                        ThumbnailScore& score);
 
  private:
   // The location of the thumbnail store.
   FilePath file_path_;
 
+  // Pack the given ThumbnailScore into the given Pickle.
+  void PackScore(const ThumbnailScore& score, Pickle& packed);
+
+  // Unpack a ThumbnailScore from a given Pickle and associated iterator.
+  // Returns false is a ThumbnailScore could not be unpacked.
+  bool UnpackScore(ThumbnailScore* score, const Pickle& packed, void*& iter);
+
   DISALLOW_COPY_AND_ASSIGN(ThumbnailStore);
 };