diff options
| author | oysteine@chromium.org <oysteine@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-11 00:32:29 +0000 |
|---|---|---|
| committer | oysteine@chromium.org <oysteine@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-10-11 00:32:29 +0000 |
| commit | 97ae4c173c7f37ad85c186523f535f4ab8bd8702 (patch) | |
| tree | bf3ea14fb14358fb6d68fff37c2a4464c61e0378 | |
| parent | ca5dfc1a223e00235364a1cf0dfaa4f153a35adf (diff) | |
| download | chromium_src-97ae4c173c7f37ad85c186523f535f4ab8bd8702.zip chromium_src-97ae4c173c7f37ad85c186523f535f4ab8bd8702.tar.gz chromium_src-97ae4c173c7f37ad85c186523f535f4ab8bd8702.tar.bz2 | |
Changed the HighCPU UMA action into a histogram
Originally added in https://codereview.chromium.org/23825004/
R=asvitkine@chromium.org, yoz@chromium.org
BUG=304905
Review URL: https://codereview.chromium.org/26304003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228061 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/browser/performance_monitor/process_metrics_history.cc | 8 | ||||
| -rw-r--r-- | tools/metrics/actions/chromeactions.txt | 1 | ||||
| -rw-r--r-- | tools/metrics/histograms/histograms.xml | 8 |
3 files changed, 11 insertions, 6 deletions
diff --git a/chrome/browser/performance_monitor/process_metrics_history.cc b/chrome/browser/performance_monitor/process_metrics_history.cc index 84ffcac..9ac206fb 100644 --- a/chrome/browser/performance_monitor/process_metrics_history.cc +++ b/chrome/browser/performance_monitor/process_metrics_history.cc @@ -5,6 +5,7 @@ #include <limits> #include "base/logging.h" +#include "base/metrics/histogram.h" #include "base/process/process_metrics.h" #include "chrome/browser/performance_monitor/constants.h" @@ -12,7 +13,6 @@ #if defined(OS_MACOSX) #include "content/public/browser/browser_child_process_host.h" #endif -#include "content/public/browser/user_metrics.h" #include "content/public/common/process_type.h" namespace performance_monitor { @@ -79,10 +79,8 @@ void ProcessMetricsHistory::RunPerformanceTriggers() { // If CPU usage has consistently been above our threshold, // we *may* have an issue. - if (min_cpu_usage_ > kHighCPUUtilizationThreshold) { - content::RecordAction( - content::UserMetricsAction("PerformanceMonitor.HighCPU.Browser")); - } + if (min_cpu_usage_ > kHighCPUUtilizationThreshold) + UMA_HISTOGRAM_BOOLEAN("PerformanceMonitor.HighCPU.BrowserProcess", true); } } // namespace performance_monitor diff --git a/tools/metrics/actions/chromeactions.txt b/tools/metrics/actions/chromeactions.txt index 965d781..e887268 100644 --- a/tools/metrics/actions/chromeactions.txt +++ b/tools/metrics/actions/chromeactions.txt @@ -1440,7 +1440,6 @@ 0xa7613e3a71f2d755 PasswordManager_RemoveSavedPassword 0x36bb6559696dc912 Paste 0x5d0e6942f354a06c PasteAndMatchStyle -0xb0c1b1bb1cef8c89 PerformanceMonitor.HighCPU.Browser 0x01c52e891f36d4fe PlatformVerificationAccepted 0x1929087478be7017 PlatformVerificationRejected 0xca471265efb33961 PluginContextMenu_RotateClockwise diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml index 41ef3f2..d0ed1de 100644 --- a/tools/metrics/histograms/histograms.xml +++ b/tools/metrics/histograms/histograms.xml @@ -11190,6 +11190,14 @@ other types of suffix sets. </summary> </histogram> +<histogram name="PerformanceMonitor.HighCPU.BrowserProcess" enum="BooleanHit"> + <summary> + The number of times a browser process has continuously stayed above a + certain threshold of CPU utilization over a certain time period (currently + set to two minutes). + </summary> +</histogram> + <histogram name="Platform.AsvGroup"> <summary> Chrome OS (ARM Chromebooks using Exynos 5250 only) Adaptive Support Voltage |