Apps: Grant sufficient permissions to the filesystem opened by fileSystem API

A fileSystem opened by chrome.fileSystem API is passable to a pepper plugin[1],
but currently we cannot open any files with CREATE/TRUNCATE flag under the
filesystem in plugin-side because the filesystem doesn't have sufficient file
permissions (CREATE_OVERWRITE_FILE_PERMISSION is missing).

To fix that, this change calls GrantCreateReadWriteFileSystem() for the
filesystem instead of GrantCreateFileForFileSystem().

(NOTE) This change works fine only when choosing a directory by the API, and
the same issue still happens when choosing a file. I'll address the case in
a separate CL.

[1] http://crbug.com/177017


BUG=336160
TEST=manual (open a file with CREATE and/or TRUNCATE flag under the passed filesystem in plugin)

Review URL: https://codereview.chromium.org/146283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247596 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 6 insertions, 4 deletions

diff --git a/chrome/browser/extensions/api/file_handlers/app_file_handler_util.cc b/chrome/browser/extensions/api/file_handlers/app_file_handler_util.cc
index 78eb12a..9d0a5cd 100644
--- a/chrome/browser/extensions/api/file_handlers/app_file_handler_util.cc
+++ b/chrome/browser/extensions/api/file_handlers/app_file_handler_util.cc
@@ -333,10 +333,12 @@ GrantedFileEntry CreateFileEntry(
       content::ChildProcessSecurityPolicy::GetInstance();
   policy->GrantReadFileSystem(renderer_id, result.filesystem_id);
   if (HasFileSystemWritePermission(extension)) {
-    policy->GrantWriteFileSystem(renderer_id, result.filesystem_id);
-    policy->GrantDeleteFromFileSystem(renderer_id, result.filesystem_id);
-    if (is_directory)
-      policy->GrantCreateFileForFileSystem(renderer_id, result.filesystem_id);
+    if (is_directory) {
+      policy->GrantCreateReadWriteFileSystem(renderer_id, result.filesystem_id);
+    } else {
+      policy->GrantWriteFileSystem(renderer_id, result.filesystem_id);
+      policy->GrantDeleteFromFileSystem(renderer_id, result.filesystem_id);
+    }
   }
 
   result.id = result.filesystem_id + ":" + result.registered_name;