summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorgrt@chromium.org <grt@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-04-16 22:13:18 +0000
committergrt@chromium.org <grt@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-04-16 22:13:18 +0000
commitd674f6e23dc4d4e8944df74074e06c1b5c18a7f1 (patch)
tree4a7a3b51317d0f49a15dd7fbb56f7155b7e346ba
parent6cb2087e66fb6c89c8b5decf861a11853d6185d2 (diff)
downloadchromium_src-d674f6e23dc4d4e8944df74074e06c1b5c18a7f1.zip
chromium_src-d674f6e23dc4d4e8944df74074e06c1b5c18a7f1.tar.gz
chromium_src-d674f6e23dc4d4e8944df74074e06c1b5c18a7f1.tar.bz2
Re-enable various ExtensionManagementApiTest tests.
These had been disabled due to flakes on Windows. The Win builders now haves symbols, so the stacks generated by flakes should be actionable. BUG=174411,176023,179430,230165 Review URL: https://codereview.chromium.org/14232006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194464 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--chrome/browser/extensions/api/management/management_apitest.cc20
1 files changed, 3 insertions, 17 deletions
diff --git a/chrome/browser/extensions/api/management/management_apitest.cc b/chrome/browser/extensions/api/management/management_apitest.cc
index 9c30685..f43c9d1 100644
--- a/chrome/browser/extensions/api/management/management_apitest.cc
+++ b/chrome/browser/extensions/api/management/management_apitest.cc
@@ -108,14 +108,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionManagementApiTest, Basics) {
ASSERT_TRUE(RunExtensionSubtest("management/test", "basics.html"));
}
-// Disabled: http://crbug.com/174411
-#if defined(OS_WIN)
-#define MAYBE_Uninstall DISABLED_Uninstall
-#else
-#define MAYBE_Uninstall Uninstall
-#endif
-
-IN_PROC_BROWSER_TEST_F(ExtensionManagementApiTest, MAYBE_Uninstall) {
+IN_PROC_BROWSER_TEST_F(ExtensionManagementApiTest, Uninstall) {
LoadExtensions();
ASSERT_TRUE(RunExtensionSubtest("management/test", "uninstall.html"));
}
@@ -158,8 +151,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionManagementApiTest, ManagementPolicyProhibited) {
"prohibited.html"));
}
-// Disabled. See http://crbug.com/176023
-IN_PROC_BROWSER_TEST_F(ExtensionManagementApiTest, DISABLED_LaunchPanelApp) {
+IN_PROC_BROWSER_TEST_F(ExtensionManagementApiTest, LaunchPanelApp) {
ExtensionService* service = extensions::ExtensionSystem::Get(
browser()->profile())->extension_service();
@@ -218,13 +210,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionManagementApiTest, DISABLED_LaunchPanelApp) {
ASSERT_TRUE(app_browser->is_app());
}
-// Disabled: http://crbug.com/230165
-#if defined(OS_WIN)
-#define MAYBE_LaunchTabApp DISABLED_LaunchTabApp
-#else
-#define MAYBE_LaunchTabApp LaunchTabApp
-#endif
-IN_PROC_BROWSER_TEST_F(ExtensionManagementApiTest, MAYBE_LaunchTabApp) {
+IN_PROC_BROWSER_TEST_F(ExtensionManagementApiTest, LaunchTabApp) {
ExtensionService* service = extensions::ExtensionSystem::Get(
browser()->profile())->extension_service();