summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorbenwells@chromium.org <benwells@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-11-01 13:07:38 +0000
committerbenwells@chromium.org <benwells@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-11-01 13:07:38 +0000
commitd6ec84afaa637fb057ad1cbf5a7c03b02b6a456c (patch)
tree8b0e7c2d2a8ace6fa88a2eca6901564156cea539
parent62f9063b7cb9bc8cc3bc1aa5ebe19a5d216a54cf (diff)
downloadchromium_src-d6ec84afaa637fb057ad1cbf5a7c03b02b6a456c.zip
chromium_src-d6ec84afaa637fb057ad1cbf5a7c03b02b6a456c.tar.gz
chromium_src-d6ec84afaa637fb057ad1cbf5a7c03b02b6a456c.tar.bz2
Moved extension_api to src/extensions/common
This is part of the move of extensions code into the extensions component. This change does not move the generated API data and API resources. TBR=darin@chromium.org BUG=162530 Review URL: https://codereview.chromium.org/50743005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232345 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--chrome/browser/extensions/api/declarative/declarative_api.cc2
-rw-r--r--chrome/browser/extensions/api/storage/settings_storage_quota_enforcer.cc2
-rw-r--r--chrome/browser/extensions/event_router.cc2
-rw-r--r--chrome/browser/extensions/extension_function.cc2
-rw-r--r--chrome/browser/extensions/extension_function_dispatcher.cc4
-rw-r--r--chrome/chrome_common.gypi8
-rw-r--r--chrome/common/extensions/api/extension_api_unittest.cc2
-rw-r--r--chrome/renderer/extensions/chrome_v8_context.cc2
-rw-r--r--chrome/renderer/extensions/chrome_v8_extension.cc2
-rw-r--r--chrome/renderer/extensions/dispatcher.cc2
-rw-r--r--chrome/renderer/extensions/render_view_observer_natives.cc2
-rw-r--r--chrome/renderer/extensions/v8_schema_registry.cc2
-rw-r--r--extensions/common/DEPS14
-rw-r--r--extensions/common/extension_api.cc (renamed from chrome/common/extensions/api/extension_api.cc)4
-rw-r--r--extensions/common/extension_api.h (renamed from chrome/common/extensions/api/extension_api.h)8
-rw-r--r--extensions/common/extension_api_stub.cc (renamed from chrome/common/extensions/api/extension_api_stub.cc)4
-rw-r--r--extensions/extensions.gyp19
17 files changed, 52 insertions, 29 deletions
diff --git a/chrome/browser/extensions/api/declarative/declarative_api.cc b/chrome/browser/extensions/api/declarative/declarative_api.cc
index a77a6bd..f0bd305 100644
--- a/chrome/browser/extensions/api/declarative/declarative_api.cc
+++ b/chrome/browser/extensions/api/declarative/declarative_api.cc
@@ -12,8 +12,8 @@
#include "chrome/browser/extensions/extension_system_factory.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/common/extensions/api/events.h"
-#include "chrome/common/extensions/api/extension_api.h"
#include "content/public/browser/browser_thread.h"
+#include "extensions/common/extension_api.h"
using extensions::api::events::Rule;
diff --git a/chrome/browser/extensions/api/storage/settings_storage_quota_enforcer.cc b/chrome/browser/extensions/api/storage/settings_storage_quota_enforcer.cc
index 6e928ff..6961cb9 100644
--- a/chrome/browser/extensions/api/storage/settings_storage_quota_enforcer.cc
+++ b/chrome/browser/extensions/api/storage/settings_storage_quota_enforcer.cc
@@ -11,7 +11,7 @@
#include "base/metrics/histogram.h"
#include "base/strings/stringprintf.h"
#include "chrome/browser/value_store/value_store_util.h"
-#include "chrome/common/extensions/api/extension_api.h"
+#include "extensions/common/extension_api.h"
namespace util = value_store_util;
diff --git a/chrome/browser/extensions/event_router.cc b/chrome/browser/extensions/event_router.cc
index c1203f6..a89ce72 100644
--- a/chrome/browser/extensions/event_router.cc
+++ b/chrome/browser/extensions/event_router.cc
@@ -28,7 +28,6 @@
#include "chrome/browser/profiles/profile_manager.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/chrome_version_info.h"
-#include "chrome/common/extensions/api/extension_api.h"
#include "chrome/common/extensions/background_info.h"
#include "chrome/common/extensions/extension.h"
#include "chrome/common/extensions/extension_messages.h"
@@ -37,6 +36,7 @@
#include "content/public/browser/notification_service.h"
#include "content/public/browser/render_process_host.h"
#include "extensions/browser/lazy_background_task_queue.h"
+#include "extensions/common/extension_api.h"
#include "extensions/common/extension_urls.h"
using base::DictionaryValue;
diff --git a/chrome/browser/extensions/extension_function.cc b/chrome/browser/extensions/extension_function.cc
index f63d4fd..552490d 100644
--- a/chrome/browser/extensions/extension_function.cc
+++ b/chrome/browser/extensions/extension_function.cc
@@ -9,13 +9,13 @@
#include "chrome/browser/extensions/extension_function_dispatcher.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/renderer_host/chrome_render_message_filter.h"
-#include "chrome/common/extensions/api/extension_api.h"
#include "chrome/common/extensions/extension_messages.h"
#include "content/public/browser/notification_source.h"
#include "content/public/browser/notification_types.h"
#include "content/public/browser/render_view_host.h"
#include "content/public/browser/web_contents.h"
#include "content/public/browser/web_contents_observer.h"
+#include "extensions/common/extension_api.h"
using content::BrowserThread;
using content::RenderViewHost;
diff --git a/chrome/browser/extensions/extension_function_dispatcher.cc b/chrome/browser/extensions/extension_function_dispatcher.cc
index a61348b..9fc3be3 100644
--- a/chrome/browser/extensions/extension_function_dispatcher.cc
+++ b/chrome/browser/extensions/extension_function_dispatcher.cc
@@ -25,17 +25,17 @@
#include "chrome/browser/external_protocol/external_protocol_handler.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/renderer_host/chrome_render_message_filter.h"
-#include "chrome/common/extensions/api/extension_api.h"
#include "chrome/common/extensions/extension_messages.h"
#include "chrome/common/extensions/extension_set.h"
#include "chrome/common/url_constants.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/render_process_host.h"
#include "content/public/browser/render_view_host.h"
+#include "content/public/browser/user_metrics.h"
#include "content/public/browser/web_contents.h"
#include "content/public/browser/web_contents_observer.h"
-#include "content/public/browser/user_metrics.h"
#include "content/public/common/result_codes.h"
+#include "extensions/common/extension_api.h"
#include "ipc/ipc_message.h"
#include "ipc/ipc_message_macros.h"
#include "webkit/common/resource_type.h"
diff --git a/chrome/chrome_common.gypi b/chrome/chrome_common.gypi
index 4a9ecb1..7ee1591 100644
--- a/chrome/chrome_common.gypi
+++ b/chrome/chrome_common.gypi
@@ -127,9 +127,6 @@
'common/extensions/api/extension_action/page_action_handler.h',
'common/extensions/api/extension_action/script_badge_handler.cc',
'common/extensions/api/extension_action/script_badge_handler.h',
- 'common/extensions/api/extension_api.cc',
- 'common/extensions/api/extension_api.h',
- 'common/extensions/api/extension_api_stub.cc',
'common/extensions/api/file_browser_handlers/file_browser_handler.cc',
'common/extensions/api/file_browser_handlers/file_browser_handler.h',
'common/extensions/api/file_handlers/file_handlers_parser.cc',
@@ -414,9 +411,6 @@
],
'conditions': [
['enable_extensions==1', {
- 'sources!': [
- 'common/extensions/api/extension_api_stub.cc',
- ],
'dependencies': [
'../device/bluetooth/bluetooth.gyp:device_bluetooth',
'../device/usb/usb.gyp:device_usb',
@@ -424,7 +418,6 @@
}, { # enable_extensions == 0
'sources/': [
['exclude', '^common/extensions/api/'],
- ['include', 'common/extensions/api/extension_api_stub.cc'],
['include', 'common/extensions/api/extension_action/action_info.cc'],
['include', 'common/extensions/api/extension_action/action_info.h'],
['include', 'common/extensions/api/i18n/default_locale_handler.cc'],
@@ -457,7 +450,6 @@
['OS != "ios"', {
'dependencies': [
'<(DEPTH)/chrome/app/policy/cloud_policy_codegen.gyp:policy',
- '<(DEPTH)/chrome/common/extensions/api/api.gyp:api',
'<(DEPTH)/components/components.gyp:autofill_core_common',
'<(DEPTH)/components/nacl_common.gyp:nacl_common',
'<(DEPTH)/ipc/ipc.gyp:ipc',
diff --git a/chrome/common/extensions/api/extension_api_unittest.cc b/chrome/common/extensions/api/extension_api_unittest.cc
index 0e340ba..a481d9d 100644
--- a/chrome/common/extensions/api/extension_api_unittest.cc
+++ b/chrome/common/extensions/api/extension_api_unittest.cc
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/common/extensions/api/extension_api.h"
+#include "extensions/common/extension_api.h"
#include <string>
#include <vector>
diff --git a/chrome/renderer/extensions/chrome_v8_context.cc b/chrome/renderer/extensions/chrome_v8_context.cc
index 1e0ca6f..64b0658 100644
--- a/chrome/renderer/extensions/chrome_v8_context.cc
+++ b/chrome/renderer/extensions/chrome_v8_context.cc
@@ -8,7 +8,6 @@
#include "base/memory/scoped_ptr.h"
#include "base/strings/string_split.h"
#include "base/values.h"
-#include "chrome/common/extensions/api/extension_api.h"
#include "chrome/common/extensions/extension.h"
#include "chrome/common/extensions/extension_set.h"
#include "chrome/common/extensions/features/base_feature_provider.h"
@@ -17,6 +16,7 @@
#include "chrome/renderer/extensions/user_script_slave.h"
#include "content/public/renderer/render_view.h"
#include "content/public/renderer/v8_value_converter.h"
+#include "extensions/common/extension_api.h"
#include "third_party/WebKit/public/web/WebFrame.h"
#include "third_party/WebKit/public/web/WebScopedMicrotaskSuppression.h"
#include "third_party/WebKit/public/web/WebView.h"
diff --git a/chrome/renderer/extensions/chrome_v8_extension.cc b/chrome/renderer/extensions/chrome_v8_extension.cc
index 27c0b70..c1060e4 100644
--- a/chrome/renderer/extensions/chrome_v8_extension.cc
+++ b/chrome/renderer/extensions/chrome_v8_extension.cc
@@ -8,12 +8,12 @@
#include "base/logging.h"
#include "base/strings/string_util.h"
#include "base/strings/stringprintf.h"
-#include "chrome/common/extensions/api/extension_api.h"
#include "chrome/common/extensions/extension.h"
#include "chrome/common/extensions/extension_set.h"
#include "chrome/renderer/extensions/chrome_v8_context.h"
#include "chrome/renderer/extensions/dispatcher.h"
#include "content/public/renderer/render_view.h"
+#include "extensions/common/extension_api.h"
#include "third_party/WebKit/public/web/WebDocument.h"
#include "third_party/WebKit/public/web/WebFrame.h"
#include "third_party/WebKit/public/web/WebView.h"
diff --git a/chrome/renderer/extensions/dispatcher.cc b/chrome/renderer/extensions/dispatcher.cc
index 21e55cd..55a0bb1 100644
--- a/chrome/renderer/extensions/dispatcher.cc
+++ b/chrome/renderer/extensions/dispatcher.cc
@@ -17,7 +17,6 @@
#include "chrome/common/chrome_switches.h"
#include "chrome/common/chrome_version_info.h"
#include "chrome/common/crash_keys.h"
-#include "chrome/common/extensions/api/extension_api.h"
#include "chrome/common/extensions/api/messaging/message.h"
#include "chrome/common/extensions/background_info.h"
#include "chrome/common/extensions/extension.h"
@@ -76,6 +75,7 @@
#include "content/public/renderer/render_view.h"
#include "content/public/renderer/v8_value_converter.h"
#include "extensions/common/constants.h"
+#include "extensions/common/extension_api.h"
#include "extensions/common/extension_urls.h"
#include "extensions/common/features/feature.h"
#include "extensions/common/features/feature_provider.h"
diff --git a/chrome/renderer/extensions/render_view_observer_natives.cc b/chrome/renderer/extensions/render_view_observer_natives.cc
index adb0e9c..bf5f02e 100644
--- a/chrome/renderer/extensions/render_view_observer_natives.cc
+++ b/chrome/renderer/extensions/render_view_observer_natives.cc
@@ -4,10 +4,10 @@
#include "chrome/renderer/extensions/render_view_observer_natives.h"
-#include "chrome/common/extensions/api/extension_api.h"
#include "chrome/renderer/extensions/dispatcher.h"
#include "content/public/renderer/render_view.h"
#include "content/public/renderer/render_view_observer.h"
+#include "extensions/common/extension_api.h"
#include "third_party/WebKit/public/web/WebFrame.h"
#include "third_party/WebKit/public/web/WebScopedMicrotaskSuppression.h"
diff --git a/chrome/renderer/extensions/v8_schema_registry.cc b/chrome/renderer/extensions/v8_schema_registry.cc
index f5c2c71..e358b98 100644
--- a/chrome/renderer/extensions/v8_schema_registry.cc
+++ b/chrome/renderer/extensions/v8_schema_registry.cc
@@ -9,10 +9,10 @@
#include "base/logging.h"
#include "base/values.h"
-#include "chrome/common/extensions/api/extension_api.h"
#include "chrome/renderer/extensions/chrome_v8_context.h"
#include "chrome/renderer/extensions/object_backed_native_handler.h"
#include "content/public/renderer/v8_value_converter.h"
+#include "extensions/common/extension_api.h"
using content::V8ValueConverter;
diff --git a/extensions/common/DEPS b/extensions/common/DEPS
index 972b087..37ad7de 100644
--- a/extensions/common/DEPS
+++ b/extensions/common/DEPS
@@ -1,3 +1,15 @@
include_rules = [
- "+third_party/re2"
+ "+third_party/re2",
+
+ # Temporarily allowed includes as part of the app shell/extensions refactor.
+ #
+ # NOTE: Please do not add includes without talking to the app shell team;
+ # see OWNERS for this directory.
+ #
+ # TODO(benwells): Remove these. http://crbug.com/162530
+ "+chrome/common/extensions/api/generated_schemas.h",
+ "+chrome/common/extensions/extension.h",
+ "+chrome/common/extensions/permissions/permissions_data.h",
+ "+grit/common_resources.h",
+ "+grit/extensions_api_resources.h"
]
diff --git a/chrome/common/extensions/api/extension_api.cc b/extensions/common/extension_api.cc
index 2490d5d..eda15ac 100644
--- a/chrome/common/extensions/api/extension_api.cc
+++ b/extensions/common/extension_api.cc
@@ -1,8 +1,8 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Copyright 2013 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/common/extensions/api/extension_api.h"
+#include "extensions/common/extension_api.h"
#include <algorithm>
#include <string>
diff --git a/chrome/common/extensions/api/extension_api.h b/extensions/common/extension_api.h
index ad8ae00..31ac97c 100644
--- a/chrome/common/extensions/api/extension_api.h
+++ b/extensions/common/extension_api.h
@@ -1,9 +1,9 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Copyright 2013 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_COMMON_EXTENSIONS_API_EXTENSION_API_H_
-#define CHROME_COMMON_EXTENSIONS_API_EXTENSION_API_H_
+#ifndef EXTENSIONS_COMMON_EXTENSION_API_H_
+#define EXTENSIONS_COMMON_EXTENSION_API_H_
#include <map>
#include <string>
@@ -138,4 +138,4 @@ class ExtensionAPI {
} // namespace extensions
-#endif // CHROME_COMMON_EXTENSIONS_API_EXTENSION_API_H_
+#endif // EXTENSIONS_COMMON_EXTENSION_API_H_
diff --git a/chrome/common/extensions/api/extension_api_stub.cc b/extensions/common/extension_api_stub.cc
index add1f97..e323436 100644
--- a/chrome/common/extensions/api/extension_api_stub.cc
+++ b/extensions/common/extension_api_stub.cc
@@ -1,11 +1,11 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Copyright 2013 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Stub methods to be used when extensions are disabled
// i.e. ENABLE_EXTENSIONS is not defined
-#include "chrome/common/extensions/api/extension_api.h"
+#include "extensions/common/extension_api.h"
#include "extensions/common/features/feature.h"
diff --git a/extensions/extensions.gyp b/extensions/extensions.gyp
index e54d965..f58a442 100644
--- a/extensions/extensions.gyp
+++ b/extensions/extensions.gyp
@@ -11,6 +11,11 @@
'target_name': 'extensions_common',
'type': 'static_library',
'dependencies': [
+ # TODO(benwells): figure out what to do with the api target and
+ # api resources compiled into the chrome resource bundle.
+ # http://crbug.com/162530
+ '../chrome/chrome_resources.gyp:chrome_resources',
+ '../chrome/common/extensions/api/api.gyp:api',
'../content/content.gyp:content_common',
'../third_party/re2/re2.gyp:re2',
],
@@ -31,6 +36,9 @@
'common/event_filtering_info.h',
'common/event_matcher.cc',
'common/event_matcher.h',
+ 'common/extension_api.cc',
+ 'common/extension_api.h',
+ 'common/extension_api_stub.cc',
'common/extension_paths.cc',
'common/extension_paths.h',
'common/extension_resource.cc',
@@ -95,6 +103,17 @@
],
# Disable c4267 warnings until we fix size_t to int truncations.
'msvs_disabled_warnings': [ 4267, ],
+ 'conditions': [
+ ['enable_extensions==1', {
+ 'sources!': [
+ 'common/extension_api_stub.cc',
+ ],
+ }, { # enable_extensions == 0
+ 'sources!': [
+ 'common/extension_api.cc',
+ ],
+ }],
+ ],
},
{
'target_name': 'extensions_browser',