summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorkinaba@chromium.org <kinaba@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-01-30 04:02:14 +0000
committerkinaba@chromium.org <kinaba@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-01-30 04:02:14 +0000
commitf13d7a712f2455a7e9699c12d7ac4d4c604c819f (patch)
tree347785b65f06b3772fb61f1b672fba23afc26f24
parent4896b999a8f9e2f9a54d79696c17ab65180bcda3 (diff)
downloadchromium_src-f13d7a712f2455a7e9699c12d7ac4d4c604c819f.zip
chromium_src-f13d7a712f2455a7e9699c12d7ac4d4c604c819f.tar.gz
chromium_src-f13d7a712f2455a7e9699c12d7ac4d4c604c819f.tar.bz2
Fix UMA recoding code for FileBrowser.ViewingFileType.
In r239446 I carelessly inserted '.ico' to the array but I should have not. The array is for indexing enum of metric stat that need to match with remote side config. Let me just revert the addition. I think we are not so eager to count '.ico''s popularity. BUG=339023 R=hirono@chromium.org Review URL: https://codereview.chromium.org/130803008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247826 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--chrome/browser/resources/file_manager/foreground/js/file_tasks.js18
1 files changed, 9 insertions, 9 deletions
diff --git a/chrome/browser/resources/file_manager/foreground/js/file_tasks.js b/chrome/browser/resources/file_manager/foreground/js/file_tasks.js
index 474e9d9..dff222f 100644
--- a/chrome/browser/resources/file_manager/foreground/js/file_tasks.js
+++ b/chrome/browser/resources/file_manager/foreground/js/file_tasks.js
@@ -133,14 +133,14 @@ FileTasks.prototype.onTasks_ = function(tasks) {
* @type {Array.<string>}
* @private
*/
-FileTasks.knownExtensions_ = [
+FileTasks.UMA_INDEX_KNOWN_EXTENSIONS_ = Object.freeze([
'other', '.3ga', '.3gp', '.aac', '.alac', '.asf', '.avi', '.bmp', '.csv',
- '.doc', '.docx', '.flac', '.gif', '.ico', '.jpeg', '.jpg', '.log', '.m3u',
- '.m3u8', '.m4a', '.m4v', '.mid', '.mkv', '.mov', '.mp3', '.mp4', '.mpg',
- '.odf', '.odp', '.ods', '.odt', '.oga', '.ogg', '.ogv', '.pdf', '.png',
- '.ppt', '.pptx', '.ra', '.ram', '.rar', '.rm', '.rtf', '.wav', '.webm',
- '.webp', '.wma', '.wmv', '.xls', '.xlsx',
-];
+ '.doc', '.docx', '.flac', '.gif', '.jpeg', '.jpg', '.log', '.m3u', '.m3u8',
+ '.m4a', '.m4v', '.mid', '.mkv', '.mov', '.mp3', '.mp4', '.mpg', '.odf',
+ '.odp', '.ods', '.odt', '.oga', '.ogg', '.ogv', '.pdf', '.png', '.ppt',
+ '.pptx', '.ra', '.ram', '.rar', '.rm', '.rtf', '.wav', '.webm', '.webp',
+ '.wma', '.wmv', '.xls', '.xlsx',
+]);
/**
* The list of excutable file extensions.
@@ -172,11 +172,11 @@ FileTasks.recordViewingFileTypeUMA_ = function(entries) {
for (var i = 0; i < entries.length; i++) {
var entry = entries[i];
var extension = FileType.getExtension(entry).toLowerCase();
- if (FileTasks.knownExtensions_.indexOf(extension) < 0) {
+ if (FileTasks.UMA_INDEX_KNOWN_EXTENSIONS_.indexOf(extension) < 0) {
extension = 'other';
}
metrics.recordEnum(
- 'ViewingFileType', extension, FileTasks.knownExtensions_);
+ 'ViewingFileType', extension, FileTasks.UMA_INDEX_KNOWN_EXTENSIONS_);
}
};