summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorrfevang@chromium.org <rfevang@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-02-09 03:03:25 +0000
committerrfevang@chromium.org <rfevang@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-02-09 03:03:25 +0000
commit34b0ef121af4fc678535f72a82c268bf22186503 (patch)
treea793ddde188d9306e69d12bd62da5bee99dc2868
parent2c9f0151c9248b25b4c62bc7ff7bd3534f41769c (diff)
downloadchromium_src-34b0ef121af4fc678535f72a82c268bf22186503.zip
chromium_src-34b0ef121af4fc678535f72a82c268bf22186503.tar.gz
chromium_src-34b0ef121af4fc678535f72a82c268bf22186503.tar.bz2
External component extensions should not have a context menu.
Like for normal component extensions, the context menu items make little sense for an invisible extension the user has no control over. BUG= Review URL: https://codereview.chromium.org/137823015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249971 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--extensions/common/extension.cc3
1 files changed, 2 insertions, 1 deletions
diff --git a/extensions/common/extension.cc b/extensions/common/extension.cc
index a0a545d..813fa66 100644
--- a/extensions/common/extension.cc
+++ b/extensions/common/extension.cc
@@ -306,7 +306,8 @@ bool Extension::ShowConfigureContextMenus() const {
// options for component extension button but now there is no component
// extension with options. All other menu items like uninstall have
// no sense for component extensions.
- return location() != Manifest::COMPONENT;
+ return location() != Manifest::COMPONENT &&
+ location() != Manifest::EXTERNAL_COMPONENT;
}
bool Extension::OverlapsWithOrigin(const GURL& origin) const {