summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authortfarina@chromium.org <tfarina@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-02-09 02:55:43 +0000
committertfarina@chromium.org <tfarina@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-02-09 02:55:43 +0000
commit5651c58492d1ed28ad17c7fd0c62bafd310ef498 (patch)
tree90ba1506378b9a7db0cd06d23bed3deb0495bdde
parenta869776abbe932cc88af0fd42a6583276c356612 (diff)
downloadchromium_src-5651c58492d1ed28ad17c7fd0c62bafd310ef498.zip
chromium_src-5651c58492d1ed28ad17c7fd0c62bafd310ef498.tar.gz
chromium_src-5651c58492d1ed28ad17c7fd0c62bafd310ef498.tar.bz2
Refactor ui cocoa test support into a helper target isolated from ui/base/
That way events can reuse it. This will be necessary to move the remaining events files from ui/base to ui/events. BUG=299841 TEST=None R=sadrul@chromium.org,thakis@chromium.org,ben@chromium.org Review URL: https://codereview.chromium.org/156053005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249966 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--chrome/browser/ui/cocoa/autofill/autofill_account_chooser_unittest.mm2
-rw-r--r--chrome/browser/ui/cocoa/autofill/autofill_details_container_unittest.mm4
-rw-r--r--chrome/browser/ui/cocoa/autofill/autofill_main_container_unittest.mm2
-rw-r--r--chrome/browser/ui/cocoa/autofill/autofill_notification_container_unittest.mm2
-rw-r--r--chrome/browser/ui/cocoa/autofill/autofill_notification_controller_unittest.mm2
-rw-r--r--chrome/browser/ui/cocoa/autofill/autofill_overlay_controller_unittest.mm2
-rw-r--r--chrome/browser/ui/cocoa/autofill/autofill_section_container_unittest.mm2
-rw-r--r--chrome/browser/ui/cocoa/autofill/autofill_section_view_unittest.mm2
-rw-r--r--chrome/browser/ui/cocoa/autofill/autofill_sign_in_container_unittest.mm2
-rw-r--r--chrome/browser/ui/cocoa/autofill/autofill_suggestion_container_unittest.mm2
-rw-r--r--chrome/browser/ui/cocoa/autofill/autofill_tooltip_controller_unittest.mm2
-rw-r--r--chrome/browser/ui/cocoa/autofill/down_arrow_popup_menu_cell_unittest.mm2
-rw-r--r--chrome/browser/ui/cocoa/autofill/layout_view_unittest.mm2
-rw-r--r--chrome/browser/ui/cocoa/cocoa_test_helper.h2
-rw-r--r--chrome/browser/ui/cocoa/notifications/message_center_tray_bridge_unittest.mm2
-rw-r--r--chrome/chrome_tests.gypi1
-rw-r--r--chrome/chrome_tests_unit.gypi1
-rw-r--r--content/browser/accessibility/browser_accessibility_mac_unittest.mm2
-rw-r--r--content/browser/renderer_host/render_widget_host_view_mac_unittest.mm2
-rw-r--r--content/browser/web_contents/web_contents_view_mac_unittest.mm2
-rw-r--r--content/browser/web_contents/web_drag_dest_mac_unittest.mm2
-rw-r--r--content/content_tests.gypi2
-rw-r--r--ui/app_list/app_list.gyp2
-rw-r--r--ui/app_list/cocoa/app_list_window_controller_unittest.mm2
-rw-r--r--ui/app_list/cocoa/apps_search_box_controller_unittest.mm2
-rw-r--r--ui/app_list/cocoa/apps_search_results_controller_unittest.mm2
-rw-r--r--ui/app_list/cocoa/signin_view_controller_unittest.mm2
-rw-r--r--ui/app_list/cocoa/test/apps_grid_controller_test_helper.h2
-rw-r--r--ui/base/cocoa/base_view_unittest.mm2
-rw-r--r--ui/base/cocoa/cocoa_event_utils_unittest.mm2
-rw-r--r--ui/base/cocoa/controls/blue_label_button_unittest.mm2
-rw-r--r--ui/base/cocoa/controls/hover_image_menu_button_unittest.mm2
-rw-r--r--ui/base/cocoa/controls/hyperlink_button_cell_unittest.mm4
-rw-r--r--ui/base/cocoa/focus_tracker_unittest.mm2
-rw-r--r--ui/base/cocoa/fullscreen_window_manager_unittest.mm2
-rw-r--r--ui/base/cocoa/hover_image_button_unittest.mm2
-rw-r--r--ui/base/cocoa/menu_controller_unittest.mm2
-rw-r--r--ui/base/cocoa/nsgraphics_context_additions_unittest.mm2
-rw-r--r--ui/base/cocoa/tracking_area_unittest.mm2
-rw-r--r--ui/events/cocoa/DEPS4
-rw-r--r--ui/events/cocoa/events_mac_unittest.mm2
-rw-r--r--ui/gfx/gfx.gyp27
-rw-r--r--ui/gfx/test/ui_cocoa_test_helper.h (renamed from ui/base/test/ui_cocoa_test_helper.h)8
-rw-r--r--ui/gfx/test/ui_cocoa_test_helper.mm (renamed from ui/base/test/ui_cocoa_test_helper.mm)4
-rw-r--r--ui/message_center/cocoa/notification_controller_unittest.mm2
-rw-r--r--ui/message_center/cocoa/popup_collection_unittest.mm2
-rw-r--r--ui/message_center/cocoa/popup_controller_unittest.mm2
-rw-r--r--ui/message_center/cocoa/settings_controller_unittest.mm2
-rw-r--r--ui/message_center/cocoa/status_item_view_unittest.mm2
-rw-r--r--ui/message_center/cocoa/tray_controller_unittest.mm2
-rw-r--r--ui/message_center/cocoa/tray_view_controller_unittest.mm2
-rw-r--r--ui/message_center/message_center.gyp2
-rw-r--r--ui/ui_unittests.gyp3
53 files changed, 83 insertions, 61 deletions
diff --git a/chrome/browser/ui/cocoa/autofill/autofill_account_chooser_unittest.mm b/chrome/browser/ui/cocoa/autofill/autofill_account_chooser_unittest.mm
index bba39d8..6a443b3 100644
--- a/chrome/browser/ui/cocoa/autofill/autofill_account_chooser_unittest.mm
+++ b/chrome/browser/ui/cocoa/autofill/autofill_account_chooser_unittest.mm
@@ -13,7 +13,7 @@
#include "testing/platform_test.h"
#import "ui/base/cocoa/controls/hyperlink_button_cell.h"
#include "ui/base/models/simple_menu_model.h"
-#import "ui/base/test/ui_cocoa_test_helper.h"
+#import "ui/gfx/test/ui_cocoa_test_helper.h"
namespace {
diff --git a/chrome/browser/ui/cocoa/autofill/autofill_details_container_unittest.mm b/chrome/browser/ui/cocoa/autofill/autofill_details_container_unittest.mm
index 75829ac..579623e 100644
--- a/chrome/browser/ui/cocoa/autofill/autofill_details_container_unittest.mm
+++ b/chrome/browser/ui/cocoa/autofill/autofill_details_container_unittest.mm
@@ -6,11 +6,11 @@
#include "base/mac/scoped_nsobject.h"
#include "base/strings/utf_string_conversions.h"
-#import "chrome/browser/ui/cocoa/autofill/autofill_section_container.h"
#include "chrome/browser/ui/autofill/mock_autofill_dialog_view_delegate.h"
+#import "chrome/browser/ui/cocoa/autofill/autofill_section_container.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "testing/platform_test.h"
-#import "ui/base/test/ui_cocoa_test_helper.h"
+#import "ui/gfx/test/ui_cocoa_test_helper.h"
namespace {
diff --git a/chrome/browser/ui/cocoa/autofill/autofill_main_container_unittest.mm b/chrome/browser/ui/cocoa/autofill/autofill_main_container_unittest.mm
index 0c6159c..8048f95 100644
--- a/chrome/browser/ui/cocoa/autofill/autofill_main_container_unittest.mm
+++ b/chrome/browser/ui/cocoa/autofill/autofill_main_container_unittest.mm
@@ -9,7 +9,7 @@
#import "chrome/browser/ui/cocoa/autofill/autofill_section_view.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "testing/platform_test.h"
-#import "ui/base/test/ui_cocoa_test_helper.h"
+#import "ui/gfx/test/ui_cocoa_test_helper.h"
namespace {
diff --git a/chrome/browser/ui/cocoa/autofill/autofill_notification_container_unittest.mm b/chrome/browser/ui/cocoa/autofill/autofill_notification_container_unittest.mm
index 5d1a29d..b5c62ce 100644
--- a/chrome/browser/ui/cocoa/autofill/autofill_notification_container_unittest.mm
+++ b/chrome/browser/ui/cocoa/autofill/autofill_notification_container_unittest.mm
@@ -9,7 +9,7 @@
#include "chrome/browser/ui/autofill/autofill_dialog_types.h"
#include "chrome/browser/ui/autofill/mock_autofill_dialog_view_delegate.h"
#include "testing/gtest/include/gtest/gtest.h"
-#import "ui/base/test/ui_cocoa_test_helper.h"
+#import "ui/gfx/test/ui_cocoa_test_helper.h"
namespace {
diff --git a/chrome/browser/ui/cocoa/autofill/autofill_notification_controller_unittest.mm b/chrome/browser/ui/cocoa/autofill/autofill_notification_controller_unittest.mm
index dd78f9c..09090a1 100644
--- a/chrome/browser/ui/cocoa/autofill/autofill_notification_controller_unittest.mm
+++ b/chrome/browser/ui/cocoa/autofill/autofill_notification_controller_unittest.mm
@@ -8,7 +8,7 @@
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/ui/autofill/autofill_dialog_types.h"
#include "testing/gtest_mac.h"
-#import "ui/base/test/ui_cocoa_test_helper.h"
+#import "ui/gfx/test/ui_cocoa_test_helper.h"
using base::ASCIIToUTF16;
diff --git a/chrome/browser/ui/cocoa/autofill/autofill_overlay_controller_unittest.mm b/chrome/browser/ui/cocoa/autofill/autofill_overlay_controller_unittest.mm
index f5f72b6..5862172 100644
--- a/chrome/browser/ui/cocoa/autofill/autofill_overlay_controller_unittest.mm
+++ b/chrome/browser/ui/cocoa/autofill/autofill_overlay_controller_unittest.mm
@@ -9,7 +9,7 @@
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "testing/gtest_mac.h"
-#import "ui/base/test/ui_cocoa_test_helper.h"
+#import "ui/gfx/test/ui_cocoa_test_helper.h"
namespace {
diff --git a/chrome/browser/ui/cocoa/autofill/autofill_section_container_unittest.mm b/chrome/browser/ui/cocoa/autofill/autofill_section_container_unittest.mm
index 1ce00c6..47afd51 100644
--- a/chrome/browser/ui/cocoa/autofill/autofill_section_container_unittest.mm
+++ b/chrome/browser/ui/cocoa/autofill/autofill_section_container_unittest.mm
@@ -18,7 +18,7 @@
#include "testing/platform_test.h"
#include "ui/base/models/combobox_model.h"
#include "ui/base/models/simple_menu_model.h"
-#import "ui/base/test/ui_cocoa_test_helper.h"
+#import "ui/gfx/test/ui_cocoa_test_helper.h"
using base::ASCIIToUTF16;
diff --git a/chrome/browser/ui/cocoa/autofill/autofill_section_view_unittest.mm b/chrome/browser/ui/cocoa/autofill/autofill_section_view_unittest.mm
index 4efc79d..10e4271 100644
--- a/chrome/browser/ui/cocoa/autofill/autofill_section_view_unittest.mm
+++ b/chrome/browser/ui/cocoa/autofill/autofill_section_view_unittest.mm
@@ -9,9 +9,9 @@
#include "testing/gtest/include/gtest/gtest.h"
#include "testing/gtest_mac.h"
#include "testing/platform_test.h"
-#import "ui/base/test/ui_cocoa_test_helper.h"
#include "ui/events/test/cocoa_test_event_utils.h"
#include "ui/gfx/scoped_ns_graphics_context_save_gstate_mac.h"
+#import "ui/gfx/test/ui_cocoa_test_helper.h"
namespace {
diff --git a/chrome/browser/ui/cocoa/autofill/autofill_sign_in_container_unittest.mm b/chrome/browser/ui/cocoa/autofill/autofill_sign_in_container_unittest.mm
index 7d3595b..29780df 100644
--- a/chrome/browser/ui/cocoa/autofill/autofill_sign_in_container_unittest.mm
+++ b/chrome/browser/ui/cocoa/autofill/autofill_sign_in_container_unittest.mm
@@ -15,7 +15,7 @@
#include "content/public/browser/web_contents_view.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "testing/platform_test.h"
-#import "ui/base/test/ui_cocoa_test_helper.h"
+#import "ui/gfx/test/ui_cocoa_test_helper.h"
namespace {
diff --git a/chrome/browser/ui/cocoa/autofill/autofill_suggestion_container_unittest.mm b/chrome/browser/ui/cocoa/autofill/autofill_suggestion_container_unittest.mm
index cd3b3e8..3ed1129 100644
--- a/chrome/browser/ui/cocoa/autofill/autofill_suggestion_container_unittest.mm
+++ b/chrome/browser/ui/cocoa/autofill/autofill_suggestion_container_unittest.mm
@@ -6,7 +6,7 @@
#import "chrome/browser/ui/cocoa/autofill/autofill_textfield.h"
#include "testing/gtest/include/gtest/gtest.h"
-#import "ui/base/test/ui_cocoa_test_helper.h"
+#import "ui/gfx/test/ui_cocoa_test_helper.h"
namespace {
diff --git a/chrome/browser/ui/cocoa/autofill/autofill_tooltip_controller_unittest.mm b/chrome/browser/ui/cocoa/autofill/autofill_tooltip_controller_unittest.mm
index ed6ad3f..63d66a1 100644
--- a/chrome/browser/ui/cocoa/autofill/autofill_tooltip_controller_unittest.mm
+++ b/chrome/browser/ui/cocoa/autofill/autofill_tooltip_controller_unittest.mm
@@ -6,7 +6,7 @@
#include "base/mac/scoped_nsobject.h"
#include "testing/gtest/include/gtest/gtest.h"
-#import "ui/base/test/ui_cocoa_test_helper.h"
+#import "ui/gfx/test/ui_cocoa_test_helper.h"
namespace {
diff --git a/chrome/browser/ui/cocoa/autofill/down_arrow_popup_menu_cell_unittest.mm b/chrome/browser/ui/cocoa/autofill/down_arrow_popup_menu_cell_unittest.mm
index 02d3a25..02bb1e3 100644
--- a/chrome/browser/ui/cocoa/autofill/down_arrow_popup_menu_cell_unittest.mm
+++ b/chrome/browser/ui/cocoa/autofill/down_arrow_popup_menu_cell_unittest.mm
@@ -10,7 +10,7 @@
#include "chrome/browser/ui/cocoa/autofill/autofill_dialog_constants.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "testing/platform_test.h"
-#import "ui/base/test/ui_cocoa_test_helper.h"
+#import "ui/gfx/test/ui_cocoa_test_helper.h"
namespace {
diff --git a/chrome/browser/ui/cocoa/autofill/layout_view_unittest.mm b/chrome/browser/ui/cocoa/autofill/layout_view_unittest.mm
index c56c9f8..3c5913a 100644
--- a/chrome/browser/ui/cocoa/autofill/layout_view_unittest.mm
+++ b/chrome/browser/ui/cocoa/autofill/layout_view_unittest.mm
@@ -8,7 +8,7 @@
#include "chrome/browser/ui/cocoa/autofill/simple_grid_layout.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "testing/platform_test.h"
-#import "ui/base/test/ui_cocoa_test_helper.h"
+#import "ui/gfx/test/ui_cocoa_test_helper.h"
namespace {
diff --git a/chrome/browser/ui/cocoa/cocoa_test_helper.h b/chrome/browser/ui/cocoa/cocoa_test_helper.h
index b73c14d..de69e97 100644
--- a/chrome/browser/ui/cocoa/cocoa_test_helper.h
+++ b/chrome/browser/ui/cocoa/cocoa_test_helper.h
@@ -7,7 +7,7 @@
#import <Cocoa/Cocoa.h>
-#import "ui/base/test/ui_cocoa_test_helper.h"
+#import "ui/gfx/test/ui_cocoa_test_helper.h"
// A test class that all tests that depend on AppKit should inherit from.
// Sets up paths correctly, and makes sure that any windows created in the test
diff --git a/chrome/browser/ui/cocoa/notifications/message_center_tray_bridge_unittest.mm b/chrome/browser/ui/cocoa/notifications/message_center_tray_bridge_unittest.mm
index 293f730..0b8a8a1 100644
--- a/chrome/browser/ui/cocoa/notifications/message_center_tray_bridge_unittest.mm
+++ b/chrome/browser/ui/cocoa/notifications/message_center_tray_bridge_unittest.mm
@@ -9,7 +9,7 @@
#include "base/message_loop/message_loop.h"
#include "base/run_loop.h"
#include "base/strings/utf_string_conversions.h"
-#import "ui/base/test/ui_cocoa_test_helper.h"
+#import "ui/gfx/test/ui_cocoa_test_helper.h"
#import "ui/message_center/cocoa/status_item_view.h"
#include "ui/message_center/message_center.h"
#include "ui/message_center/message_center_switches.h"
diff --git a/chrome/chrome_tests.gypi b/chrome/chrome_tests.gypi
index 1200dfe..b64a06a 100644
--- a/chrome/chrome_tests.gypi
+++ b/chrome/chrome_tests.gypi
@@ -141,6 +141,7 @@
'../third_party/npapi/npapi.gyp:npapi',
# Runtime dependencies
'../ppapi/ppapi_internal.gyp:ppapi_tests',
+ '../ui/ui_unittests.gyp:ui_test_support',
'../ui/web_dialogs/web_dialogs.gyp:web_dialogs_test_support',
'../webkit/webkit_resources.gyp:webkit_resources',
],
diff --git a/chrome/chrome_tests_unit.gypi b/chrome/chrome_tests_unit.gypi
index 9f4a5a9..b4b5935 100644
--- a/chrome/chrome_tests_unit.gypi
+++ b/chrome/chrome_tests_unit.gypi
@@ -503,6 +503,7 @@
'../third_party/icu/icu.gyp:icui18n',
'../third_party/icu/icu.gyp:icuuc',
'../third_party/libxml/libxml.gyp:libxml',
+ '../ui/gfx/gfx.gyp:gfx_test_support',
'../ui/resources/ui_resources.gyp:ui_resources',
'../ui/ui_unittests.gyp:ui_test_support',
'chrome_resources.gyp:chrome_resources',
diff --git a/content/browser/accessibility/browser_accessibility_mac_unittest.mm b/content/browser/accessibility/browser_accessibility_mac_unittest.mm
index 843b258..c28ad6a 100644
--- a/content/browser/accessibility/browser_accessibility_mac_unittest.mm
+++ b/content/browser/accessibility/browser_accessibility_mac_unittest.mm
@@ -12,7 +12,7 @@
#include "content/browser/accessibility/browser_accessibility_manager_mac.h"
#include "testing/gtest/include/gtest/gtest.h"
#import "testing/gtest_mac.h"
-#import "ui/base/test/ui_cocoa_test_helper.h"
+#import "ui/gfx/test/ui_cocoa_test_helper.h"
@interface MockAccessibilityDelegate :
NSView<BrowserAccessibilityDelegateCocoa>
diff --git a/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm b/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm
index c31139f..c79970b 100644
--- a/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm
+++ b/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm
@@ -20,8 +20,8 @@
#include "content/test/test_render_view_host.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
-#import "ui/base/test/ui_cocoa_test_helper.h"
#include "ui/events/test/cocoa_test_event_utils.h"
+#import "ui/gfx/test/ui_cocoa_test_helper.h"
// Declare things that are part of the 10.7 SDK.
#if !defined(MAC_OS_X_VERSION_10_7) || \
diff --git a/content/browser/web_contents/web_contents_view_mac_unittest.mm b/content/browser/web_contents/web_contents_view_mac_unittest.mm
index 71f7e48..8c009ea 100644
--- a/content/browser/web_contents/web_contents_view_mac_unittest.mm
+++ b/content/browser/web_contents/web_contents_view_mac_unittest.mm
@@ -7,7 +7,7 @@
#include "base/mac/scoped_nsobject.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "testing/platform_test.h"
-#import "ui/base/test/ui_cocoa_test_helper.h"
+#import "ui/gfx/test/ui_cocoa_test_helper.h"
namespace {
diff --git a/content/browser/web_contents/web_drag_dest_mac_unittest.mm b/content/browser/web_contents/web_drag_dest_mac_unittest.mm
index c6c7ab5..90c565c 100644
--- a/content/browser/web_contents/web_drag_dest_mac_unittest.mm
+++ b/content/browser/web_contents/web_drag_dest_mac_unittest.mm
@@ -13,7 +13,7 @@
#include "testing/gtest/include/gtest/gtest.h"
#import "third_party/mozilla/NSPasteboard+Utils.h"
#import "ui/base/dragdrop/cocoa_dnd_util.h"
-#import "ui/base/test/ui_cocoa_test_helper.h"
+#import "ui/gfx/test/ui_cocoa_test_helper.h"
using content::DropData;
using content::RenderViewHostImplTestHarness;
diff --git a/content/content_tests.gypi b/content/content_tests.gypi
index 250a99d..4e42d3a 100644
--- a/content/content_tests.gypi
+++ b/content/content_tests.gypi
@@ -17,9 +17,9 @@
'../ui/events/events.gyp:events_test_support',
'../ui/gfx/gfx.gyp:gfx',
'../ui/gfx/gfx.gyp:gfx_geometry',
+ '../ui/gfx/gfx.gyp:gfx_test_support',
'../ui/resources/ui_resources.gyp:ui_resources',
'../ui/ui.gyp:ui',
- '../ui/ui_unittests.gyp:ui_test_support',
'../url/url.gyp:url_lib',
'browser/speech/proto/speech_proto.gyp:speech_proto',
'content.gyp:content_app_both',
diff --git a/ui/app_list/app_list.gyp b/ui/app_list/app_list.gyp
index cb6c208..ec61b01 100644
--- a/ui/app_list/app_list.gyp
+++ b/ui/app_list/app_list.gyp
@@ -238,7 +238,7 @@
['OS=="mac"', {
'dependencies': [
'../events/events.gyp:events_test_support',
- '../ui_unittests.gyp:ui_test_support',
+ '../gfx/gfx.gyp:gfx_test_support',
],
'conditions': [
['component=="static_library"', {
diff --git a/ui/app_list/cocoa/app_list_window_controller_unittest.mm b/ui/app_list/cocoa/app_list_window_controller_unittest.mm
index 672363b..9bfc06a 100644
--- a/ui/app_list/cocoa/app_list_window_controller_unittest.mm
+++ b/ui/app_list/cocoa/app_list_window_controller_unittest.mm
@@ -10,7 +10,7 @@
#import "ui/app_list/cocoa/app_list_window_controller.h"
#include "ui/app_list/search_box_model.h"
#include "ui/app_list/test/app_list_test_view_delegate.h"
-#import "ui/base/test/ui_cocoa_test_helper.h"
+#import "ui/gfx/test/ui_cocoa_test_helper.h"
namespace {
diff --git a/ui/app_list/cocoa/apps_search_box_controller_unittest.mm b/ui/app_list/cocoa/apps_search_box_controller_unittest.mm
index 82d4358..60182f9 100644
--- a/ui/app_list/cocoa/apps_search_box_controller_unittest.mm
+++ b/ui/app_list/cocoa/apps_search_box_controller_unittest.mm
@@ -14,7 +14,7 @@
#include "ui/app_list/test/app_list_test_model.h"
#include "ui/app_list/test/app_list_test_view_delegate.h"
#import "ui/base/cocoa/menu_controller.h"
-#import "ui/base/test/ui_cocoa_test_helper.h"
+#import "ui/gfx/test/ui_cocoa_test_helper.h"
using base::ASCIIToUTF16;
diff --git a/ui/app_list/cocoa/apps_search_results_controller_unittest.mm b/ui/app_list/cocoa/apps_search_results_controller_unittest.mm
index 72253c0..0b3ae52 100644
--- a/ui/app_list/cocoa/apps_search_results_controller_unittest.mm
+++ b/ui/app_list/cocoa/apps_search_results_controller_unittest.mm
@@ -13,9 +13,9 @@
#include "ui/app_list/search_result.h"
#include "ui/app_list/test/app_list_test_model.h"
#include "ui/base/models/simple_menu_model.h"
-#import "ui/base/test/ui_cocoa_test_helper.h"
#import "ui/events/test/cocoa_test_event_utils.h"
#include "ui/gfx/image/image_skia_util_mac.h"
+#import "ui/gfx/test/ui_cocoa_test_helper.h"
@interface TestAppsSearchResultsDelegate : NSObject<AppsSearchResultsDelegate> {
@private
diff --git a/ui/app_list/cocoa/signin_view_controller_unittest.mm b/ui/app_list/cocoa/signin_view_controller_unittest.mm
index f230ceb..cc62a80 100644
--- a/ui/app_list/cocoa/signin_view_controller_unittest.mm
+++ b/ui/app_list/cocoa/signin_view_controller_unittest.mm
@@ -10,7 +10,7 @@
#import "testing/gtest_mac.h"
#include "ui/app_list/signin_delegate.h"
#include "ui/app_list/test/app_list_test_view_delegate.h"
-#import "ui/base/test/ui_cocoa_test_helper.h"
+#import "ui/gfx/test/ui_cocoa_test_helper.h"
@class TestSigninViewDelegate;
diff --git a/ui/app_list/cocoa/test/apps_grid_controller_test_helper.h b/ui/app_list/cocoa/test/apps_grid_controller_test_helper.h
index aefeb69..af39f56 100644
--- a/ui/app_list/cocoa/test/apps_grid_controller_test_helper.h
+++ b/ui/app_list/cocoa/test/apps_grid_controller_test_helper.h
@@ -9,7 +9,7 @@
#include "base/memory/scoped_ptr.h"
#include "base/message_loop/message_loop.h"
-#import "ui/base/test/ui_cocoa_test_helper.h"
+#import "ui/gfx/test/ui_cocoa_test_helper.h"
@class AppsGridController;
diff --git a/ui/base/cocoa/base_view_unittest.mm b/ui/base/cocoa/base_view_unittest.mm
index f9b0690..ceb1c65 100644
--- a/ui/base/cocoa/base_view_unittest.mm
+++ b/ui/base/cocoa/base_view_unittest.mm
@@ -8,7 +8,7 @@
#include "testing/gtest/include/gtest/gtest.h"
#include "testing/platform_test.h"
#include "ui/base/cocoa/base_view.h"
-#import "ui/base/test/ui_cocoa_test_helper.h"
+#import "ui/gfx/test/ui_cocoa_test_helper.h"
namespace {
diff --git a/ui/base/cocoa/cocoa_event_utils_unittest.mm b/ui/base/cocoa/cocoa_event_utils_unittest.mm
index ffb6237..f0c8afa 100644
--- a/ui/base/cocoa/cocoa_event_utils_unittest.mm
+++ b/ui/base/cocoa/cocoa_event_utils_unittest.mm
@@ -7,9 +7,9 @@
#include "testing/gtest/include/gtest/gtest.h"
#include "testing/platform_test.h"
#include "ui/base/cocoa/cocoa_event_utils.h"
-#import "ui/base/test/ui_cocoa_test_helper.h"
#include "ui/events/event_constants.h"
#import "ui/events/test/cocoa_test_event_utils.h"
+#import "ui/gfx/test/ui_cocoa_test_helper.h"
// We provide a donor class with a specially modified |modifierFlags|
// implementation that we swap with NSEvent's. This is because we can't create a
diff --git a/ui/base/cocoa/controls/blue_label_button_unittest.mm b/ui/base/cocoa/controls/blue_label_button_unittest.mm
index 48342e8..1e2a8f8 100644
--- a/ui/base/cocoa/controls/blue_label_button_unittest.mm
+++ b/ui/base/cocoa/controls/blue_label_button_unittest.mm
@@ -6,7 +6,7 @@
#include "base/mac/scoped_nsobject.h"
#import "testing/gtest_mac.h"
-#import "ui/base/test/ui_cocoa_test_helper.h"
+#import "ui/gfx/test/ui_cocoa_test_helper.h"
namespace ui {
namespace test {
diff --git a/ui/base/cocoa/controls/hover_image_menu_button_unittest.mm b/ui/base/cocoa/controls/hover_image_menu_button_unittest.mm
index bf64f40..ad5b2da 100644
--- a/ui/base/cocoa/controls/hover_image_menu_button_unittest.mm
+++ b/ui/base/cocoa/controls/hover_image_menu_button_unittest.mm
@@ -7,7 +7,7 @@
#include "base/mac/foundation_util.h"
#import "testing/gtest_mac.h"
#import "ui/base/cocoa/controls/hover_image_menu_button_cell.h"
-#import "ui/base/test/ui_cocoa_test_helper.h"
+#import "ui/gfx/test/ui_cocoa_test_helper.h"
namespace ui {
diff --git a/ui/base/cocoa/controls/hyperlink_button_cell_unittest.mm b/ui/base/cocoa/controls/hyperlink_button_cell_unittest.mm
index 3d24f01..3e7c611 100644
--- a/ui/base/cocoa/controls/hyperlink_button_cell_unittest.mm
+++ b/ui/base/cocoa/controls/hyperlink_button_cell_unittest.mm
@@ -8,10 +8,10 @@
#include "base/mac/foundation_util.h"
#include "base/mac/scoped_nsobject.h"
-#import "testing/gtest_mac.h"
#include "testing/gtest/include/gtest/gtest.h"
+#import "testing/gtest_mac.h"
#include "testing/platform_test.h"
-#import "ui/base/test/ui_cocoa_test_helper.h"
+#import "ui/gfx/test/ui_cocoa_test_helper.h"
namespace ui {
diff --git a/ui/base/cocoa/focus_tracker_unittest.mm b/ui/base/cocoa/focus_tracker_unittest.mm
index 0fb70c1..4e15f26 100644
--- a/ui/base/cocoa/focus_tracker_unittest.mm
+++ b/ui/base/cocoa/focus_tracker_unittest.mm
@@ -8,7 +8,7 @@
#include "testing/gtest/include/gtest/gtest.h"
#include "testing/platform_test.h"
#import "ui/base/cocoa/focus_tracker.h"
-#import "ui/base/test/ui_cocoa_test_helper.h"
+#import "ui/gfx/test/ui_cocoa_test_helper.h"
namespace {
diff --git a/ui/base/cocoa/fullscreen_window_manager_unittest.mm b/ui/base/cocoa/fullscreen_window_manager_unittest.mm
index 5f9ff2f..c720a26 100644
--- a/ui/base/cocoa/fullscreen_window_manager_unittest.mm
+++ b/ui/base/cocoa/fullscreen_window_manager_unittest.mm
@@ -6,7 +6,7 @@
#include "testing/gtest/include/gtest/gtest.h"
#include "testing/platform_test.h"
-#import "ui/base/test/ui_cocoa_test_helper.h"
+#import "ui/gfx/test/ui_cocoa_test_helper.h"
typedef ui::CocoaTest FullscreenWindowManagerTest;
diff --git a/ui/base/cocoa/hover_image_button_unittest.mm b/ui/base/cocoa/hover_image_button_unittest.mm
index cc1cca0..0dff3fc 100644
--- a/ui/base/cocoa/hover_image_button_unittest.mm
+++ b/ui/base/cocoa/hover_image_button_unittest.mm
@@ -5,7 +5,7 @@
#import "ui/base/cocoa/hover_image_button.h"
#import "base/mac/scoped_nsobject.h"
-#import "ui/base/test/ui_cocoa_test_helper.h"
+#import "ui/gfx/test/ui_cocoa_test_helper.h"
namespace {
diff --git a/ui/base/cocoa/menu_controller_unittest.mm b/ui/base/cocoa/menu_controller_unittest.mm
index 119685d..43520dd 100644
--- a/ui/base/cocoa/menu_controller_unittest.mm
+++ b/ui/base/cocoa/menu_controller_unittest.mm
@@ -13,8 +13,8 @@
#import "ui/base/cocoa/menu_controller.h"
#include "ui/base/models/simple_menu_model.h"
#include "ui/base/resource/resource_bundle.h"
-#import "ui/base/test/ui_cocoa_test_helper.h"
#include "ui/gfx/image/image.h"
+#import "ui/gfx/test/ui_cocoa_test_helper.h"
using base::ASCIIToUTF16;
diff --git a/ui/base/cocoa/nsgraphics_context_additions_unittest.mm b/ui/base/cocoa/nsgraphics_context_additions_unittest.mm
index d4e958e..bfa1761 100644
--- a/ui/base/cocoa/nsgraphics_context_additions_unittest.mm
+++ b/ui/base/cocoa/nsgraphics_context_additions_unittest.mm
@@ -5,7 +5,7 @@
#import "ui/base/cocoa/nsgraphics_context_additions.h"
#include "base/mac/scoped_nsobject.h"
-#import "ui/base/test/ui_cocoa_test_helper.h"
+#import "ui/gfx/test/ui_cocoa_test_helper.h"
typedef ui::CocoaTest NSGraphicsContextCrAdditionsTest;
diff --git a/ui/base/cocoa/tracking_area_unittest.mm b/ui/base/cocoa/tracking_area_unittest.mm
index b12c9d4..cb2c829 100644
--- a/ui/base/cocoa/tracking_area_unittest.mm
+++ b/ui/base/cocoa/tracking_area_unittest.mm
@@ -4,7 +4,7 @@
#include "base/mac/scoped_nsobject.h"
#import "ui/base/cocoa/tracking_area.h"
-#import "ui/base/test/ui_cocoa_test_helper.h"
+#import "ui/gfx/test/ui_cocoa_test_helper.h"
// A test object that counts the number of times a message is sent to it.
@interface TestTrackingAreaOwner : NSObject {
diff --git a/ui/events/cocoa/DEPS b/ui/events/cocoa/DEPS
deleted file mode 100644
index 6725419..0000000
--- a/ui/events/cocoa/DEPS
+++ /dev/null
@@ -1,4 +0,0 @@
-include_rules = [
- "+ui/base/test/ui_cocoa_test_helper.h",
-]
-
diff --git a/ui/events/cocoa/events_mac_unittest.mm b/ui/events/cocoa/events_mac_unittest.mm
index a6f3695..1ab73b4 100644
--- a/ui/events/cocoa/events_mac_unittest.mm
+++ b/ui/events/cocoa/events_mac_unittest.mm
@@ -5,11 +5,11 @@
#import <Cocoa/Cocoa.h>
#include "testing/gtest/include/gtest/gtest.h"
-#import "ui/base/test/ui_cocoa_test_helper.h"
#include "ui/events/event_constants.h"
#include "ui/events/event_utils.h"
#include "ui/events/test/cocoa_test_event_utils.h"
#include "ui/gfx/point.h"
+#import "ui/gfx/test/ui_cocoa_test_helper.h"
using namespace cocoa_test_event_utils;
diff --git a/ui/gfx/gfx.gyp b/ui/gfx/gfx.gyp
index 911729c..b5295a9 100644
--- a/ui/gfx/gfx.gyp
+++ b/ui/gfx/gfx.gyp
@@ -467,15 +467,40 @@
},
{
'target_name': 'gfx_test_support',
- 'type': 'static_library',
'sources': [
'test/gfx_util.cc',
'test/gfx_util.h',
+ 'test/ui_cocoa_test_helper.h',
+ 'test/ui_cocoa_test_helper.mm',
],
'dependencies': [
+ '../../base/base.gyp:base',
'../../skia/skia.gyp:skia',
'../../testing/gtest.gyp:gtest',
],
+ 'conditions': [
+ ['OS == "mac"', {
+ 'link_settings': {
+ 'libraries': [
+ '$(SDKROOT)/System/Library/Frameworks/AppKit.framework',
+ ],
+ },
+ }],
+ ['OS!="ios"', {
+ 'type': 'static_library',
+ }, { # OS=="ios"
+ # None of the sources in this target are built on iOS, resulting in
+ # link errors when building targets that depend on this target
+ # because the static library isn't found. If this target is changed
+ # to have sources that are built on iOS, the target should be changed
+ # to be of type static_library on all platforms.
+ 'type': 'none',
+ # The cocoa files don't apply to iOS.
+ 'sources/': [
+ ['exclude', 'cocoa']
+ ],
+ }],
+ ],
},
{
'target_name': 'gfx_unittests',
diff --git a/ui/base/test/ui_cocoa_test_helper.h b/ui/gfx/test/ui_cocoa_test_helper.h
index 79e37e2..c75c7bd 100644
--- a/ui/base/test/ui_cocoa_test_helper.h
+++ b/ui/gfx/test/ui_cocoa_test_helper.h
@@ -1,9 +1,9 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright 2014 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef UI_BASE_TEST_UI_COCOA_TEST_HELPER_H_
-#define UI_BASE_TEST_UI_COCOA_TEST_HELPER_H_
+#ifndef UI_GFX_TEST_UI_COCOA_TEST_HELPER_H_
+#define UI_GFX_TEST_UI_COCOA_TEST_HELPER_H_
#include <set>
@@ -146,4 +146,4 @@ class CocoaTest : public PlatformTest {
[NSStringFromRect(expected) UTF8String] << \
" != " << [NSStringFromRect(actual) UTF8String]
-#endif // UI_BASE_TEST_UI_COCOA_TEST_HELPER_H_
+#endif // UI_GFX_TEST_UI_COCOA_TEST_HELPER_H_
diff --git a/ui/base/test/ui_cocoa_test_helper.mm b/ui/gfx/test/ui_cocoa_test_helper.mm
index a33228f..bae4af8 100644
--- a/ui/base/test/ui_cocoa_test_helper.mm
+++ b/ui/gfx/test/ui_cocoa_test_helper.mm
@@ -1,8 +1,8 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Copyright 2014 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#import "ui/base/test/ui_cocoa_test_helper.h"
+#import "ui/gfx/test/ui_cocoa_test_helper.h"
#include "base/debug/debugger.h"
#include "base/logging.h"
diff --git a/ui/message_center/cocoa/notification_controller_unittest.mm b/ui/message_center/cocoa/notification_controller_unittest.mm
index e01745a..fefee79 100644
--- a/ui/message_center/cocoa/notification_controller_unittest.mm
+++ b/ui/message_center/cocoa/notification_controller_unittest.mm
@@ -10,7 +10,7 @@
#include "base/strings/sys_string_conversions.h"
#include "base/strings/utf_string_conversions.h"
#import "ui/base/cocoa/hover_image_button.h"
-#import "ui/base/test/ui_cocoa_test_helper.h"
+#import "ui/gfx/test/ui_cocoa_test_helper.h"
#include "ui/message_center/fake_message_center.h"
#include "ui/message_center/message_center_style.h"
#include "ui/message_center/notification.h"
diff --git a/ui/message_center/cocoa/popup_collection_unittest.mm b/ui/message_center/cocoa/popup_collection_unittest.mm
index 63498a2..925cbd3 100644
--- a/ui/message_center/cocoa/popup_collection_unittest.mm
+++ b/ui/message_center/cocoa/popup_collection_unittest.mm
@@ -10,7 +10,7 @@
#include "base/run_loop.h"
#include "base/strings/sys_string_conversions.h"
#include "base/strings/utf_string_conversions.h"
-#import "ui/base/test/ui_cocoa_test_helper.h"
+#import "ui/gfx/test/ui_cocoa_test_helper.h"
#import "ui/message_center/cocoa/notification_controller.h"
#import "ui/message_center/cocoa/popup_controller.h"
#include "ui/message_center/message_center.h"
diff --git a/ui/message_center/cocoa/popup_controller_unittest.mm b/ui/message_center/cocoa/popup_controller_unittest.mm
index 80d9768..73e142b 100644
--- a/ui/message_center/cocoa/popup_controller_unittest.mm
+++ b/ui/message_center/cocoa/popup_controller_unittest.mm
@@ -8,7 +8,7 @@
#include "base/memory/scoped_ptr.h"
#include "base/strings/sys_string_conversions.h"
#include "base/strings/utf_string_conversions.h"
-#import "ui/base/test/ui_cocoa_test_helper.h"
+#import "ui/gfx/test/ui_cocoa_test_helper.h"
#include "ui/message_center/notification.h"
using base::ASCIIToUTF16;
diff --git a/ui/message_center/cocoa/settings_controller_unittest.mm b/ui/message_center/cocoa/settings_controller_unittest.mm
index 74f9f07..c686fcf 100644
--- a/ui/message_center/cocoa/settings_controller_unittest.mm
+++ b/ui/message_center/cocoa/settings_controller_unittest.mm
@@ -5,7 +5,7 @@
#import "ui/message_center/cocoa/settings_controller.h"
#include "base/strings/utf_string_conversions.h"
-#import "ui/base/test/ui_cocoa_test_helper.h"
+#import "ui/gfx/test/ui_cocoa_test_helper.h"
#include "ui/message_center/fake_notifier_settings_provider.h"
@implementation MCSettingsController (TestingInterface)
diff --git a/ui/message_center/cocoa/status_item_view_unittest.mm b/ui/message_center/cocoa/status_item_view_unittest.mm
index 424d20f..f673a11 100644
--- a/ui/message_center/cocoa/status_item_view_unittest.mm
+++ b/ui/message_center/cocoa/status_item_view_unittest.mm
@@ -5,7 +5,7 @@
#import "ui/message_center/cocoa/status_item_view.h"
#include "base/mac/scoped_nsobject.h"
-#import "ui/base/test/ui_cocoa_test_helper.h"
+#import "ui/gfx/test/ui_cocoa_test_helper.h"
class StatusItemViewTest : public ui::CocoaTest {
public:
diff --git a/ui/message_center/cocoa/tray_controller_unittest.mm b/ui/message_center/cocoa/tray_controller_unittest.mm
index 516cf8f..285e8b6 100644
--- a/ui/message_center/cocoa/tray_controller_unittest.mm
+++ b/ui/message_center/cocoa/tray_controller_unittest.mm
@@ -6,7 +6,7 @@
#include "base/mac/scoped_nsobject.h"
#include "base/memory/scoped_ptr.h"
-#import "ui/base/test/ui_cocoa_test_helper.h"
+#import "ui/gfx/test/ui_cocoa_test_helper.h"
#include "ui/message_center/message_center.h"
#include "ui/message_center/message_center_tray.h"
diff --git a/ui/message_center/cocoa/tray_view_controller_unittest.mm b/ui/message_center/cocoa/tray_view_controller_unittest.mm
index 9fdb4fb..156f719 100644
--- a/ui/message_center/cocoa/tray_view_controller_unittest.mm
+++ b/ui/message_center/cocoa/tray_view_controller_unittest.mm
@@ -8,7 +8,7 @@
#include "base/message_loop/message_loop.h"
#include "base/run_loop.h"
#include "base/strings/utf_string_conversions.h"
-#import "ui/base/test/ui_cocoa_test_helper.h"
+#import "ui/gfx/test/ui_cocoa_test_helper.h"
#include "ui/message_center/fake_notifier_settings_provider.h"
#include "ui/message_center/message_center.h"
#include "ui/message_center/message_center_impl.h"
diff --git a/ui/message_center/message_center.gyp b/ui/message_center/message_center.gyp
index 149d8a3..555ec05 100644
--- a/ui/message_center/message_center.gyp
+++ b/ui/message_center/message_center.gyp
@@ -206,7 +206,7 @@
}],
['OS=="mac"', {
'dependencies': [
- '../ui_unittests.gyp:ui_test_support',
+ '../gfx/gfx.gyp:gfx_test_support',
],
}],
['toolkit_views==1', {
diff --git a/ui/ui_unittests.gyp b/ui/ui_unittests.gyp
index d786aac..e2b7118 100644
--- a/ui/ui_unittests.gyp
+++ b/ui/ui_unittests.gyp
@@ -17,8 +17,6 @@
'gfx/gfx.gyp:gfx_geometry',
],
'sources': [
- 'base/test/ui_cocoa_test_helper.h',
- 'base/test/ui_cocoa_test_helper.mm',
'base/test/ui_controls.h',
'base/test/ui_controls_aura.cc',
'base/test/ui_controls_gtk.cc',
@@ -286,6 +284,7 @@
['OS=="mac"', {
'dependencies': [
'events/events.gyp:events_test_support',
+ 'gfx/gfx.gyp:gfx_test_support',
],
}],
['use_aura==1 or toolkit_views==1', {