diff options
| author | msw@chromium.org <msw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-02-24 20:05:10 +0000 |
|---|---|---|
| committer | msw@chromium.org <msw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-02-24 20:05:10 +0000 |
| commit | 334b4446460b98f4d5aec8299bbe8de6671136d0 (patch) | |
| tree | 9dfc7cc0e0e3bcffd3007b1921b5d358a9046fca | |
| parent | 3eb140a9a7c57584f82b7780d2f6353acbb37720 (diff) | |
| download | chromium_src-334b4446460b98f4d5aec8299bbe8de6671136d0.zip chromium_src-334b4446460b98f4d5aec8299bbe8de6671136d0.tar.gz chromium_src-334b4446460b98f4d5aec8299bbe8de6671136d0.tar.bz2 | |
Merge 251998 "Fix RTL UI extension popup anchoring."
> Fix RTL UI extension popup anchoring.
>
> BubbleDelegateView::CreateNonClientFrameView mirrors in RTL.
> (arrow horizontal positions/anchoring are flipped in RTL UI)
> BrowserActionsContainer::ShowPopup should not do the same.
> See before and after pictures at http://crbug.com/150696
>
> BUG=150696
> TEST=RTL (--lang=he) UI browser/page action extension popups should be anchored at the top left and shouldn't be cut off.
> R=sky@chromium.org
>
> Review URL: https://codereview.chromium.org/168723004
TBR=msw@chromium.org
Review URL: https://codereview.chromium.org/177863005
git-svn-id: svn://svn.chromium.org/chrome/branches/1847/src@252969 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/browser/ui/views/toolbar/browser_actions_container.cc | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/chrome/browser/ui/views/toolbar/browser_actions_container.cc b/chrome/browser/ui/views/toolbar/browser_actions_container.cc index eb25964..e039d52 100644 --- a/chrome/browser/ui/views/toolbar/browser_actions_container.cc +++ b/chrome/browser/ui/views/toolbar/browser_actions_container.cc @@ -860,12 +860,8 @@ bool BrowserActionsContainer::ShowPopup( // since buttons can be activated from the overflow menu (chevron). In that // case we show the popup as originating from the chevron. View* reference_view = button->parent()->visible() ? button : chevron_; - views::BubbleBorder::Arrow arrow = base::i18n::IsRTL() ? - views::BubbleBorder::TOP_LEFT : views::BubbleBorder::TOP_RIGHT; - popup_ = ExtensionPopup::ShowPopup(popup_url, - browser_, - reference_view, - arrow, + popup_ = ExtensionPopup::ShowPopup(popup_url, browser_, reference_view, + views::BubbleBorder::TOP_RIGHT, show_action); popup_->GetWidget()->AddObserver(this); popup_button_ = button; |