summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorscheib@chromium.org <scheib@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-02-20 12:58:47 +0000
committerscheib@chromium.org <scheib@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-02-20 12:58:47 +0000
commitb4d7eb8fc343b744d36ebc984b8c61a9f25f6975 (patch)
tree3fd43ebe7fb98e2a711382830fc4d780fb852813
parent2e9f3b678fd935ddd69e314534c714ae9180842d (diff)
downloadchromium_src-b4d7eb8fc343b744d36ebc984b8c61a9f25f6975.zip
chromium_src-b4d7eb8fc343b744d36ebc984b8c61a9f25f6975.tar.gz
chromium_src-b4d7eb8fc343b744d36ebc984b8c61a9f25f6975.tar.bz2
Remove --disable-fullscreen switch
BUG=343996 Review URL: https://codereview.chromium.org/167673002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252200 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--content/browser/renderer_host/render_process_host_impl.cc1
-rw-r--r--content/browser/renderer_host/render_view_host_impl.cc2
-rw-r--r--content/child/runtime_features.cc3
-rw-r--r--content/public/common/common_param_traits_macros.h1
-rw-r--r--content/public/common/content_switches.cc3
-rw-r--r--content/public/common/content_switches.h1
-rw-r--r--content/renderer/web_preferences.cc3
-rw-r--r--webkit/common/webpreferences.cc1
-rw-r--r--webkit/common/webpreferences.h1
9 files changed, 2 insertions, 14 deletions
diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc
index 4ac57d2..53e3e27 100644
--- a/content/browser/renderer_host/render_process_host_impl.cc
+++ b/content/browser/renderer_host/render_process_host_impl.cc
@@ -979,7 +979,6 @@ void RenderProcessHostImpl::PropagateBrowserCommandLineToRenderer(
switches::kDisableDirectNPAPIRequests,
switches::kDisableFileSystem,
switches::kDisableFiltersOverIPC,
- switches::kDisableFullScreen,
switches::kDisableGpu,
switches::kDisableGpuCompositing,
switches::kDisableGpuVsync,
diff --git a/content/browser/renderer_host/render_view_host_impl.cc b/content/browser/renderer_host/render_view_host_impl.cc
index f218d97..06a64c8 100644
--- a/content/browser/renderer_host/render_view_host_impl.cc
+++ b/content/browser/renderer_host/render_view_host_impl.cc
@@ -466,8 +466,6 @@ WebPreferences RenderViewHostImpl::GetWebkitPrefs(const GURL& url) {
!command_line.HasSwitch(switches::kDisableAcceleratedPlugins);
prefs.accelerated_compositing_for_video_enabled =
!command_line.HasSwitch(switches::kDisableAcceleratedVideo);
- prefs.fullscreen_enabled =
- !command_line.HasSwitch(switches::kDisableFullScreen);
prefs.lazy_layout_enabled =
command_line.HasSwitch(switches::kEnableExperimentalWebPlatformFeatures);
prefs.region_based_columns_enabled =
diff --git a/content/child/runtime_features.cc b/content/child/runtime_features.cc
index dee95d4..1a14950 100644
--- a/content/child/runtime_features.cc
+++ b/content/child/runtime_features.cc
@@ -117,9 +117,6 @@ void SetRuntimeFeaturesDefaultsAndUpdateFromArgs(
WebRuntimeFeatures::enableWebAudio(false);
#endif
- if (command_line.HasSwitch(switches::kDisableFullScreen))
- WebRuntimeFeatures::enableFullscreen(false);
-
if (command_line.HasSwitch(switches::kEnableEncryptedMedia))
WebRuntimeFeatures::enableEncryptedMedia(true);
diff --git a/content/public/common/common_param_traits_macros.h b/content/public/common/common_param_traits_macros.h
index 39fd118..8210dee 100644
--- a/content/public/common/common_param_traits_macros.h
+++ b/content/public/common/common_param_traits_macros.h
@@ -161,7 +161,6 @@ IPC_STRUCT_TRAITS_BEGIN(WebPreferences)
IPC_STRUCT_TRAITS_MEMBER(accelerated_compositing_for_animation_enabled)
IPC_STRUCT_TRAITS_MEMBER(accelerated_compositing_for_video_enabled)
IPC_STRUCT_TRAITS_MEMBER(memory_info_enabled)
- IPC_STRUCT_TRAITS_MEMBER(fullscreen_enabled)
IPC_STRUCT_TRAITS_MEMBER(allow_displaying_insecure_content)
IPC_STRUCT_TRAITS_MEMBER(allow_running_insecure_content)
IPC_STRUCT_TRAITS_MEMBER(enable_scroll_animator)
diff --git a/content/public/common/content_switches.cc b/content/public/common/content_switches.cc
index 4f25413..4fc67e2 100644
--- a/content/public/common/content_switches.cc
+++ b/content/public/common/content_switches.cc
@@ -188,9 +188,6 @@ const char kDisableFlashStage3d[] = "disable-flash-stage3d";
// via field trials.
const char kDisableForceCompositingMode[] = "disable-force-compositing-mode";
-// Disable the JavaScript Full Screen API.
-const char kDisableFullScreen[] = "disable-fullscreen";
-
// Disable deferral of scroll-ending gesture events when a scroll is active.
const char kDisableGestureDebounce[] = "disable-gesture-debounce";
diff --git a/content/public/common/content_switches.h b/content/public/common/content_switches.h
index 913ed5a..70cce1a 100644
--- a/content/public/common/content_switches.h
+++ b/content/public/common/content_switches.h
@@ -63,7 +63,6 @@ CONTENT_EXPORT extern const char kDisableFixedPositionCreatesStackingContext[];
CONTENT_EXPORT extern const char kDisableFlash3d[];
CONTENT_EXPORT extern const char kDisableFlashStage3d[];
CONTENT_EXPORT extern const char kDisableForceCompositingMode[];
-CONTENT_EXPORT extern const char kDisableFullScreen[];
CONTENT_EXPORT extern const char kDisableGestureDebounce[];
CONTENT_EXPORT extern const char kDisableGestureTapHighlight[];
CONTENT_EXPORT extern const char kDisableGLMultisampling[];
diff --git a/content/renderer/web_preferences.cc b/content/renderer/web_preferences.cc
index 6682e60..1649de8 100644
--- a/content/renderer/web_preferences.cc
+++ b/content/renderer/web_preferences.cc
@@ -285,7 +285,8 @@ void ApplyWebPreferences(const WebPreferences& prefs, WebView* web_view) {
// ChromeClient::tabsToLinks which is part of the glue code.
web_view->setTabsToLinks(prefs.tabs_to_links);
- settings->setFullScreenEnabled(prefs.fullscreen_enabled);
+ // TODO(scheib): crbug.com/344002 Remove FullScreenEnabled from Blink
+ settings->setFullScreenEnabled(true);
settings->setAllowDisplayOfInsecureContent(
prefs.allow_displaying_insecure_content);
settings->setAllowRunningOfInsecureContent(
diff --git a/webkit/common/webpreferences.cc b/webkit/common/webpreferences.cc
index dd62e9f..490b10f 100644
--- a/webkit/common/webpreferences.cc
+++ b/webkit/common/webpreferences.cc
@@ -79,7 +79,6 @@ WebPreferences::WebPreferences()
gesture_tap_highlight_enabled(false),
accelerated_compositing_for_plugins_enabled(false),
memory_info_enabled(false),
- fullscreen_enabled(false),
allow_displaying_insecure_content(true),
allow_running_insecure_content(false),
password_echo_enabled(false),
diff --git a/webkit/common/webpreferences.h b/webkit/common/webpreferences.h
index 279c43f..6ee63aa 100644
--- a/webkit/common/webpreferences.h
+++ b/webkit/common/webpreferences.h
@@ -127,7 +127,6 @@ struct WEBKIT_COMMON_EXPORT WebPreferences {
bool gesture_tap_highlight_enabled;
bool accelerated_compositing_for_plugins_enabled;
bool memory_info_enabled;
- bool fullscreen_enabled;
bool allow_displaying_insecure_content;
bool allow_running_insecure_content;
bool password_echo_enabled;