summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authoravi@chromium.org <avi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-11-27 21:18:07 +0000
committeravi@chromium.org <avi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-11-27 21:18:07 +0000
commit006128072c1334a8bd8c8658fcd8a5bb280151f9 (patch)
treeaef83e28a82725954c2600ef116db48b55cb268c
parent6d8c2eb2ec43dc9dff0d9b3b198a9874457591d6 (diff)
downloadchromium_src-006128072c1334a8bd8c8658fcd8a5bb280151f9.zip
chromium_src-006128072c1334a8bd8c8658fcd8a5bb280151f9.tar.gz
chromium_src-006128072c1334a8bd8c8658fcd8a5bb280151f9.tar.bz2
Always disable "content has shadow".
BUG=161603 TEST=as in bug Review URL: https://chromiumcodereview.appspot.com/11316172 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169755 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--ui/base/cocoa/underlay_opengl_hosting_window.mm13
1 files changed, 10 insertions, 3 deletions
diff --git a/ui/base/cocoa/underlay_opengl_hosting_window.mm b/ui/base/cocoa/underlay_opengl_hosting_window.mm
index e56323e..e69c66f 100644
--- a/ui/base/cocoa/underlay_opengl_hosting_window.mm
+++ b/ui/base/cocoa/underlay_opengl_hosting_window.mm
@@ -108,10 +108,17 @@ void RootDidAddSubview(id self, SEL _cmd, NSView* subview) {
// all windows hosting OpenGL content must not be opaque.
[self setOpaque:NO];
+ // Always disable "content has shadow". This class assumes that all holes
+ // punched in the window are intentional, in order to show accelerated
+ // content underneath, so those holes cannot be allowed to cause holes in
+ // the shadow. Note that the edges trimmed from around the periphery of a
+ // window (through use of transparency) don't count as content area with
+ // regards to "content has shadow".
+ [self _setContentHasShadow:NO];
+
+ // Only set up opaques if the window is a proper window with a title bar
+ // and all.
if (windowStyle & NSTitledWindowMask) {
- // Only fiddle with shadows if the window is a proper window with a
- // title bar and all.
- [self _setContentHasShadow:NO];
NSView* rootView = [[self contentView] superview];
const NSRect rootBounds = [rootView bounds];