summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authortoyoshim@chromium.org <toyoshim@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-04-13 08:33:27 +0000
committertoyoshim@chromium.org <toyoshim@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-04-13 08:33:27 +0000
commit55c154ab6b186d1dbd5ab5d5d9b6f2012ae2fb84 (patch)
tree6e2c28e0076ad0dc510f83de8b62309004916b99
parentd88199daef5b7b4c2991a5af3c769a7044750323 (diff)
downloadchromium_src-55c154ab6b186d1dbd5ab5d5d9b6f2012ae2fb84.zip
chromium_src-55c154ab6b186d1dbd5ab5d5d9b6f2012ae2fb84.tar.gz
chromium_src-55c154ab6b186d1dbd5ab5d5d9b6f2012ae2fb84.tar.bz2
Create chrome/renderer/translate directory and add OWNERS file
Browser side implementation has chrome/browser/translate directory, but renderer side doesn't. Add it for more productive codereview because currently changes on chrome/renderer/translate* needs chrome/ OWNERS review. BUG=none TEST=build all Review URL: https://chromiumcodereview.appspot.com/14223005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194096 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--chrome/chrome_renderer.gypi4
-rw-r--r--chrome/chrome_tests.gypi2
-rw-r--r--chrome/chrome_tests_unit.gypi2
-rw-r--r--chrome/renderer/chrome_render_view_observer.cc2
-rw-r--r--chrome/renderer/translate/OWNERS2
-rw-r--r--chrome/renderer/translate/translate_helper.cc (renamed from chrome/renderer/translate_helper.cc)2
-rw-r--r--chrome/renderer/translate/translate_helper.h (renamed from chrome/renderer/translate_helper.h)6
-rw-r--r--chrome/renderer/translate/translate_helper_browsertest.cc (renamed from chrome/renderer/translate_helper_browsertest.cc)2
-rw-r--r--chrome/renderer/translate/translate_helper_unittest.cc (renamed from chrome/renderer/translate_helper_unittest.cc)2
9 files changed, 13 insertions, 11 deletions
diff --git a/chrome/chrome_renderer.gypi b/chrome/chrome_renderer.gypi
index a78f33d..eb99e18 100644
--- a/chrome/chrome_renderer.gypi
+++ b/chrome/chrome_renderer.gypi
@@ -300,8 +300,8 @@
'renderer/spellchecker/spelling_engine.h',
'renderer/static_v8_external_string_resource.cc',
'renderer/static_v8_external_string_resource.h',
- 'renderer/translate_helper.cc',
- 'renderer/translate_helper.h',
+ 'renderer/translate/translate_helper.cc',
+ 'renderer/translate/translate_helper.h',
'renderer/webview_color_overlay.cc',
'renderer/webview_color_overlay.h',
],
diff --git a/chrome/chrome_tests.gypi b/chrome/chrome_tests.gypi
index 0ec665e..9b8b2db 100644
--- a/chrome/chrome_tests.gypi
+++ b/chrome/chrome_tests.gypi
@@ -1602,7 +1602,7 @@
'renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc',
'renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc',
'renderer/safe_browsing/phishing_thumbnailer_browsertest.cc',
- 'renderer/translate_helper_browsertest.cc',
+ 'renderer/translate/translate_helper_browsertest.cc',
'test/base/chrome_render_view_test.cc',
'test/base/chrome_render_view_test.h',
'test/base/chrome_test_launcher.cc',
diff --git a/chrome/chrome_tests_unit.gypi b/chrome/chrome_tests_unit.gypi
index 2d1640e..58e4b43 100644
--- a/chrome/chrome_tests_unit.gypi
+++ b/chrome/chrome_tests_unit.gypi
@@ -1605,7 +1605,7 @@
'renderer/spellchecker/spellcheck_provider_test.h',
'renderer/spellchecker/spellcheck_unittest.cc',
'renderer/spellchecker/spellcheck_worditerator_unittest.cc',
- 'renderer/translate_helper_unittest.cc',
+ 'renderer/translate/translate_helper_unittest.cc',
'service/cloud_print/cloud_print_helpers_unittest.cc',
'service/cloud_print/cloud_print_token_store_unittest.cc',
'service/cloud_print/cloud_print_url_fetcher_unittest.cc',
diff --git a/chrome/renderer/chrome_render_view_observer.cc b/chrome/renderer/chrome_render_view_observer.cc
index b4e6ea0..8e0420c 100644
--- a/chrome/renderer/chrome_render_view_observer.cc
+++ b/chrome/renderer/chrome_render_view_observer.cc
@@ -23,7 +23,7 @@
#include "chrome/renderer/frame_sniffer.h"
#include "chrome/renderer/prerender/prerender_helper.h"
#include "chrome/renderer/safe_browsing/phishing_classifier_delegate.h"
-#include "chrome/renderer/translate_helper.h"
+#include "chrome/renderer/translate/translate_helper.h"
#include "chrome/renderer/webview_color_overlay.h"
#include "content/public/common/bindings_policy.h"
#include "content/public/renderer/content_renderer_client.h"
diff --git a/chrome/renderer/translate/OWNERS b/chrome/renderer/translate/OWNERS
new file mode 100644
index 0000000..2dc9123
--- /dev/null
+++ b/chrome/renderer/translate/OWNERS
@@ -0,0 +1,2 @@
+mad@chromium.org
+toyoshim@chromium.org
diff --git a/chrome/renderer/translate_helper.cc b/chrome/renderer/translate/translate_helper.cc
index 911a03f..2f2c63d 100644
--- a/chrome/renderer/translate_helper.cc
+++ b/chrome/renderer/translate/translate_helper.cc
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/renderer/translate_helper.h"
+#include "chrome/renderer/translate/translate_helper.h"
#include "base/bind.h"
#include "base/compiler_specific.h"
diff --git a/chrome/renderer/translate_helper.h b/chrome/renderer/translate/translate_helper.h
index 8ddc63f..8e28015 100644
--- a/chrome/renderer/translate_helper.h
+++ b/chrome/renderer/translate/translate_helper.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_RENDERER_TRANSLATE_HELPER_H_
-#define CHROME_RENDERER_TRANSLATE_HELPER_H_
+#ifndef CHROME_RENDERER_TRANSLATE_TRANSLATE_HELPER_H_
+#define CHROME_RENDERER_TRANSLATE_TRANSLATE_HELPER_H_
#include <string>
@@ -152,4 +152,4 @@ class TranslateHelper : public content::RenderViewObserver {
DISALLOW_COPY_AND_ASSIGN(TranslateHelper);
};
-#endif // CHROME_RENDERER_TRANSLATE_HELPER_H_
+#endif // CHROME_RENDERER_TRANSLATE_TRANSLATE_HELPER_H_
diff --git a/chrome/renderer/translate_helper_browsertest.cc b/chrome/renderer/translate/translate_helper_browsertest.cc
index bee6b83..cf05f90 100644
--- a/chrome/renderer/translate_helper_browsertest.cc
+++ b/chrome/renderer/translate/translate_helper_browsertest.cc
@@ -4,7 +4,7 @@
#include "chrome/common/chrome_constants.h"
#include "chrome/common/render_messages.h"
-#include "chrome/renderer/translate_helper.h"
+#include "chrome/renderer/translate/translate_helper.h"
#include "chrome/test/base/chrome_render_view_test.h"
#include "content/public/renderer/render_view.h"
#include "testing/gmock/include/gmock/gmock.h"
diff --git a/chrome/renderer/translate_helper_unittest.cc b/chrome/renderer/translate/translate_helper_unittest.cc
index a7565d4..f945123 100644
--- a/chrome/renderer/translate_helper_unittest.cc
+++ b/chrome/renderer/translate/translate_helper_unittest.cc
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/renderer/translate_helper.h"
+#include "chrome/renderer/translate/translate_helper.h"
#include "base/utf_string_conversions.h"
#include "chrome/common/chrome_constants.h"