diff options
| author | sadrul@chromium.org <sadrul@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-09-14 02:33:21 +0000 |
|---|---|---|
| committer | sadrul@chromium.org <sadrul@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-09-14 02:33:21 +0000 |
| commit | 80b559c19958db9bdb36d993941670a1db809dd1 (patch) | |
| tree | e05d3c23126e7c70666c8e54a839404b5b83b547 | |
| parent | 095812b2a635835a02d7084ea993b62f94528187 (diff) | |
| download | chromium_src-80b559c19958db9bdb36d993941670a1db809dd1.zip chromium_src-80b559c19958db9bdb36d993941670a1db809dd1.tar.gz chromium_src-80b559c19958db9bdb36d993941670a1db809dd1.tar.bz2 | |
Revert 156701 because it caused crashes in linux_chromeos:browser_tests
---
Fixing a crasher in ResourcePrefetchPredictor::ReportAccuracyHistograms
Review URL: https://chromiumcodereview.appspot.com/10910262
TBR=shishir@chromium.org
Review URL: https://codereview.chromium.org/10916310
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156717 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/browser/predictors/resource_prefetch_predictor.cc | 13 |
1 files changed, 3 insertions, 10 deletions
diff --git a/chrome/browser/predictors/resource_prefetch_predictor.cc b/chrome/browser/predictors/resource_prefetch_predictor.cc index c9a01fd..30adf60 100644 --- a/chrome/browser/predictors/resource_prefetch_predictor.cc +++ b/chrome/browser/predictors/resource_prefetch_predictor.cc @@ -733,8 +733,6 @@ void ResourcePrefetchPredictor::LearnUrlNavigation( ResourcePrefetchPredictorTables::UrlTableRowSorter()); if (static_cast<int>(rows.size()) > config_.max_resources_per_entry) rows.resize(config_.max_resources_per_entry); - if (rows.size() == 0) - url_table_cache_.erase(main_frame_url); BrowserThread::PostTask( BrowserThread::DB, FROM_HERE, @@ -811,9 +809,6 @@ void ResourcePrefetchPredictor::ReportAccuracyHistograms( int prefetch_cached = 0, prefetch_network = 0, prefetch_missed = 0; int num_assumed_prefetched = std::min(static_cast<int>(predicted.size()), max_assumed_prefetched); - if (num_assumed_prefetched == 0) - return; - for (int i = 0; i < num_assumed_prefetched; ++i) { const UrlTableRow& row = predicted[i]; std::map<GURL, bool>::const_iterator it = actual_resources.find( @@ -866,11 +861,9 @@ void ResourcePrefetchPredictor::ReportAccuracyHistograms( // Measure the ratio of total number of resources prefetched from network vs // the total number of resources fetched by the page from the network. - if (total_resources_fetched_from_network > 0) { - RPP_PREDICTED_HISTOGRAM_PERCENTAGE( - "PrefetchFromNetworkPercentOfTotalFromNetwork", - prefetch_network * 100.0 / total_resources_fetched_from_network); - } + RPP_PREDICTED_HISTOGRAM_PERCENTAGE( + "PrefetchFromNetworkPercentOfTotalFromNetwork", + prefetch_network * 100.0 / total_resources_fetched_from_network); #undef RPP_PREDICTED_HISTOGRAM_PERCENTAGE #undef RPP_PREDICTED_HISTOGRAM_COUNTS |