diff options
| author | petkov@chromium.org <petkov@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-24 22:27:01 +0000 |
|---|---|---|
| committer | petkov@chromium.org <petkov@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-24 22:27:01 +0000 |
| commit | 2f603cd6eca27e6fac4412922f82bb1581894790 (patch) | |
| tree | 7c35930ebc6c8f59fb4f80cd075f89f011d97ed9 | |
| parent | 38919392d25b10451fd7972ced8eb5f50d94f55e (diff) | |
| download | chromium_src-2f603cd6eca27e6fac4412922f82bb1581894790.zip chromium_src-2f603cd6eca27e6fac4412922f82bb1581894790.tar.gz chromium_src-2f603cd6eca27e6fac4412922f82bb1581894790.tar.bz2 | |
Switch ChildProcess.* enum histograms from COUNTS to ENUMERATION.
These histograms shouldn't have been _COUNTS histograms in the first
place. _COUNTS histograms bucket the data in exponentially spaced buckets. This
causes, for example, PPAPI crashes to be bucketed together with (and as) GPU
crashes. To avoid messing up collected data and to ensure smooth transition,
renamed histograms.
BUG=chromium-os:21841
TEST=git try, looked at about:histograms
Change-Id: I137499992c60bdf6488561150f5b6642acc862b8
Review URL: http://codereview.chromium.org/8356042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106993 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | content/browser/browser_child_process_host.cc | 12 | ||||
| -rw-r--r-- | content/common/child_process_info.h | 3 |
2 files changed, 10 insertions, 5 deletions
diff --git a/content/browser/browser_child_process_host.cc b/content/browser/browser_child_process_host.cc index 7b79495..af10c45d 100644 --- a/content/browser/browser_child_process_host.cc +++ b/content/browser/browser_child_process_host.cc @@ -149,9 +149,11 @@ void BrowserChildProcessHost::OnChildDisconnected() { OnProcessCrashed(exit_code); // Report that this child process crashed. Notify(content::NOTIFICATION_CHILD_PROCESS_CRASHED); - UMA_HISTOGRAM_COUNTS("ChildProcess.Crashes", this->type()); + UMA_HISTOGRAM_ENUMERATION("ChildProcess.Crashed", + this->type(), MAX_PROCESS); if (disconnect_was_alive_) { - UMA_HISTOGRAM_COUNTS("ChildProcess.CrashesWasAlive", this->type()); + UMA_HISTOGRAM_ENUMERATION("ChildProcess.CrashedWasAlive", + this->type(), MAX_PROCESS); } break; } @@ -159,9 +161,11 @@ void BrowserChildProcessHost::OnChildDisconnected() { OnProcessWasKilled(exit_code); // Report that this child process was killed. Notify(content::NOTIFICATION_CHILD_PROCESS_WAS_KILLED); - UMA_HISTOGRAM_COUNTS("ChildProcess.Kills", this->type()); + UMA_HISTOGRAM_ENUMERATION("ChildProcess.Killed", + this->type(), MAX_PROCESS); if (disconnect_was_alive_) { - UMA_HISTOGRAM_COUNTS("ChildProcess.KillsWasAlive", this->type()); + UMA_HISTOGRAM_ENUMERATION("ChildProcess.KilledWasAlive", + this->type(), MAX_PROCESS); } break; } diff --git a/content/common/child_process_info.h b/content/common/child_process_info.h index 86ecc05..ec50849 100644 --- a/content/common/child_process_info.h +++ b/content/common/child_process_info.h @@ -16,7 +16,8 @@ class CONTENT_EXPORT ChildProcessInfo { public: // NOTE: Do not remove or reorder the elements in this enum, and only add new - // items at the end. We depend on these specific values in a histogram. + // items at the end, right before MAX_PROCESS. We depend on these specific + // values in histograms. enum ProcessType { UNKNOWN_PROCESS = 1, BROWSER_PROCESS, |