Accurately account for pre-classification successes.

The current UMA stat which measures pre-classification failures will count pre-classification successes as failures when the object is eventually cancelled and deleted.  This CL resets the done pre-classification check callbacks when the pre-classification checks succeed to stop counting successes as failures.

BUG=360115

Review URL: https://codereview.chromium.org/224803004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261950 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 10 insertions, 2 deletions

diff --git a/chrome/browser/safe_browsing/client_side_detection_host.cc b/chrome/browser/safe_browsing/client_side_detection_host.cc
index b223f54..a7d96cf 100644
--- a/chrome/browser/safe_browsing/client_side_detection_host.cc
+++ b/chrome/browser/safe_browsing/client_side_detection_host.cc
@@ -281,10 +281,18 @@ class ClientSideDetectionHost::ShouldClassifyUrlRequest
     // Everything checks out, so start classification.
     // |web_contents_| is safe to call as we will be destructed
     // before it is.
-    if (ShouldClassifyForPhishing())
+    if (ShouldClassifyForPhishing()) {
       start_phishing_classification_cb_.Run(true);
-    if (ShouldClassifyForMalware())
+      // Reset the callback to make sure ShouldClassifyForPhishing()
+      // returns false.
+      start_phishing_classification_cb_.Reset();
+    }
+    if (ShouldClassifyForMalware()) {
       start_malware_classification_cb_.Run(true);
+      // Reset the callback to make sure ShouldClassifyForMalware()
+      // returns false.
+      start_malware_classification_cb_.Reset();
+    }
   }
 
   content::FrameNavigateParams params_;