summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorjam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-04-11 16:07:11 +0000
committerjam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-04-11 16:07:11 +0000
commitf9db7d2d160515ddac6eca9e7e04881b862c18db (patch)
tree0fd71a1902aacd5b797c477c231109570c4fbe67
parent489a0cf8bbe82a2cba05f5b002a47dc61d11966e (diff)
downloadchromium_src-f9db7d2d160515ddac6eca9e7e04881b862c18db.zip
chromium_src-f9db7d2d160515ddac6eca9e7e04881b862c18db.tar.gz
chromium_src-f9db7d2d160515ddac6eca9e7e04881b862c18db.tar.bz2
Simplify some Win Aura ifdefs.
R=scottmg@chromium.org TBR=ben Review URL: https://codereview.chromium.org/233263005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263256 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--chrome/browser/about_flags.cc2
-rw-r--r--chrome/browser/autofill/form_structure_browsertest.cc2
-rw-r--r--chrome/browser/download/download_danger_prompt.cc2
-rw-r--r--chrome/browser/errorpage_browsertest.cc2
-rw-r--r--chrome/browser/extensions/extension_crash_recovery_browsertest.cc2
-rw-r--r--chrome/browser/themes/theme_service.cc2
-rw-r--r--chrome/browser/ui/find_bar/find_bar_host_browsertest.cc4
-rw-r--r--chrome/browser/ui/views/frame/browser_frame.cc2
-rw-r--r--chrome/browser/ui/views/frame/browser_non_client_frame_view_factory_aura.cc2
-rw-r--r--chrome/browser/ui/views/omnibox/omnibox_view_views.cc6
-rw-r--r--components/web_modal/web_contents_modal_dialog_manager.cc2
-rw-r--r--content/browser/browser_plugin/browser_plugin_guest.cc4
-rw-r--r--content/browser/browser_plugin/browser_plugin_guest.h2
-rw-r--r--content/browser/frame_host/render_widget_host_view_child_frame.cc6
-rw-r--r--content/browser/frame_host/render_widget_host_view_child_frame.h6
-rw-r--r--content/browser/frame_host/render_widget_host_view_guest.cc20
-rw-r--r--content/browser/frame_host/render_widget_host_view_guest.h10
-rw-r--r--content/browser/renderer_host/input/input_router_impl_unittest.cc10
-rw-r--r--content/browser/renderer_host/render_widget_host_impl.cc4
-rw-r--r--content/browser/renderer_host/render_widget_host_impl.h2
-rw-r--r--content/browser/renderer_host/render_widget_host_unittest.cc2
-rw-r--r--content/common/view_messages.h4
-rw-r--r--content/port/browser/render_widget_host_view_port.h2
-rw-r--r--content/public/browser/web_contents_view_delegate.h2
-rw-r--r--content/renderer/render_frame_impl.cc2
-rw-r--r--content/renderer/render_view_browsertest.cc2
-rw-r--r--content/renderer/render_view_impl.cc2
-rw-r--r--content/renderer/render_view_impl.h2
-rw-r--r--content/renderer/render_widget.cc10
-rw-r--r--content/renderer/render_widget.h4
-rw-r--r--content/test/test_render_view_host.h2
-rw-r--r--ui/base/clipboard/clipboard.h2
-rw-r--r--ui/base/dragdrop/os_exchange_data.cc4
-rw-r--r--ui/base/dragdrop/os_exchange_data.h6
-rw-r--r--ui/gfx/path.h2
35 files changed, 66 insertions, 74 deletions
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index f019009..c5967b7 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -1692,7 +1692,7 @@ const Experiment kExperiments[] = {
kOsAll,
SINGLE_VALUE_TYPE(autofill::switches::kDisableIgnoreAutocompleteOff)
},
-#if defined(USE_AURA) || defined(OS_WIN)
+#if defined(USE_AURA)
{
"enable-permissions-bubbles",
IDS_FLAGS_ENABLE_PERMISSIONS_BUBBLES_NAME,
diff --git a/chrome/browser/autofill/form_structure_browsertest.cc b/chrome/browser/autofill/form_structure_browsertest.cc
index cb3abcc..ed186a9 100644
--- a/chrome/browser/autofill/form_structure_browsertest.cc
+++ b/chrome/browser/autofill/form_structure_browsertest.cc
@@ -104,7 +104,7 @@ std::string FormStructureBrowserTest::FormStructuresToString(
// Heuristics tests timeout on Windows. See http://crbug.com/85276
// Also on ChromeOS/Aura. See crbug.com/173621
// On Linux too. See crbug.com/323093
-#if defined(OS_WIN) || defined(USE_AURA) || defined(OS_LINUX)
+#if defined(USE_AURA)
#define MAYBE_DataDrivenHeuristics(n) DISABLED_DataDrivenHeuristics##n
#else
#define MAYBE_DataDrivenHeuristics(n) DataDrivenHeuristics##n
diff --git a/chrome/browser/download/download_danger_prompt.cc b/chrome/browser/download/download_danger_prompt.cc
index 03c410d..4ec23bc 100644
--- a/chrome/browser/download/download_danger_prompt.cc
+++ b/chrome/browser/download/download_danger_prompt.cc
@@ -230,7 +230,7 @@ void DownloadDangerPromptImpl::RunDone(Action action) {
} // namespace
-#if !(defined(OS_WIN) || defined(USE_AURA))
+#if !defined(USE_AURA)
// static
DownloadDangerPrompt* DownloadDangerPrompt::Create(
content::DownloadItem* item,
diff --git a/chrome/browser/errorpage_browsertest.cc b/chrome/browser/errorpage_browsertest.cc
index cc95ab7..d68f99c 100644
--- a/chrome/browser/errorpage_browsertest.cc
+++ b/chrome/browser/errorpage_browsertest.cc
@@ -281,7 +281,7 @@ void InterceptNetworkTransactions(net::URLRequestContextGetter* getter,
}
// See crbug.com/109669
-#if defined(USE_AURA) || defined(OS_WIN)
+#if defined(USE_AURA)
#define MAYBE_DNSError_Basic DISABLED_DNSError_Basic
#else
#define MAYBE_DNSError_Basic DNSError_Basic
diff --git a/chrome/browser/extensions/extension_crash_recovery_browsertest.cc b/chrome/browser/extensions/extension_crash_recovery_browsertest.cc
index ccaf59e..0f943bf 100644
--- a/chrome/browser/extensions/extension_crash_recovery_browsertest.cc
+++ b/chrome/browser/extensions/extension_crash_recovery_browsertest.cc
@@ -510,7 +510,7 @@ IN_PROC_BROWSER_TEST_F(MAYBE_ExtensionCrashRecoveryTest,
// Fails a DCHECK on Aura and Linux: http://crbug.com/169622
// Failing on Windows: http://crbug.com/232340
-#if defined(USE_AURA) || defined(OS_WIN) || defined(OS_LINUX)
+#if defined(USE_AURA)
#define MAYBE_ReloadTabsWithBackgroundPage DISABLED_ReloadTabsWithBackgroundPage
#else
#define MAYBE_ReloadTabsWithBackgroundPage ReloadTabsWithBackgroundPage
diff --git a/chrome/browser/themes/theme_service.cc b/chrome/browser/themes/theme_service.cc
index 584ed73..c8c25fc 100644
--- a/chrome/browser/themes/theme_service.cc
+++ b/chrome/browser/themes/theme_service.cc
@@ -482,7 +482,7 @@ void ThemeService::NotifyThemeChanged() {
}
}
-#if defined(OS_WIN) || defined(USE_AURA)
+#if defined(USE_AURA)
void ThemeService::FreePlatformCaches() {
// Views (Skia) has no platform image cache to clear.
}
diff --git a/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc b/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc
index ff66240..a64f211 100644
--- a/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc
+++ b/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc
@@ -992,9 +992,9 @@ IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, FindMovesWhenObscuring) {
EXPECT_EQ(position.x(), start_position.x());
}
-// FindNextInNewTabUsesPrepopulate times-out on Mac, Windows and Aura.
+// FindNextInNewTabUsesPrepopulate times-out on Mac and Aura.
// See http://crbug.com/43070
-#if defined(OS_MACOSX) || defined(OS_WIN) || defined(USE_AURA)
+#if defined(OS_MACOSX) || defined(USE_AURA)
#define MAYBE_FindNextInNewTabUsesPrepopulate \
DISABLED_FindNextInNewTabUsesPrepopulate
#else
diff --git a/chrome/browser/ui/views/frame/browser_frame.cc b/chrome/browser/ui/views/frame/browser_frame.cc
index a3143f0..a2db1e9 100644
--- a/chrome/browser/ui/views/frame/browser_frame.cc
+++ b/chrome/browser/ui/views/frame/browser_frame.cc
@@ -291,11 +291,9 @@ NewAvatarButton* BrowserFrame::GetNewAvatarMenuButton() {
return browser_frame_view_->new_avatar_button();
}
-#if !defined(OS_WIN) || defined(USE_AURA)
bool BrowserFrame::ShouldLeaveOffsetNearTopBorder() {
return !IsMaximized();
}
-#endif // OS_WIN
void BrowserFrame::OnUseCustomChromeFrameChanged() {
// Tell the window manager to add or remove system borders.
diff --git a/chrome/browser/ui/views/frame/browser_non_client_frame_view_factory_aura.cc b/chrome/browser/ui/views/frame/browser_non_client_frame_view_factory_aura.cc
index fc79d1c..2a4a3c6 100644
--- a/chrome/browser/ui/views/frame/browser_non_client_frame_view_factory_aura.cc
+++ b/chrome/browser/ui/views/frame/browser_non_client_frame_view_factory_aura.cc
@@ -19,7 +19,7 @@ namespace chrome {
BrowserNonClientFrameView* CreateBrowserNonClientFrameView(
BrowserFrame* frame, BrowserView* browser_view) {
-#if defined(USE_AURA) && defined(OS_WIN)
+#if defined(OS_WIN)
if (browser_view->browser()->
host_desktop_type() == chrome::HOST_DESKTOP_TYPE_NATIVE) {
if (frame->ShouldUseNativeFrame())
diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
index a04dd57..2197dab 100644
--- a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
+++ b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
@@ -576,17 +576,11 @@ gfx::NativeView OmniboxViewViews::GetRelativeWindowForPopup() const {
}
void OmniboxViewViews::SetGrayTextAutocompletion(const base::string16& input) {
-#if defined(OS_WIN) || defined(USE_AURA)
location_bar_view_->SetGrayTextAutocompletion(input);
-#endif
}
base::string16 OmniboxViewViews::GetGrayTextAutocompletion() const {
-#if defined(OS_WIN) || defined(USE_AURA)
return location_bar_view_->GetGrayTextAutocompletion();
-#else
- return base::string16();
-#endif
}
int OmniboxViewViews::GetWidth() const {
diff --git a/components/web_modal/web_contents_modal_dialog_manager.cc b/components/web_modal/web_contents_modal_dialog_manager.cc
index 53b4667..3b457eb 100644
--- a/components/web_modal/web_contents_modal_dialog_manager.cc
+++ b/components/web_modal/web_contents_modal_dialog_manager.cc
@@ -93,7 +93,7 @@ WebContentsModalDialogManager::WebContentsModalDialogManager(
WebContentsModalDialogManager::DialogState::DialogState(
NativeWebContentsModalDialog dialog)
: dialog(dialog),
-#if defined(OS_WIN) || defined(USE_AURA)
+#if defined(USE_AURA)
close_on_interstitial_webui(true)
#else
// TODO(wittman): Test that closing on interstitial webui works properly
diff --git a/content/browser/browser_plugin/browser_plugin_guest.cc b/content/browser/browser_plugin/browser_plugin_guest.cc
index dbf0f14..efabc2c 100644
--- a/content/browser/browser_plugin/browser_plugin_guest.cc
+++ b/content/browser/browser_plugin/browser_plugin_guest.cc
@@ -1249,7 +1249,7 @@ bool BrowserPluginGuest::OnMessageReceived(const IPC::Message& message) {
OnTextInputTypeChanged)
IPC_MESSAGE_HANDLER(ViewHostMsg_ImeCancelComposition,
OnImeCancelComposition)
-#if defined(OS_MACOSX) || defined(OS_WIN) || defined(USE_AURA)
+#if defined(OS_MACOSX) || defined(USE_AURA)
IPC_MESSAGE_HANDLER(ViewHostMsg_ImeCompositionRangeChanged,
OnImeCompositionRangeChanged)
#endif
@@ -1908,7 +1908,7 @@ void BrowserPluginGuest::OnImeCancelComposition() {
web_contents()->GetRenderWidgetHostView())->ImeCancelComposition();
}
-#if defined(OS_MACOSX) || defined(OS_WIN) || defined(USE_AURA)
+#if defined(OS_MACOSX) || defined(USE_AURA)
void BrowserPluginGuest::OnImeCompositionRangeChanged(
const gfx::Range& range,
const std::vector<gfx::Rect>& character_bounds) {
diff --git a/content/browser/browser_plugin/browser_plugin_guest.h b/content/browser/browser_plugin/browser_plugin_guest.h
index 016881f..3aa61f9 100644
--- a/content/browser/browser_plugin/browser_plugin_guest.h
+++ b/content/browser/browser_plugin/browser_plugin_guest.h
@@ -503,7 +503,7 @@ class CONTENT_EXPORT BrowserPluginGuest
void OnExtendSelectionAndDelete(int instance_id, int before, int after);
// Overridden in tests.
virtual void OnImeCancelComposition();
-#if defined(OS_MACOSX) || defined(OS_WIN) || defined(USE_AURA)
+#if defined(OS_MACOSX) || defined(USE_AURA)
void OnImeCompositionRangeChanged(
const gfx::Range& range,
const std::vector<gfx::Rect>& character_bounds);
diff --git a/content/browser/frame_host/render_widget_host_view_child_frame.cc b/content/browser/frame_host/render_widget_host_view_child_frame.cc
index 14e52b2..c71a1f0 100644
--- a/content/browser/frame_host/render_widget_host_view_child_frame.cc
+++ b/content/browser/frame_host/render_widget_host_view_child_frame.cc
@@ -112,7 +112,7 @@ void RenderWidgetHostViewChildFrame::ImeCancelComposition() {
NOTREACHED();
}
-#if defined(OS_MACOSX) || defined(OS_WIN) || defined(USE_AURA)
+#if defined(OS_MACOSX) || defined(USE_AURA)
void RenderWidgetHostViewChildFrame::ImeCompositionRangeChanged(
const gfx::Range& range,
const std::vector<gfx::Rect>& character_bounds) {
@@ -244,12 +244,12 @@ gfx::Rect RenderWidgetHostViewChildFrame::GetBoundsInRootWindow() {
return GetViewBounds();
}
-#if defined(OS_WIN) || defined(USE_AURA)
+#if defined(USE_AURA)
void RenderWidgetHostViewChildFrame::ProcessAckedTouchEvent(
const TouchEventWithLatencyInfo& touch,
InputEventAckState ack_result) {
}
-#endif // defined(OS_WIN) || defined(USE_AURA)
+#endif // defined(USE_AURA)
bool RenderWidgetHostViewChildFrame::LockMouse() {
return false;
diff --git a/content/browser/frame_host/render_widget_host_view_child_frame.h b/content/browser/frame_host/render_widget_host_view_child_frame.h
index 6d25cd0..b9689d2 100644
--- a/content/browser/frame_host/render_widget_host_view_child_frame.h
+++ b/content/browser/frame_host/render_widget_host_view_child_frame.h
@@ -70,7 +70,7 @@ class CONTENT_EXPORT RenderWidgetHostViewChildFrame
ui::TextInputMode input_mode,
bool can_compose_inline) OVERRIDE;
virtual void ImeCancelComposition() OVERRIDE;
-#if defined(OS_MACOSX) || defined(OS_WIN) || defined(USE_AURA)
+#if defined(OS_MACOSX) || defined(USE_AURA)
virtual void ImeCompositionRangeChanged(
const gfx::Range& range,
const std::vector<gfx::Rect>& character_bounds) OVERRIDE;
@@ -126,11 +126,11 @@ class CONTENT_EXPORT RenderWidgetHostViewChildFrame
bool has_horizontal_scrollbar) OVERRIDE;
virtual void SetScrollOffsetPinning(
bool is_pinned_to_left, bool is_pinned_to_right) OVERRIDE;
-#if defined(OS_WIN) || defined(USE_AURA)
+#if defined(USE_AURA)
virtual void ProcessAckedTouchEvent(
const TouchEventWithLatencyInfo& touch,
InputEventAckState ack_result) OVERRIDE;
-#endif // defined(OS_WIN) || defined(USE_AURA)
+#endif // defined(USE_AURA)
virtual bool LockMouse() OVERRIDE;
virtual void UnlockMouse() OVERRIDE;
diff --git a/content/browser/frame_host/render_widget_host_view_guest.cc b/content/browser/frame_host/render_widget_host_view_guest.cc
index 00dcd41..c7ef31b 100644
--- a/content/browser/frame_host/render_widget_host_view_guest.cc
+++ b/content/browser/frame_host/render_widget_host_view_guest.cc
@@ -23,7 +23,7 @@
#import "content/browser/renderer_host/render_widget_host_view_mac_dictionary_helper.h"
#endif
-#if defined(OS_WIN) || defined(USE_AURA)
+#if defined(USE_AURA)
#include "content/browser/renderer_host/ui_events_helper.h"
#endif
@@ -31,7 +31,7 @@ namespace content {
namespace {
-#if defined(OS_WIN) || defined(USE_AURA)
+#if defined(USE_AURA)
blink::WebGestureEvent CreateFlingCancelEvent(double time_stamp) {
blink::WebGestureEvent gesture_event;
gesture_event.timeStampSeconds = time_stamp;
@@ -39,7 +39,7 @@ blink::WebGestureEvent CreateFlingCancelEvent(double time_stamp) {
gesture_event.sourceDevice = blink::WebGestureEvent::Touchscreen;
return gesture_event;
}
-#endif // defined(OS_WIN) || defined(USE_AURA)
+#endif // defined(USE_AURA)
} // namespace
@@ -51,16 +51,16 @@ RenderWidgetHostViewGuest::RenderWidgetHostViewGuest(
// |guest| is NULL during test.
guest_(guest ? guest->AsWeakPtr() : base::WeakPtr<BrowserPluginGuest>()),
platform_view_(static_cast<RenderWidgetHostViewPort*>(platform_view)) {
-#if defined(OS_WIN) || defined(USE_AURA)
+#if defined(USE_AURA)
gesture_recognizer_.reset(ui::GestureRecognizer::Create());
gesture_recognizer_->AddGestureEventHelper(this);
-#endif // defined(OS_WIN) || defined(USE_AURA)
+#endif // defined(USE_AURA)
}
RenderWidgetHostViewGuest::~RenderWidgetHostViewGuest() {
-#if defined(OS_WIN) || defined(USE_AURA)
+#if defined(USE_AURA)
gesture_recognizer_->RemoveGestureEventHelper(this);
-#endif // defined(OS_WIN) || defined(USE_AURA)
+#endif // defined(USE_AURA)
}
void RenderWidgetHostViewGuest::WasShown() {
@@ -92,7 +92,7 @@ void RenderWidgetHostViewGuest::SetBounds(const gfx::Rect& rect) {
SetSize(rect.size());
}
-#if defined(OS_WIN) || defined(USE_AURA)
+#if defined(USE_AURA)
void RenderWidgetHostViewGuest::ProcessAckedTouchEvent(
const TouchEventWithLatencyInfo& touch, InputEventAckState ack_result) {
// TODO(fsamuel): Currently we will only take this codepath if the guest has
@@ -320,7 +320,7 @@ void RenderWidgetHostViewGuest::ImeCancelComposition() {
rwhv->ImeCancelComposition();
}
-#if defined(OS_MACOSX) || defined(OS_WIN) || defined(USE_AURA)
+#if defined(OS_MACOSX) || defined(USE_AURA)
void RenderWidgetHostViewGuest::ImeCompositionRangeChanged(
const gfx::Range& range,
const std::vector<gfx::Rect>& character_bounds) {
@@ -538,7 +538,7 @@ void RenderWidgetHostViewGuest::DispatchCancelTouchEvent(
bool RenderWidgetHostViewGuest::ForwardGestureEventToRenderer(
ui::GestureEvent* gesture) {
-#if defined(OS_WIN) || defined(USE_AURA)
+#if defined(USE_AURA)
if (!host_)
return false;
diff --git a/content/browser/frame_host/render_widget_host_view_guest.h b/content/browser/frame_host/render_widget_host_view_guest.h
index 930650d..468ba74 100644
--- a/content/browser/frame_host/render_widget_host_view_guest.h
+++ b/content/browser/frame_host/render_widget_host_view_guest.h
@@ -73,7 +73,7 @@ class CONTENT_EXPORT RenderWidgetHostViewGuest
ui::TextInputMode input_mode,
bool can_compose_inline) OVERRIDE;
virtual void ImeCancelComposition() OVERRIDE;
-#if defined(OS_MACOSX) || defined(OS_WIN) || defined(USE_AURA)
+#if defined(OS_MACOSX) || defined(USE_AURA)
virtual void ImeCompositionRangeChanged(
const gfx::Range& range,
const std::vector<gfx::Rect>& character_bounds) OVERRIDE;
@@ -113,11 +113,11 @@ class CONTENT_EXPORT RenderWidgetHostViewGuest
bool has_horizontal_scrollbar) OVERRIDE;
virtual void SetScrollOffsetPinning(
bool is_pinned_to_left, bool is_pinned_to_right) OVERRIDE;
-#if defined(OS_WIN) || defined(USE_AURA)
+#if defined(USE_AURA)
virtual void ProcessAckedTouchEvent(
const TouchEventWithLatencyInfo& touch,
InputEventAckState ack_result) OVERRIDE;
-#endif // defined(OS_WIN) || defined(USE_AURA)
+#endif
virtual bool LockMouse() OVERRIDE;
virtual void UnlockMouse() OVERRIDE;
virtual void GetScreenInfo(blink::WebScreenInfo* results) OVERRIDE;
@@ -179,9 +179,9 @@ class CONTENT_EXPORT RenderWidgetHostViewGuest
// RenderWidgetHostViewGuest mostly only cares about stuff related to
// compositing, the rest are directly forwared to this |platform_view_|.
RenderWidgetHostViewPort* platform_view_;
-#if defined(OS_WIN) || defined(USE_AURA)
+#if defined(USE_AURA)
scoped_ptr<ui::GestureRecognizer> gesture_recognizer_;
-#endif // defined(OS_WIN) || defined(USE_AURA)
+#endif
DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewGuest);
};
diff --git a/content/browser/renderer_host/input/input_router_impl_unittest.cc b/content/browser/renderer_host/input/input_router_impl_unittest.cc
index ae6b137..0fbb1b3 100644
--- a/content/browser/renderer_host/input/input_router_impl_unittest.cc
+++ b/content/browser/renderer_host/input/input_router_impl_unittest.cc
@@ -24,7 +24,7 @@
#include "testing/gtest/include/gtest/gtest.h"
#include "ui/events/keycodes/keyboard_codes.h"
-#if defined(OS_WIN) || defined(USE_AURA)
+#if defined(USE_AURA)
#include "content/browser/renderer_host/ui_events_helper.h"
#include "ui/events/event.h"
#endif
@@ -76,7 +76,7 @@ void ExpectIPCMessageWithArg2(const IPC::Message* msg,
EXPECT_EQ(arg2, param.b);
}
-#if defined(OS_WIN) || defined(USE_AURA)
+#if defined(USE_AURA)
bool TouchEventsAreEquivalent(const ui::TouchEvent& first,
const ui::TouchEvent& second) {
if (first.type() != second.type())
@@ -104,7 +104,7 @@ bool EventListIsSubset(const ScopedVector<ui::TouchEvent>& subset,
return true;
}
-#endif // defined(OS_WIN) || defined(USE_AURA)
+#endif // defined(USE_AURA)
} // namespace
@@ -619,7 +619,7 @@ TEST_F(InputRouterImplTest, TouchEventQueueFlush) {
EXPECT_FALSE(input_router_->ShouldForwardTouchEvent());
}
-#if defined(OS_WIN) || defined(USE_AURA)
+#if defined(USE_AURA)
// Tests that the acked events have correct state. (ui::Events are used only on
// windows and aura)
TEST_F(InputRouterImplTest, AckedTouchEventState) {
@@ -704,7 +704,7 @@ TEST_F(InputRouterImplTest, AckedTouchEventState) {
EXPECT_TRUE(TouchEventQueueEmpty());
EXPECT_EQ(0U, expected_events.size());
}
-#endif // defined(OS_WIN) || defined(USE_AURA)
+#endif // defined(USE_AURA)
TEST_F(InputRouterImplTest, UnhandledWheelEvent) {
// Simulate wheel events.
diff --git a/content/browser/renderer_host/render_widget_host_impl.cc b/content/browser/renderer_host/render_widget_host_impl.cc
index aee32a0..48d5113 100644
--- a/content/browser/renderer_host/render_widget_host_impl.cc
+++ b/content/browser/renderer_host/render_widget_host_impl.cc
@@ -505,7 +505,7 @@ bool RenderWidgetHostImpl::OnMessageReceived(const IPC::Message &msg) {
IPC_MESSAGE_HANDLER(ViewHostMsg_CompositorSurfaceBuffersSwapped,
OnCompositorSurfaceBuffersSwapped)
#endif
-#if defined(OS_MACOSX) || defined(OS_WIN) || defined(USE_AURA)
+#if defined(OS_MACOSX) || defined(USE_AURA)
IPC_MESSAGE_HANDLER(ViewHostMsg_ImeCompositionRangeChanged,
OnImeCompositionRangeChanged)
#endif
@@ -1831,7 +1831,7 @@ void RenderWidgetHostImpl::OnTextInputTypeChanged(
view_->TextInputTypeChanged(type, input_mode, can_compose_inline);
}
-#if defined(OS_MACOSX) || defined(OS_WIN) || defined(USE_AURA)
+#if defined(OS_MACOSX) || defined(USE_AURA)
void RenderWidgetHostImpl::OnImeCompositionRangeChanged(
const gfx::Range& range,
const std::vector<gfx::Rect>& character_bounds) {
diff --git a/content/browser/renderer_host/render_widget_host_impl.h b/content/browser/renderer_host/render_widget_host_impl.h
index 44628b9..b6f9cb7 100644
--- a/content/browser/renderer_host/render_widget_host_impl.h
+++ b/content/browser/renderer_host/render_widget_host_impl.h
@@ -674,7 +674,7 @@ class CONTENT_EXPORT RenderWidgetHostImpl : virtual public RenderWidgetHost,
void OnTextInputTypeChanged(ui::TextInputType type,
ui::TextInputMode input_mode,
bool can_compose_inline);
-#if defined(OS_MACOSX) || defined(OS_WIN) || defined(USE_AURA)
+#if defined(OS_MACOSX) || defined(USE_AURA)
void OnImeCompositionRangeChanged(
const gfx::Range& range,
const std::vector<gfx::Rect>& character_bounds);
diff --git a/content/browser/renderer_host/render_widget_host_unittest.cc b/content/browser/renderer_host/render_widget_host_unittest.cc
index 979cc66..4dc6d24 100644
--- a/content/browser/renderer_host/render_widget_host_unittest.cc
+++ b/content/browser/renderer_host/render_widget_host_unittest.cc
@@ -39,7 +39,7 @@
#include "ui/compositor/test/in_process_context_factory.h"
#endif
-#if defined(OS_WIN) || defined(USE_AURA)
+#if defined(USE_AURA)
#include "content/browser/renderer_host/ui_events_helper.h"
#include "ui/events/event.h"
#endif
diff --git a/content/common/view_messages.h b/content/common/view_messages.h
index f28821c..34ea98c 100644
--- a/content/common/view_messages.h
+++ b/content/common/view_messages.h
@@ -1867,8 +1867,8 @@ IPC_MESSAGE_CONTROL1(ViewHostMsg_FreeTransportDIB,
TransportDIB::Id /* DIB id */)
#endif
-#if defined(OS_MACOSX) || defined(OS_WIN) || defined(USE_AURA)
-// On MACOSX, WIN and AURA IME can request composition character bounds
+#if defined(OS_MACOSX) || defined(USE_AURA)
+// On Mac and Aura IME can request composition character bounds
// synchronously (see crbug.com/120597). This IPC message sends the character
// bounds after every composition change to always have correct bound info.
IPC_MESSAGE_ROUTED2(ViewHostMsg_ImeCompositionRangeChanged,
diff --git a/content/port/browser/render_widget_host_view_port.h b/content/port/browser/render_widget_host_view_port.h
index eaebd1a..4620629 100644
--- a/content/port/browser/render_widget_host_view_port.h
+++ b/content/port/browser/render_widget_host_view_port.h
@@ -109,7 +109,7 @@ class CONTENT_EXPORT RenderWidgetHostViewPort : public RenderWidgetHostView,
// Informs that the focused DOM node has changed.
virtual void FocusedNodeChanged(bool is_editable_node) = 0;
-#if defined(OS_MACOSX) || defined(OS_WIN) || defined(USE_AURA)
+#if defined(OS_MACOSX) || defined(USE_AURA)
// Updates the range of the marked text in an IME composition.
virtual void ImeCompositionRangeChanged(
const gfx::Range& range,
diff --git a/content/public/browser/web_contents_view_delegate.h b/content/public/browser/web_contents_view_delegate.h
index c2f00d7..b0e3f62 100644
--- a/content/public/browser/web_contents_view_delegate.h
+++ b/content/public/browser/web_contents_view_delegate.h
@@ -43,7 +43,7 @@ class CONTENT_EXPORT WebContentsViewDelegate {
virtual void ShowContextMenu(RenderFrameHost* render_frame_host,
const ContextMenuParams& params) = 0;
-#if defined(OS_WIN) || defined(USE_AURA)
+#if defined(USE_AURA)
// These methods allow the embedder to intercept WebContentsViewWin's
// implementation of these WebContentsView methods. See the WebContentsView
// interface documentation for more information about these methods.
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index f0d5b59..cf3c5f7 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -406,7 +406,7 @@ void RenderFrameImpl::PepperCancelComposition(
if (instance != render_view_->focused_pepper_plugin())
return;
Send(new ViewHostMsg_ImeCancelComposition(render_view_->GetRoutingID()));;
-#if defined(OS_MACOSX) || defined(OS_WIN) || defined(USE_AURA)
+#if defined(OS_MACOSX) || defined(USE_AURA)
GetRenderWidget()->UpdateCompositionInfo(true);
#endif
}
diff --git a/content/renderer/render_view_browsertest.cc b/content/renderer/render_view_browsertest.cc
index 445b109..856194e 100644
--- a/content/renderer/render_view_browsertest.cc
+++ b/content/renderer/render_view_browsertest.cc
@@ -1801,7 +1801,7 @@ TEST_F(RenderViewImplTest, TestBackForward) {
EXPECT_EQ(1, was_page_b);
}
-#if defined(OS_MACOSX) || defined(OS_WIN) || defined(USE_AURA)
+#if defined(OS_MACOSX) || defined(USE_AURA)
TEST_F(RenderViewImplTest, GetCompositionCharacterBoundsTest) {
#if defined(OS_WIN)
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index bfb88ea..0a5e1809 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -3950,7 +3950,7 @@ void RenderViewImpl::GetSelectionBounds(gfx::Rect* start, gfx::Rect* end) {
RenderWidget::GetSelectionBounds(start, end);
}
-#if defined(OS_MACOSX) || defined(OS_WIN) || defined(USE_AURA)
+#if defined(OS_MACOSX) || defined(USE_AURA)
void RenderViewImpl::GetCompositionCharacterBounds(
std::vector<gfx::Rect>* bounds) {
DCHECK(bounds);
diff --git a/content/renderer/render_view_impl.h b/content/renderer/render_view_impl.h
index 5cc8234..6dd4c5b 100644
--- a/content/renderer/render_view_impl.h
+++ b/content/renderer/render_view_impl.h
@@ -633,7 +633,7 @@ class CONTENT_EXPORT RenderViewImpl
virtual void SetDeviceScaleFactor(float device_scale_factor) OVERRIDE;
virtual ui::TextInputType GetTextInputType() OVERRIDE;
virtual void GetSelectionBounds(gfx::Rect* start, gfx::Rect* end) OVERRIDE;
-#if defined(OS_MACOSX) || defined(OS_WIN) || defined(USE_AURA)
+#if defined(OS_MACOSX) || defined(USE_AURA)
virtual void GetCompositionCharacterBounds(
std::vector<gfx::Rect>* character_bounds) OVERRIDE;
virtual void GetCompositionRange(gfx::Range* range) OVERRIDE;
diff --git a/content/renderer/render_widget.cc b/content/renderer/render_widget.cc
index 3066793..e3ee47b 100644
--- a/content/renderer/render_widget.cc
+++ b/content/renderer/render_widget.cc
@@ -2147,7 +2147,7 @@ void RenderWidget::OnImeSetComposition(
// sure we are in a consistent state.
Send(new ViewHostMsg_ImeCancelComposition(routing_id()));
}
-#if defined(OS_MACOSX) || defined(OS_WIN) || defined(USE_AURA)
+#if defined(OS_MACOSX) || defined(USE_AURA)
UpdateCompositionInfo(true);
#endif
}
@@ -2166,7 +2166,7 @@ void RenderWidget::OnImeConfirmComposition(const base::string16& text,
else
webwidget_->confirmComposition(WebWidget::DoNotKeepSelection);
handling_input_event_ = false;
-#if defined(OS_MACOSX) || defined(OS_WIN) || defined(USE_AURA)
+#if defined(OS_MACOSX) || defined(USE_AURA)
UpdateCompositionInfo(true);
#endif
}
@@ -2507,7 +2507,7 @@ void RenderWidget::UpdateSelectionBounds() {
params.is_anchor_first = webwidget_->isSelectionAnchorFirst();
Send(new ViewHostMsg_SelectionBoundsChanged(routing_id_, params));
}
-#if defined(OS_MACOSX) || defined(OS_WIN) || defined(USE_AURA)
+#if defined(OS_MACOSX) || defined(USE_AURA)
UpdateCompositionInfo(false);
#endif
}
@@ -2562,7 +2562,7 @@ ui::TextInputType RenderWidget::GetTextInputType() {
return ui::TEXT_INPUT_TYPE_NONE;
}
-#if defined(OS_MACOSX) || defined(OS_WIN) || defined(USE_AURA)
+#if defined(OS_MACOSX) || defined(USE_AURA)
void RenderWidget::UpdateCompositionInfo(bool should_update_range) {
gfx::Range range = gfx::Range();
if (should_update_range) {
@@ -2641,7 +2641,7 @@ void RenderWidget::resetInputMethod() {
Send(new ViewHostMsg_ImeCancelComposition(routing_id()));
}
-#if defined(OS_MACOSX) || defined(OS_WIN) || defined(USE_AURA)
+#if defined(OS_MACOSX) || defined(USE_AURA)
UpdateCompositionInfo(true);
#endif
}
diff --git a/content/renderer/render_widget.h b/content/renderer/render_widget.h
index b4b21df5..13574d0 100644
--- a/content/renderer/render_widget.h
+++ b/content/renderer/render_widget.h
@@ -253,7 +253,7 @@ class CONTENT_EXPORT RenderWidget
void UpdateTextInputState(ShowIme show_ime, ChangeSource change_source);
#endif
-#if defined(OS_MACOSX) || defined(OS_WIN) || defined(USE_AURA)
+#if defined(OS_MACOSX) || defined(USE_AURA)
// Checks if the composition range or composition character bounds have been
// changed. If they are changed, the new value will be sent to the browser
// process.
@@ -441,7 +441,7 @@ class CONTENT_EXPORT RenderWidget
virtual ui::TextInputType WebKitToUiTextInputType(
blink::WebTextInputType type);
-#if defined(OS_MACOSX) || defined(OS_WIN) || defined(USE_AURA)
+#if defined(OS_MACOSX) || defined(USE_AURA)
// Override point to obtain that the current composition character bounds.
// In the case of surrogate pairs, the character is treated as two characters:
// the bounds for first character is actual one, and the bounds for second
diff --git a/content/test/test_render_view_host.h b/content/test/test_render_view_host.h
index a761204..3251326 100644
--- a/content/test/test_render_view_host.h
+++ b/content/test/test_render_view_host.h
@@ -105,7 +105,7 @@ class TestRenderWidgetHostView : public RenderWidgetHostViewBase {
ui::TextInputMode input_mode,
bool can_compose_inline) OVERRIDE {}
virtual void ImeCancelComposition() OVERRIDE {}
-#if defined(OS_MACOSX) || defined(OS_WIN) || defined(USE_AURA)
+#if defined(OS_MACOSX) || defined(USE_AURA)
virtual void ImeCompositionRangeChanged(
const gfx::Range& range,
const std::vector<gfx::Rect>& character_bounds) OVERRIDE {}
diff --git a/ui/base/clipboard/clipboard.h b/ui/base/clipboard/clipboard.h
index 2c786a6..2dfaea9 100644
--- a/ui/base/clipboard/clipboard.h
+++ b/ui/base/clipboard/clipboard.h
@@ -89,7 +89,7 @@ class UI_BASE_EXPORT Clipboard : NON_EXPORTED_BASE(public base::ThreadChecker) {
std::string Serialize() const;
static FormatType Deserialize(const std::string& serialization);
-#if defined(OS_WIN) || defined(USE_AURA)
+#if defined(USE_AURA)
// FormatType can be used in a set on some platforms.
bool operator<(const FormatType& other) const;
#endif
diff --git a/ui/base/dragdrop/os_exchange_data.cc b/ui/base/dragdrop/os_exchange_data.cc
index 64c8093..c236a46 100644
--- a/ui/base/dragdrop/os_exchange_data.cc
+++ b/ui/base/dragdrop/os_exchange_data.cc
@@ -108,7 +108,7 @@ bool OSExchangeData::HasAnyFormat(
if ((formats & FILE_CONTENTS) != 0 && provider_->HasFileContents())
return true;
#endif
-#if defined(OS_WIN) || defined(USE_AURA)
+#if defined(USE_AURA)
if ((formats & HTML) != 0 && provider_->HasHtml())
return true;
#endif
@@ -138,7 +138,7 @@ void OSExchangeData::SetDownloadFileInfo(const DownloadFileInfo& download) {
}
#endif
-#if defined(OS_WIN) || defined(USE_AURA)
+#if defined(USE_AURA)
void OSExchangeData::SetHtml(const base::string16& html, const GURL& base_url) {
provider_->SetHtml(html, base_url);
}
diff --git a/ui/base/dragdrop/os_exchange_data.h b/ui/base/dragdrop/os_exchange_data.h
index cbe56e1..539e894 100644
--- a/ui/base/dragdrop/os_exchange_data.h
+++ b/ui/base/dragdrop/os_exchange_data.h
@@ -63,7 +63,7 @@ class UI_BASE_EXPORT OSExchangeData {
#if defined(OS_WIN)
FILE_CONTENTS = 1 << 4,
#endif
-#if defined(OS_WIN) || defined(USE_AURA)
+#if defined(USE_AURA)
HTML = 1 << 5,
#endif
};
@@ -128,7 +128,7 @@ class UI_BASE_EXPORT OSExchangeData {
virtual void SetDownloadFileInfo(const DownloadFileInfo& download) = 0;
#endif
-#if defined(OS_WIN) || defined(USE_AURA)
+#if defined(USE_AURA)
virtual void SetHtml(const base::string16& html, const GURL& base_url) = 0;
virtual bool GetHtml(base::string16* html, GURL* base_url) const = 0;
virtual bool HasHtml() const = 0;
@@ -221,7 +221,7 @@ class UI_BASE_EXPORT OSExchangeData {
void SetDownloadFileInfo(const DownloadFileInfo& download);
#endif
-#if defined(OS_WIN) || defined(USE_AURA)
+#if defined(USE_AURA)
// Adds a snippet of HTML. |html| is just raw html but this sets both
// text/html and CF_HTML.
void SetHtml(const base::string16& html, const GURL& base_url);
diff --git a/ui/gfx/path.h b/ui/gfx/path.h
index 257a65c..b0f0727 100644
--- a/ui/gfx/path.h
+++ b/ui/gfx/path.h
@@ -32,7 +32,7 @@ class GFX_EXPORT Path : public SkPath {
~Path();
-#if defined(USE_AURA) || defined(OS_WIN) || defined(USE_X11)
+#if defined(USE_AURA) || defined(USE_X11)
// Creates a NativeRegion from the path. The caller is responsible for freeing
// resources used by this region. This only supports polygon paths.
NativeRegion CreateNativeRegion() const;