diff options
author | benwells@chromium.org <benwells@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-11-05 22:52:42 +0000 |
---|---|---|
committer | benwells@chromium.org <benwells@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-11-05 22:52:42 +0000 |
commit | 22b7b2cede575642c81042aab307a5afc6a88568 (patch) | |
tree | 0c2709ce63902f6250664e7ed2d856565c9b4fee | |
parent | ae9fafd5dc78e603e6111774cb23fed69ce548b2 (diff) | |
download | chromium_src-22b7b2cede575642c81042aab307a5afc6a88568.zip chromium_src-22b7b2cede575642c81042aab307a5afc6a88568.tar.gz chromium_src-22b7b2cede575642c81042aab307a5afc6a88568.tar.bz2 |
Moved extension and value builder code to extensions component.
This is only used by tests but it has no chrome dependencies, and test
in extensions use it, so it should move down to.
TBR=sky@chromium.org
BUG=162530
Review URL: https://codereview.chromium.org/48643003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233119 0039d316-1c4b-4281-b951-d872f2087c98
45 files changed, 70 insertions, 71 deletions
diff --git a/chrome/browser/autocomplete/shortcuts_provider_unittest.cc b/chrome/browser/autocomplete/shortcuts_provider_unittest.cc index 7a41932..f384750 100644 --- a/chrome/browser/autocomplete/shortcuts_provider_unittest.cc +++ b/chrome/browser/autocomplete/shortcuts_provider_unittest.cc @@ -29,12 +29,12 @@ #include "chrome/browser/history/shortcuts_backend_factory.h" #include "chrome/browser/history/url_database.h" #include "chrome/common/extensions/extension.h" -#include "chrome/common/extensions/extension_builder.h" -#include "chrome/common/extensions/value_builder.h" #include "chrome/common/pref_names.h" #include "chrome/test/base/testing_profile.h" #include "content/public/browser/notification_service.h" #include "content/public/test/test_browser_thread.h" +#include "extensions/common/extension_builder.h" +#include "extensions/common/value_builder.h" #include "testing/gtest/include/gtest/gtest.h" diff --git a/chrome/browser/chromeos/file_manager/file_tasks_unittest.cc b/chrome/browser/chromeos/file_manager/file_tasks_unittest.cc index 0d2612e..ca82f35 100644 --- a/chrome/browser/chromeos/file_manager/file_tasks_unittest.cc +++ b/chrome/browser/chromeos/file_manager/file_tasks_unittest.cc @@ -21,10 +21,10 @@ #include "chrome/browser/extensions/extension_system.h" #include "chrome/browser/extensions/test_extension_system.h" #include "chrome/browser/google_apis/drive_api_parser.h" -#include "chrome/common/extensions/extension_builder.h" #include "chrome/common/pref_names.h" #include "chrome/test/base/testing_profile.h" #include "content/public/test/test_browser_thread_bundle.h" +#include "extensions/common/extension_builder.h" #include "testing/gtest/include/gtest/gtest.h" #include "url/gurl.h" diff --git a/chrome/browser/extensions/active_tab_unittest.cc b/chrome/browser/extensions/active_tab_unittest.cc index d567d0c..67bde7a 100644 --- a/chrome/browser/extensions/active_tab_unittest.cc +++ b/chrome/browser/extensions/active_tab_unittest.cc @@ -14,10 +14,8 @@ #include "chrome/browser/profiles/profile.h" #include "chrome/browser/sessions/session_id.h" #include "chrome/common/extensions/extension.h" -#include "chrome/common/extensions/extension_builder.h" #include "chrome/common/extensions/features/feature_channel.h" #include "chrome/common/extensions/permissions/permissions_data.h" -#include "chrome/common/extensions/value_builder.h" #include "chrome/test/base/chrome_render_view_host_test_harness.h" #include "content/public/browser/browser_thread.h" #include "content/public/browser/navigation_details.h" @@ -28,7 +26,9 @@ #include "content/public/common/frame_navigate_params.h" #include "content/public/common/page_transition_types.h" #include "content/public/test/test_browser_thread.h" +#include "extensions/common/extension_builder.h" #include "extensions/common/features/feature.h" +#include "extensions/common/value_builder.h" using base::DictionaryValue; using base::ListValue; diff --git a/chrome/browser/extensions/activity_log/activity_log_enabled_unittest.cc b/chrome/browser/extensions/activity_log/activity_log_enabled_unittest.cc index 8fcd82a..6ab5281 100644 --- a/chrome/browser/extensions/activity_log/activity_log_enabled_unittest.cc +++ b/chrome/browser/extensions/activity_log/activity_log_enabled_unittest.cc @@ -9,10 +9,10 @@ #include "chrome/browser/extensions/extension_service.h" #include "chrome/browser/extensions/test_extension_system.h" #include "chrome/common/chrome_switches.h" -#include "chrome/common/extensions/extension_builder.h" #include "chrome/common/pref_names.h" #include "chrome/test/base/chrome_render_view_host_test_harness.h" #include "chrome/test/base/testing_profile.h" +#include "extensions/common/extension_builder.h" #if defined OS_CHROMEOS #include "chrome/browser/chromeos/login/user_manager.h" diff --git a/chrome/browser/extensions/activity_log/activity_log_policy_unittest.cc b/chrome/browser/extensions/activity_log/activity_log_policy_unittest.cc index 0d64928..aa4a21f 100644 --- a/chrome/browser/extensions/activity_log/activity_log_policy_unittest.cc +++ b/chrome/browser/extensions/activity_log/activity_log_policy_unittest.cc @@ -7,7 +7,7 @@ #include "chrome/browser/extensions/activity_log/activity_actions.h" #include "chrome/browser/extensions/activity_log/activity_log_policy.h" #include "chrome/browser/extensions/activity_log/web_request_constants.h" -#include "chrome/common/extensions/value_builder.h" +#include "extensions/common/value_builder.h" #include "testing/gtest/include/gtest/gtest.h" namespace extensions { diff --git a/chrome/browser/extensions/activity_log/activity_log_unittest.cc b/chrome/browser/extensions/activity_log/activity_log_unittest.cc index bfb7748..2d11ca5 100644 --- a/chrome/browser/extensions/activity_log/activity_log_unittest.cc +++ b/chrome/browser/extensions/activity_log/activity_log_unittest.cc @@ -17,10 +17,10 @@ #include "chrome/common/chrome_constants.h" #include "chrome/common/chrome_switches.h" #include "chrome/common/extensions/dom_action_types.h" -#include "chrome/common/extensions/extension_builder.h" #include "chrome/test/base/chrome_render_view_host_test_harness.h" #include "chrome/test/base/testing_profile.h" #include "content/public/test/test_browser_thread_bundle.h" +#include "extensions/common/extension_builder.h" #include "sql/statement.h" #include "testing/gtest/include/gtest/gtest.h" diff --git a/chrome/browser/extensions/activity_log/counting_policy_unittest.cc b/chrome/browser/extensions/activity_log/counting_policy_unittest.cc index 59777ab..354d0e6 100644 --- a/chrome/browser/extensions/activity_log/counting_policy_unittest.cc +++ b/chrome/browser/extensions/activity_log/counting_policy_unittest.cc @@ -17,10 +17,10 @@ #include "chrome/browser/extensions/test_extension_system.h" #include "chrome/common/chrome_constants.h" #include "chrome/common/chrome_switches.h" -#include "chrome/common/extensions/extension_builder.h" #include "chrome/test/base/chrome_render_view_host_test_harness.h" #include "chrome/test/base/testing_profile.h" #include "content/public/test/test_browser_thread_bundle.h" +#include "extensions/common/extension_builder.h" #include "sql/statement.h" #include "testing/gtest/include/gtest/gtest.h" diff --git a/chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc b/chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc index 3b96951..ee63755 100644 --- a/chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc +++ b/chrome/browser/extensions/activity_log/fullstream_ui_policy_unittest.cc @@ -16,10 +16,10 @@ #include "chrome/browser/extensions/test_extension_system.h" #include "chrome/common/chrome_constants.h" #include "chrome/common/chrome_switches.h" -#include "chrome/common/extensions/extension_builder.h" #include "chrome/test/base/chrome_render_view_host_test_harness.h" #include "chrome/test/base/testing_profile.h" #include "content/public/test/test_browser_thread_bundle.h" +#include "extensions/common/extension_builder.h" #include "sql/statement.h" #include "testing/gtest/include/gtest/gtest.h" diff --git a/chrome/browser/extensions/api/activity_log_private/activity_log_private_apitest.cc b/chrome/browser/extensions/api/activity_log_private/activity_log_private_apitest.cc index 233565e..4903390 100644 --- a/chrome/browser/extensions/api/activity_log_private/activity_log_private_apitest.cc +++ b/chrome/browser/extensions/api/activity_log_private/activity_log_private_apitest.cc @@ -7,7 +7,7 @@ #include "chrome/browser/extensions/activity_log/activity_log.h" #include "chrome/browser/extensions/extension_apitest.h" #include "chrome/common/chrome_switches.h" -#include "chrome/common/extensions/extension_builder.h" +#include "extensions/common/extension_builder.h" #include "net/dns/mock_host_resolver.h" #include "net/test/embedded_test_server/embedded_test_server.h" #include "net/test/embedded_test_server/http_request.h" diff --git a/chrome/browser/extensions/api/declarative/declarative_rule_unittest.cc b/chrome/browser/extensions/api/declarative/declarative_rule_unittest.cc index fee8401..df30af1 100644 --- a/chrome/browser/extensions/api/declarative/declarative_rule_unittest.cc +++ b/chrome/browser/extensions/api/declarative/declarative_rule_unittest.cc @@ -8,7 +8,7 @@ #include "base/message_loop/message_loop.h" #include "base/test/values_test_util.h" #include "base/values.h" -#include "chrome/common/extensions/extension_builder.h" +#include "extensions/common/extension_builder.h" #include "extensions/common/matcher/url_matcher_constants.h" #include "testing/gmock/include/gmock/gmock.h" #include "testing/gtest/include/gtest/gtest.h" diff --git a/chrome/browser/extensions/api/declarative_content/content_action_unittest.cc b/chrome/browser/extensions/api/declarative_content/content_action_unittest.cc index 47d2a70..6ab843c 100644 --- a/chrome/browser/extensions/api/declarative_content/content_action_unittest.cc +++ b/chrome/browser/extensions/api/declarative_content/content_action_unittest.cc @@ -9,9 +9,9 @@ #include "chrome/browser/extensions/extension_action_manager.h" #include "chrome/browser/extensions/extension_tab_util.h" #include "chrome/browser/extensions/test_extension_environment.h" -#include "chrome/common/extensions/extension_builder.h" #include "chrome/test/base/testing_profile.h" #include "content/public/browser/web_contents.h" +#include "extensions/common/extension_builder.h" #include "testing/gmock/include/gmock/gmock.h" #include "testing/gtest/include/gtest/gtest.h" diff --git a/chrome/browser/extensions/api/omnibox/omnibox_unittest.cc b/chrome/browser/extensions/api/omnibox/omnibox_unittest.cc index 549367f..db22403 100644 --- a/chrome/browser/extensions/api/omnibox/omnibox_unittest.cc +++ b/chrome/browser/extensions/api/omnibox/omnibox_unittest.cc @@ -5,7 +5,7 @@ #include "base/values.h" #include "chrome/browser/extensions/api/omnibox/omnibox_api.h" #include "chrome/common/extensions/api/omnibox.h" -#include "chrome/common/extensions/value_builder.h" +#include "extensions/common/value_builder.h" #include "testing/gtest/include/gtest/gtest.h" #include "testing/platform_test.h" diff --git a/chrome/browser/extensions/api/storage/settings_apitest.cc b/chrome/browser/extensions/api/storage/settings_apitest.cc index c687d6f..00778a8 100644 --- a/chrome/browser/extensions/api/storage/settings_apitest.cc +++ b/chrome/browser/extensions/api/storage/settings_apitest.cc @@ -16,8 +16,8 @@ #include "chrome/browser/extensions/extension_test_message_listener.h" #include "chrome/browser/profiles/profile.h" #include "chrome/browser/ui/browser.h" -#include "chrome/common/extensions/value_builder.h" #include "chrome/test/base/ui_test_utils.h" +#include "extensions/common/value_builder.h" #include "sync/api/sync_change.h" #include "sync/api/sync_change_processor.h" #include "sync/api/sync_error_factory.h" diff --git a/chrome/browser/extensions/api/streams_private/streams_private_manifest_unittest.cc b/chrome/browser/extensions/api/streams_private/streams_private_manifest_unittest.cc index 94d46c7..cb1e252 100644 --- a/chrome/browser/extensions/api/streams_private/streams_private_manifest_unittest.cc +++ b/chrome/browser/extensions/api/streams_private/streams_private_manifest_unittest.cc @@ -3,14 +3,14 @@ // found in the LICENSE file. #include "base/strings/string_number_conversions.h" -#include "chrome/common/extensions/extension_builder.h" #include "chrome/common/extensions/extension_constants.h" #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h" #include "chrome/common/extensions/manifest_url_handler.h" #include "chrome/common/extensions/mime_types_handler.h" -#include "chrome/common/extensions/value_builder.h" #include "extensions/common/error_utils.h" +#include "extensions/common/extension_builder.h" #include "extensions/common/manifest_constants.h" +#include "extensions/common/value_builder.h" #include "testing/gtest/include/gtest/gtest.h" namespace errors = extensions::manifest_errors; diff --git a/chrome/browser/extensions/browser_permissions_policy_delegate_unittest.cc b/chrome/browser/extensions/browser_permissions_policy_delegate_unittest.cc index db5b0e2..7599b7f 100644 --- a/chrome/browser/extensions/browser_permissions_policy_delegate_unittest.cc +++ b/chrome/browser/extensions/browser_permissions_policy_delegate_unittest.cc @@ -5,13 +5,13 @@ #include "chrome/browser/signin/signin_manager.h" #include "chrome/browser/signin/signin_manager_factory.h" #include "chrome/common/extensions/extension.h" -#include "chrome/common/extensions/extension_builder.h" #include "chrome/common/extensions/permissions/permissions_data.h" #include "chrome/test/base/testing_browser_process.h" #include "chrome/test/base/testing_profile.h" #include "chrome/test/base/testing_profile_manager.h" #include "content/public/test/mock_render_process_host.h" #include "content/public/test/test_browser_thread_bundle.h" +#include "extensions/common/extension_builder.h" #include "testing/gtest/include/gtest/gtest.h" namespace extensions { diff --git a/chrome/browser/extensions/extension_context_menu_model_unittest.cc b/chrome/browser/extensions/extension_context_menu_model_unittest.cc index 6abe35c..2ac16fd 100644 --- a/chrome/browser/extensions/extension_context_menu_model_unittest.cc +++ b/chrome/browser/extensions/extension_context_menu_model_unittest.cc @@ -9,10 +9,10 @@ #include "chrome/browser/extensions/test_management_policy.h" #include "chrome/browser/ui/browser.h" #include "chrome/browser/ui/host_desktop.h" -#include "chrome/common/extensions/extension_builder.h" -#include "chrome/common/extensions/value_builder.h" #include "chrome/test/base/test_browser_window.h" #include "chrome/test/base/testing_profile.h" +#include "extensions/common/extension_builder.h" +#include "extensions/common/value_builder.h" #include "testing/gtest/include/gtest/gtest.h" namespace extensions { diff --git a/chrome/browser/extensions/extension_service_unittest.cc b/chrome/browser/extensions/extension_service_unittest.cc index 3d6d94f..9723fdf 100644 --- a/chrome/browser/extensions/extension_service_unittest.cc +++ b/chrome/browser/extensions/extension_service_unittest.cc @@ -75,12 +75,10 @@ #include "chrome/common/extensions/api/plugins/plugins_handler.h" #include "chrome/common/extensions/background_info.h" #include "chrome/common/extensions/extension.h" -#include "chrome/common/extensions/extension_builder.h" #include "chrome/common/extensions/extension_l10n_util.h" #include "chrome/common/extensions/manifest_handlers/app_launch_info.h" #include "chrome/common/extensions/manifest_handlers/content_scripts_handler.h" #include "chrome/common/extensions/manifest_url_handler.h" -#include "chrome/common/extensions/value_builder.h" #include "chrome/common/pref_names.h" #include "chrome/common/url_constants.h" #include "chrome/test/base/scoped_browser_locale.h" @@ -97,10 +95,12 @@ #include "content/public/common/content_constants.h" #include "content/public/test/test_utils.h" #include "extensions/common/constants.h" +#include "extensions/common/extension_builder.h" #include "extensions/common/extension_resource.h" #include "extensions/common/manifest_constants.h" #include "extensions/common/permissions/permission_set.h" #include "extensions/common/url_pattern.h" +#include "extensions/common/value_builder.h" #include "gpu/config/gpu_info.h" #include "grit/browser_resources.h" #include "net/cookies/canonical_cookie.h" diff --git a/chrome/browser/extensions/page_action_controller_unittest.cc b/chrome/browser/extensions/page_action_controller_unittest.cc index ed35108..7b8cddc 100644 --- a/chrome/browser/extensions/page_action_controller_unittest.cc +++ b/chrome/browser/extensions/page_action_controller_unittest.cc @@ -15,12 +15,12 @@ #include "chrome/browser/extensions/test_extension_system.h" #include "chrome/browser/sessions/session_id.h" #include "chrome/common/extensions/extension.h" -#include "chrome/common/extensions/extension_builder.h" -#include "chrome/common/extensions/value_builder.h" #include "chrome/test/base/chrome_render_view_host_test_harness.h" #include "chrome/test/base/testing_profile.h" #include "content/public/browser/browser_thread.h" #include "content/public/test/test_browser_thread.h" +#include "extensions/common/extension_builder.h" +#include "extensions/common/value_builder.h" #if defined(OS_CHROMEOS) #include "chrome/browser/chromeos/login/user_manager.h" diff --git a/chrome/browser/extensions/script_badge_controller_unittest.cc b/chrome/browser/extensions/script_badge_controller_unittest.cc index 585fe2a..d02cbe6 100644 --- a/chrome/browser/extensions/script_badge_controller_unittest.cc +++ b/chrome/browser/extensions/script_badge_controller_unittest.cc @@ -17,10 +17,8 @@ #include "chrome/common/chrome_switches.h" #include "chrome/common/chrome_version_info.h" #include "chrome/common/extensions/extension.h" -#include "chrome/common/extensions/extension_builder.h" #include "chrome/common/extensions/feature_switch.h" #include "chrome/common/extensions/features/feature_channel.h" -#include "chrome/common/extensions/value_builder.h" #include "chrome/test/base/chrome_render_view_host_test_harness.h" #include "chrome/test/base/testing_profile.h" #include "content/public/browser/browser_thread.h" @@ -29,6 +27,8 @@ #include "content/public/browser/notification_source.h" #include "content/public/browser/web_contents.h" #include "content/public/test/test_browser_thread.h" +#include "extensions/common/extension_builder.h" +#include "extensions/common/value_builder.h" #include "testing/gmock/include/gmock/gmock.h" #if defined(OS_CHROMEOS) diff --git a/chrome/browser/extensions/script_bubble_controller_unittest.cc b/chrome/browser/extensions/script_bubble_controller_unittest.cc index c53dac5..566fff2 100644 --- a/chrome/browser/extensions/script_bubble_controller_unittest.cc +++ b/chrome/browser/extensions/script_bubble_controller_unittest.cc @@ -16,14 +16,14 @@ #include "chrome/browser/extensions/script_bubble_controller.h" #include "chrome/browser/extensions/test_extension_system.h" #include "chrome/common/extensions/extension.h" -#include "chrome/common/extensions/extension_builder.h" #include "chrome/common/extensions/feature_switch.h" -#include "chrome/common/extensions/value_builder.h" #include "chrome/test/base/chrome_render_view_host_test_harness.h" #include "chrome/test/base/testing_profile.h" #include "content/public/browser/browser_thread.h" #include "content/public/browser/navigation_entry.h" #include "content/public/test/test_browser_thread.h" +#include "extensions/common/extension_builder.h" +#include "extensions/common/value_builder.h" #if defined(OS_CHROMEOS) #include "chrome/browser/chromeos/login/user_manager.h" diff --git a/chrome/browser/extensions/test_extension_environment.cc b/chrome/browser/extensions/test_extension_environment.cc index 9ebb3d5..e501156 100644 --- a/chrome/browser/extensions/test_extension_environment.cc +++ b/chrome/browser/extensions/test_extension_environment.cc @@ -12,10 +12,10 @@ #include "chrome/browser/extensions/test_extension_system.h" #include "chrome/browser/sessions/session_tab_helper.h" #include "chrome/common/extensions/extension.h" -#include "chrome/common/extensions/extension_builder.h" -#include "chrome/common/extensions/value_builder.h" #include "chrome/test/base/testing_profile.h" #include "content/public/test/web_contents_tester.h" +#include "extensions/common/extension_builder.h" +#include "extensions/common/value_builder.h" #include "testing/gtest/include/gtest/gtest.h" #if defined(USE_AURA) diff --git a/chrome/browser/extensions/webstore_startup_installer_browsertest.cc b/chrome/browser/extensions/webstore_startup_installer_browsertest.cc index 0451bbc..9a705c8 100644 --- a/chrome/browser/extensions/webstore_startup_installer_browsertest.cc +++ b/chrome/browser/extensions/webstore_startup_installer_browsertest.cc @@ -17,8 +17,6 @@ #include "chrome/browser/ui/browser.h" #include "chrome/browser/ui/tabs/tab_strip_model.h" #include "chrome/common/chrome_switches.h" -#include "chrome/common/extensions/extension_builder.h" -#include "chrome/common/extensions/value_builder.h" #include "chrome/common/pref_names.h" #include "chrome/test/base/in_process_browser_test.h" #include "chrome/test/base/test_switches.h" @@ -28,6 +26,8 @@ #include "content/public/browser/notification_types.h" #include "content/public/browser/web_contents.h" #include "content/public/test/browser_test_utils.h" +#include "extensions/common/extension_builder.h" +#include "extensions/common/value_builder.h" #include "net/dns/mock_host_resolver.h" #include "url/gurl.h" diff --git a/chrome/browser/managed_mode/managed_user_service_unittest.cc b/chrome/browser/managed_mode/managed_user_service_unittest.cc index 804978e..fa0f062 100644 --- a/chrome/browser/managed_mode/managed_user_service_unittest.cc +++ b/chrome/browser/managed_mode/managed_user_service_unittest.cc @@ -17,12 +17,12 @@ #include "chrome/browser/ui/browser_list.h" #include "chrome/common/chrome_paths.h" #include "chrome/common/extensions/extension.h" -#include "chrome/common/extensions/extension_builder.h" #include "chrome/common/extensions/features/feature_channel.h" #include "chrome/common/pref_names.h" #include "chrome/test/base/testing_profile.h" #include "content/public/test/test_browser_thread_bundle.h" #include "content/public/test/test_utils.h" +#include "extensions/common/extension_builder.h" #include "extensions/common/manifest_constants.h" #include "testing/gtest/include/gtest/gtest.h" diff --git a/chrome/browser/sync_file_system/drive_backend_v1/drive_file_sync_service_fake_unittest.cc b/chrome/browser/sync_file_system/drive_backend_v1/drive_file_sync_service_fake_unittest.cc index 984c193..289f983 100644 --- a/chrome/browser/sync_file_system/drive_backend_v1/drive_file_sync_service_fake_unittest.cc +++ b/chrome/browser/sync_file_system/drive_backend_v1/drive_file_sync_service_fake_unittest.cc @@ -29,9 +29,9 @@ #include "chrome/browser/sync_file_system/sync_file_system.pb.h" #include "chrome/browser/sync_file_system/syncable_file_system_util.h" #include "chrome/common/extensions/extension.h" -#include "chrome/common/extensions/extension_builder.h" #include "chrome/test/base/testing_profile.h" #include "content/public/test/test_browser_thread_bundle.h" +#include "extensions/common/extension_builder.h" #include "extensions/common/id_util.h" #include "testing/gmock/include/gmock/gmock.h" #include "testing/gtest/include/gtest/gtest.h" diff --git a/chrome/browser/ui/webui/performance_monitor/performance_monitor_handler.cc b/chrome/browser/ui/webui/performance_monitor/performance_monitor_handler.cc index f8ef27c..77b657d 100644 --- a/chrome/browser/ui/webui/performance_monitor/performance_monitor_handler.cc +++ b/chrome/browser/ui/webui/performance_monitor/performance_monitor_handler.cc @@ -18,9 +18,9 @@ #include "chrome/browser/ui/webui/performance_monitor/performance_monitor_ui_constants.h" #include "chrome/browser/ui/webui/performance_monitor/performance_monitor_ui_util.h" #include "chrome/common/chrome_switches.h" -#include "chrome/common/extensions/value_builder.h" #include "content/public/browser/browser_thread.h" #include "content/public/browser/web_ui.h" +#include "extensions/common/value_builder.h" using content::BrowserThread; diff --git a/chrome/browser/value_store/value_store_change_unittest.cc b/chrome/browser/value_store/value_store_change_unittest.cc index f97be03..21a6de6 100644 --- a/chrome/browser/value_store/value_store_change_unittest.cc +++ b/chrome/browser/value_store/value_store_change_unittest.cc @@ -9,7 +9,7 @@ #include "base/logging.h" #include "base/values.h" #include "chrome/browser/value_store/value_store_change.h" -#include "chrome/common/extensions/value_builder.h" +#include "extensions/common/value_builder.h" using base::DictionaryValue; using base::Value; diff --git a/chrome/chrome_tests_unit.gypi b/chrome/chrome_tests_unit.gypi index c7b35f9..4a6f166 100644 --- a/chrome/chrome_tests_unit.gypi +++ b/chrome/chrome_tests_unit.gypi @@ -39,6 +39,10 @@ '..', ], 'sources': [ + '../extensions/common/extension_builder.cc', + '../extensions/common/extension_builder.h', + '../extensions/common/value_builder.cc', + '../extensions/common/value_builder.h', 'app/chrome_main_delegate.cc', 'app/chrome_main_delegate.h', 'browser/android/mock_google_location_settings_helper.cc', @@ -199,12 +203,8 @@ 'browser/ui/test/test_confirm_bubble_model.cc', 'browser/ui/test/test_confirm_bubble_model.h', 'browser/ui/views/find_bar_host_unittest_util_views.cc', - 'common/extensions/extension_builder.cc', - 'common/extensions/extension_builder.h', 'common/extensions/extension_test_util.cc', 'common/extensions/extension_test_util.h', - 'common/extensions/value_builder.cc', - 'common/extensions/value_builder.h', 'renderer/chrome_mock_render_thread.cc', 'renderer/chrome_mock_render_thread.h', 'renderer/mock_printer.cc', diff --git a/chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc b/chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc index aed9215..78aa046 100644 --- a/chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc +++ b/chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc @@ -3,12 +3,12 @@ // found in the LICENSE file. #include "chrome/common/extensions/api/extension_action/action_info.h" -#include "chrome/common/extensions/extension_builder.h" #include "chrome/common/extensions/extension_icon_set.h" #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h" -#include "chrome/common/extensions/value_builder.h" #include "extensions/common/error_utils.h" +#include "extensions/common/extension_builder.h" #include "extensions/common/manifest_constants.h" +#include "extensions/common/value_builder.h" #include "testing/gtest/include/gtest/gtest.h" namespace extensions { diff --git a/chrome/common/extensions/api/extension_action/script_badge_manifest_unittest.cc b/chrome/common/extensions/api/extension_action/script_badge_manifest_unittest.cc index cd9de1b..762675f 100644 --- a/chrome/common/extensions/api/extension_action/script_badge_manifest_unittest.cc +++ b/chrome/common/extensions/api/extension_action/script_badge_manifest_unittest.cc @@ -3,11 +3,11 @@ // found in the LICENSE file. #include "chrome/common/extensions/api/extension_action/action_info.h" -#include "chrome/common/extensions/extension_builder.h" #include "chrome/common/extensions/extension_constants.h" #include "chrome/common/extensions/extension_icon_set.h" #include "chrome/common/extensions/feature_switch.h" #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h" +#include "extensions/common/extension_builder.h" #include "extensions/common/install_warning.h" #include "extensions/common/manifest_constants.h" #include "extensions/common/manifest_constants.h" diff --git a/chrome/common/extensions/api/extension_api_unittest.cc b/chrome/common/extensions/api/extension_api_unittest.cc index a481d9d..32ab0af 100644 --- a/chrome/common/extensions/api/extension_api_unittest.cc +++ b/chrome/common/extensions/api/extension_api_unittest.cc @@ -18,14 +18,14 @@ #include "base/values.h" #include "chrome/common/chrome_paths.h" #include "chrome/common/extensions/extension.h" -#include "chrome/common/extensions/extension_builder.h" #include "chrome/common/extensions/extension_test_util.h" #include "chrome/common/extensions/features/api_feature.h" #include "chrome/common/extensions/features/base_feature_provider.h" #include "chrome/common/extensions/features/simple_feature.h" -#include "chrome/common/extensions/value_builder.h" +#include "extensions/common/extension_builder.h" #include "extensions/common/manifest.h" #include "extensions/common/manifest_constants.h" +#include "extensions/common/value_builder.h" #include "testing/gtest/include/gtest/gtest.h" namespace extensions { diff --git a/chrome/common/extensions/api/file_browser_handlers/file_browser_handler_manifest_unittest.cc b/chrome/common/extensions/api/file_browser_handlers/file_browser_handler_manifest_unittest.cc index 797a11f..16e669e 100644 --- a/chrome/common/extensions/api/file_browser_handlers/file_browser_handler_manifest_unittest.cc +++ b/chrome/common/extensions/api/file_browser_handlers/file_browser_handler_manifest_unittest.cc @@ -4,12 +4,12 @@ #include "base/strings/string_number_conversions.h" #include "chrome/common/extensions/api/file_browser_handlers/file_browser_handler.h" -#include "chrome/common/extensions/extension_builder.h" #include "chrome/common/extensions/extension_constants.h" #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h" -#include "chrome/common/extensions/value_builder.h" #include "extensions/common/error_utils.h" +#include "extensions/common/extension_builder.h" #include "extensions/common/manifest_constants.h" +#include "extensions/common/value_builder.h" #include "testing/gtest/include/gtest/gtest.h" namespace errors = extensions::manifest_errors; diff --git a/chrome/common/extensions/extension_test_util.cc b/chrome/common/extensions/extension_test_util.cc index a4e66fb..2af3e0a 100644 --- a/chrome/common/extensions/extension_test_util.cc +++ b/chrome/common/extensions/extension_test_util.cc @@ -10,7 +10,7 @@ #include "base/values.h" #include "chrome/common/chrome_paths.h" #include "chrome/common/extensions/extension.h" -#include "chrome/common/extensions/extension_builder.h" +#include "extensions/common/extension_builder.h" #include "extensions/common/manifest_constants.h" #include "testing/gtest/include/gtest/gtest.h" diff --git a/chrome/common/extensions/extension_test_util.h b/chrome/common/extensions/extension_test_util.h index f6cdc1a..5509185 100644 --- a/chrome/common/extensions/extension_test_util.h +++ b/chrome/common/extensions/extension_test_util.h @@ -8,7 +8,7 @@ #include <string> #include "base/memory/ref_counted.h" -#include "chrome/common/extensions/extension_builder.h" +#include "extensions/common/extension_builder.h" #include "extensions/common/manifest.h" namespace extensions { diff --git a/chrome/common/extensions/features/base_feature_provider_unittest.cc b/chrome/common/extensions/features/base_feature_provider_unittest.cc index d31d3de..d21e3a2 100644 --- a/chrome/common/extensions/features/base_feature_provider_unittest.cc +++ b/chrome/common/extensions/features/base_feature_provider_unittest.cc @@ -6,7 +6,7 @@ #include "chrome/common/extensions/features/feature_channel.h" #include "chrome/common/extensions/features/permission_feature.h" -#include "chrome/common/extensions/value_builder.h" +#include "extensions/common/value_builder.h" #include "testing/gtest/include/gtest/gtest.h" using chrome::VersionInfo; diff --git a/chrome/common/extensions/features/complex_feature_unittest.cc b/chrome/common/extensions/features/complex_feature_unittest.cc index 51f26f6..38f9735 100644 --- a/chrome/common/extensions/features/complex_feature_unittest.cc +++ b/chrome/common/extensions/features/complex_feature_unittest.cc @@ -6,7 +6,7 @@ #include "chrome/common/extensions/features/feature_channel.h" #include "chrome/common/extensions/features/simple_feature.h" -#include "chrome/common/extensions/value_builder.h" +#include "extensions/common/value_builder.h" #include "testing/gtest/include/gtest/gtest.h" using chrome::VersionInfo; diff --git a/chrome/common/extensions/features/simple_feature_unittest.cc b/chrome/common/extensions/features/simple_feature_unittest.cc index d4f4c0a..02a2361 100644 --- a/chrome/common/extensions/features/simple_feature_unittest.cc +++ b/chrome/common/extensions/features/simple_feature_unittest.cc @@ -5,7 +5,7 @@ #include "chrome/common/extensions/features/simple_feature.h" #include "chrome/common/extensions/features/feature_channel.h" -#include "chrome/common/extensions/value_builder.h" +#include "extensions/common/value_builder.h" #include "testing/gtest/include/gtest/gtest.h" using chrome::VersionInfo; diff --git a/chrome/common/extensions/manifest_handler_unittest.cc b/chrome/common/extensions/manifest_handler_unittest.cc index 74b8698..88e7594 100644 --- a/chrome/common/extensions/manifest_handler_unittest.cc +++ b/chrome/common/extensions/manifest_handler_unittest.cc @@ -10,10 +10,10 @@ #include "base/stl_util.h" #include "base/strings/utf_string_conversions.h" #include "chrome/common/extensions/extension.h" -#include "chrome/common/extensions/extension_builder.h" #include "chrome/common/extensions/manifest_handler.h" -#include "chrome/common/extensions/value_builder.h" +#include "extensions/common/extension_builder.h" #include "extensions/common/install_warning.h" +#include "extensions/common/value_builder.h" #include "testing/gtest/include/gtest/gtest.h" namespace extensions { diff --git a/chrome/renderer/chrome_content_renderer_client_unittest.cc b/chrome/renderer/chrome_content_renderer_client_unittest.cc index 421f9ac..a353ed5 100644 --- a/chrome/renderer/chrome_content_renderer_client_unittest.cc +++ b/chrome/renderer/chrome_content_renderer_client_unittest.cc @@ -8,9 +8,9 @@ #include "base/strings/utf_string_conversions.h" #include "chrome/common/extensions/extension.h" -#include "chrome/common/extensions/extension_builder.h" #include "chrome/renderer/searchbox/search_bouncer.h" #include "content/public/common/webplugininfo.h" +#include "extensions/common/extension_builder.h" #include "extensions/common/manifest_constants.h" #include "testing/gtest/include/gtest/gtest.h" #include "third_party/WebKit/public/platform/WebString.h" diff --git a/chrome/renderer/extensions/renderer_permissions_policy_delegate_unittest.cc b/chrome/renderer/extensions/renderer_permissions_policy_delegate_unittest.cc index 80825af..653a5a5 100644 --- a/chrome/renderer/extensions/renderer_permissions_policy_delegate_unittest.cc +++ b/chrome/renderer/extensions/renderer_permissions_policy_delegate_unittest.cc @@ -5,7 +5,6 @@ #include "base/command_line.h" #include "chrome/common/chrome_switches.h" #include "chrome/common/extensions/extension.h" -#include "chrome/common/extensions/extension_builder.h" #include "chrome/common/extensions/extension_constants.h" #include "chrome/common/extensions/extension_messages.h" #include "chrome/common/extensions/permissions/permissions_data.h" @@ -13,6 +12,7 @@ #include "chrome/renderer/extensions/renderer_permissions_policy_delegate.h" #include "content/public/test/mock_render_process_host.h" #include "content/public/test/mock_render_thread.h" +#include "extensions/common/extension_builder.h" #include "testing/gtest/include/gtest/gtest.h" namespace extensions { diff --git a/extensions/browser/DEPS b/extensions/browser/DEPS index 3c1ac11..737b8eb 100644 --- a/extensions/browser/DEPS +++ b/extensions/browser/DEPS @@ -24,7 +24,6 @@ specific_include_rules = { # TODO(jamescook): Remove these. http://crbug.com/159366 "+chrome/browser/extensions/extension_service_unittest.h", "+chrome/browser/extensions/test_extension_system.h", - "+chrome/common/extensions/extension_builder.h", "+chrome/test/base/testing_profile.h", ] } diff --git a/extensions/browser/lazy_background_task_queue_unittest.cc b/extensions/browser/lazy_background_task_queue_unittest.cc index da2e5bc..e355cac 100644 --- a/extensions/browser/lazy_background_task_queue_unittest.cc +++ b/extensions/browser/lazy_background_task_queue_unittest.cc @@ -10,9 +10,9 @@ #include "chrome/browser/extensions/extension_service_unittest.h" #include "chrome/browser/extensions/test_extension_system.h" #include "chrome/common/extensions/extension.h" -#include "chrome/common/extensions/extension_builder.h" #include "chrome/test/base/testing_profile.h" #include "content/public/test/test_browser_thread_bundle.h" +#include "extensions/common/extension_builder.h" #include "testing/gtest/include/gtest/gtest.h" namespace extensions { diff --git a/chrome/common/extensions/extension_builder.cc b/extensions/common/extension_builder.cc index c7786f8..ef5a14f 100644 --- a/chrome/common/extensions/extension_builder.cc +++ b/extensions/common/extension_builder.cc @@ -1,8 +1,8 @@ -// Copyright (c) 2012 The Chromium Authors. All rights reserved. +// Copyright 2013 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "chrome/common/extensions/extension_builder.h" +#include "extensions/common/extension_builder.h" #include "chrome/common/extensions/extension.h" diff --git a/chrome/common/extensions/extension_builder.h b/extensions/common/extension_builder.h index 4b4669d..afb7f88 100644 --- a/chrome/common/extensions/extension_builder.h +++ b/extensions/common/extension_builder.h @@ -1,15 +1,15 @@ -// Copyright (c) 2012 The Chromium Authors. All rights reserved. +// Copyright 2013 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#ifndef CHROME_COMMON_EXTENSIONS_EXTENSION_BUILDER_H_ -#define CHROME_COMMON_EXTENSIONS_EXTENSION_BUILDER_H_ +#ifndef EXTENSIONS_COMMON_EXTENSION_BUILDER_H_ +#define EXTENSIONS_COMMON_EXTENSION_BUILDER_H_ #include "base/files/file_path.h" #include "base/memory/ref_counted.h" #include "base/memory/scoped_ptr.h" -#include "chrome/common/extensions/value_builder.h" #include "extensions/common/manifest.h" +#include "extensions/common/value_builder.h" namespace extensions { class Extension; @@ -60,4 +60,4 @@ class ExtensionBuilder { } // namespace extensions -#endif // CHROME_COMMON_EXTENSIONS_EXTENSION_BUILDER_H_ +#endif // EXTENSIONS_COMMON_EXTENSION_BUILDER_H_ diff --git a/chrome/common/extensions/value_builder.cc b/extensions/common/value_builder.cc index 1fd6794..c32679e 100644 --- a/chrome/common/extensions/value_builder.cc +++ b/extensions/common/value_builder.cc @@ -1,8 +1,8 @@ -// Copyright (c) 2012 The Chromium Authors. All rights reserved. +// Copyright 2013 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "chrome/common/extensions/value_builder.h" +#include "extensions/common/value_builder.h" namespace extensions { diff --git a/chrome/common/extensions/value_builder.h b/extensions/common/value_builder.h index db272c5..77b0d73 100644 --- a/chrome/common/extensions/value_builder.h +++ b/extensions/common/value_builder.h @@ -1,4 +1,4 @@ -// Copyright (c) 2012 The Chromium Authors. All rights reserved. +// Copyright 2013 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -30,8 +30,8 @@ // anywhere, so the use of non-const reference parameters is likely to cause // less confusion than usual. -#ifndef CHROME_COMMON_EXTENSIONS_VALUE_BUILDER_H_ -#define CHROME_COMMON_EXTENSIONS_VALUE_BUILDER_H_ +#ifndef EXTENSIONS_COMMON_VALUE_BUILDER_H_ +#define EXTENSIONS_COMMON_VALUE_BUILDER_H_ #include <string> @@ -101,4 +101,4 @@ class ListBuilder { } // namespace extensions -#endif // CHROME_COMMON_EXTENSIONS_VALUE_BUILDER_H_ +#endif // EXTENSIONS_COMMON_VALUE_BUILDER_H_ |