diff options
author | Will Harris <wfh@chromium.org> | 2014-08-25 18:15:49 -0700 |
---|---|---|
committer | Will Harris <wfh@chromium.org> | 2014-08-26 01:19:12 +0000 |
commit | 89d70b374cface22437e7c20a5affa87df84f50e (patch) | |
tree | 0d01caf1d1ab56c73edd29b6d4e368c92af03a64 | |
parent | d2cf86ed0f128da928a38acc8ea9abcc087f8728 (diff) | |
download | chromium_src-89d70b374cface22437e7c20a5affa87df84f50e.zip chromium_src-89d70b374cface22437e7c20a5affa87df84f50e.tar.gz chromium_src-89d70b374cface22437e7c20a5affa87df84f50e.tar.bz2 |
Make 64-bit Chrome stable report as CHANNEL_STABLE
BUG=407204
TEST=installer_util_unittests
TEST=install x64 stable. Check chrome://chrome shows 'm' and not 'unknown-m'.
Review URL: https://codereview.chromium.org/467303004
Cr-Commit-Position: refs/heads/master@{#291791}
(cherry picked from commit 7ebc2c47bb7683224f8978f21f83fba4e1851ab0)
Review URL: https://codereview.chromium.org/503223002
Cr-Commit-Position: refs/branch-heads/2062@{#576}
Cr-Branched-From: 2e531f7c26d0d9e2aa0cced17a35eea6687dc58c-refs/heads/master@{#278856}
-rw-r--r-- | chrome/installer/util/channel_info.cc | 9 | ||||
-rw-r--r-- | chrome/installer/util/channel_info_unittest.cc | 10 | ||||
-rw-r--r-- | chrome/installer/util/util_constants.cc | 1 | ||||
-rw-r--r-- | chrome/installer/util/util_constants.h | 1 |
4 files changed, 19 insertions, 2 deletions
diff --git a/chrome/installer/util/channel_info.cc b/chrome/installer/util/channel_info.cc index 48a4e32..cdf264b 100644 --- a/chrome/installer/util/channel_info.cc +++ b/chrome/installer/util/channel_info.cc @@ -27,7 +27,8 @@ const wchar_t kSfxMultiFail[] = L"-multifail"; const wchar_t* const kChannels[] = { installer::kChromeChannelBeta, - installer::kChromeChannelDev + installer::kChromeChannelDev, + installer::kChromeChannelStableExplicit }; const wchar_t* const kModifiers[] = { @@ -168,7 +169,11 @@ bool ChannelInfo::GetChannelName(std::wstring* channel_name) const { *const* end = &kChannels[arraysize(kChannels)]; scan != end; ++scan) { if (value_.find(*scan) != std::wstring::npos) { - channel_name->assign(*scan); + // Report channels with "stable" in them as stable (empty string). + if (*scan == installer::kChromeChannelStableExplicit) + channel_name->erase(); + else + channel_name->assign(*scan); return true; } } diff --git a/chrome/installer/util/channel_info_unittest.cc b/chrome/installer/util/channel_info_unittest.cc index d08f2c3..71d908b 100644 --- a/chrome/installer/util/channel_info_unittest.cc +++ b/chrome/installer/util/channel_info_unittest.cc @@ -50,6 +50,16 @@ TEST(ChannelInfoTest, Channels) { EXPECT_TRUE(ci.GetChannelName(&channel)); EXPECT_EQ(kChannelDev, channel); + ci.set_value(L"x64-dev"); + EXPECT_TRUE(ci.GetChannelName(&channel)); + EXPECT_EQ(kChannelDev, channel); + ci.set_value(L"x64-beta"); + EXPECT_TRUE(ci.GetChannelName(&channel)); + EXPECT_EQ(kChannelBeta, channel); + ci.set_value(L"x64-stable"); + EXPECT_TRUE(ci.GetChannelName(&channel)); + EXPECT_EQ(kChannelStable, channel); + ci.set_value(L"fuzzy"); EXPECT_FALSE(ci.GetChannelName(&channel)); } diff --git a/chrome/installer/util/util_constants.cc b/chrome/installer/util/util_constants.cc index 8800c5c..dc7c720 100644 --- a/chrome/installer/util/util_constants.cc +++ b/chrome/installer/util/util_constants.cc @@ -262,6 +262,7 @@ const wchar_t kChromeChannelCanary[] = L"canary"; const wchar_t kChromeChannelDev[] = L"dev"; const wchar_t kChromeChannelBeta[] = L"beta"; const wchar_t kChromeChannelStable[] = L""; +const wchar_t kChromeChannelStableExplicit[] = L"stable"; const size_t kMaxAppModelIdLength = 64U; diff --git a/chrome/installer/util/util_constants.h b/chrome/installer/util/util_constants.h index d2f648a..e4d5f77 100644 --- a/chrome/installer/util/util_constants.h +++ b/chrome/installer/util/util_constants.h @@ -255,6 +255,7 @@ extern const wchar_t kChromeChannelCanary[]; extern const wchar_t kChromeChannelDev[]; extern const wchar_t kChromeChannelBeta[]; extern const wchar_t kChromeChannelStable[]; +extern const wchar_t kChromeChannelStableExplicit[]; extern const size_t kMaxAppModelIdLength; |