summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorrouslan@chromium.org <rouslan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-01-02 23:29:14 +0000
committerrouslan@chromium.org <rouslan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-01-02 23:29:14 +0000
commit28f6dcfde7db47843d1a7ea07c36dc95f8344ca1 (patch)
treea3b28adc6255aa77257c75109dddc183962e8744
parent0aeaf696516690c6c0e0b49c1ca51bfb1a4dc842 (diff)
downloadchromium_src-28f6dcfde7db47843d1a7ea07c36dc95f8344ca1.zip
chromium_src-28f6dcfde7db47843d1a7ea07c36dc95f8344ca1.tar.gz
chromium_src-28f6dcfde7db47843d1a7ea07c36dc95f8344ca1.tar.bz2
[spell] Always prompt user when enabling online spellchecker.
When the user enables "Use a web service to help resolve spelling errors" option on the settings page, Chrome should confirm the user choice every time. The patch accomplishes this by passing an undefined "confirmed_pref" to ConfirmDialog constructor. From the documentation of this dialog: confirmed_pref: A pref used to remember whether the user has confirmed the dialog before. This ensures that the user is presented with the dialog only once. If left |undefined| or |null|, the dialog will pop up every time the user attempts to set |pref| to |true|. BUG=331291 Review URL: https://codereview.chromium.org/123273003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242837 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--chrome/browser/resources/options/options.js3
1 files changed, 1 insertions, 2 deletions
diff --git a/chrome/browser/resources/options/options.js b/chrome/browser/resources/options/options.js
index e3a1f7f..1aeb352 100644
--- a/chrome/browser/resources/options/options.js
+++ b/chrome/browser/resources/options/options.js
@@ -101,8 +101,7 @@ function load() {
$('spelling-confirm-ok'),
$('spelling-confirm-cancel'),
$('spelling-enabled-control').pref,
- $('spelling-enabled-control').metric,
- 'spellcheck.confirm_dialog_shown'),
+ $('spelling-enabled-control').metric),
BrowserOptions.getInstance());
}
OptionsPage.registerOverlay(ContentSettings.getInstance(),