diff options
| author | kerz@chromium.org <kerz@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-08-07 19:46:50 +0000 |
|---|---|---|
| committer | kerz@chromium.org <kerz@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-08-07 19:46:50 +0000 |
| commit | 337a251ff1a4f9c90084aa34b0909c3f8919e546 (patch) | |
| tree | 79735e88d35ce5947fd08dd261179c4793eec61d | |
| parent | f9bb671289f5334b8ee7e9d28ce519d36bb33a53 (diff) | |
| download | chromium_src-337a251ff1a4f9c90084aa34b0909c3f8919e546.zip chromium_src-337a251ff1a4f9c90084aa34b0909c3f8919e546.tar.gz chromium_src-337a251ff1a4f9c90084aa34b0909c3f8919e546.tar.bz2 | |
Revert 287878 "Merge 287864 "Fix widget visibility accounting wh..."
> Merge 287864 "Fix widget visibility accounting when crashing in ..."
>
> > Fix widget visibility accounting when crashing in background.
> >
> > RenderWidgetHostImpl tracks its visibility using the |is_hidden_| field.
> > This value should be not be reset when the renderer crashes, otherwise a
> > widget that crashes in backround will think it's already visible when
> > put in foreground, messing up process visibility accounting.
> >
> > This patch fixes process visibility for processes that crashed in
> > background and are respawned upon foregrounding by preserving the
> > |is_hidden_| field through renderer crashes.
> >
> > BUG=399521
> > R=aelias@chromium.org
> >
> > Review URL: https://codereview.chromium.org/443133002
>
> TBR=ppi@chromium.org
>
> Review URL: https://codereview.chromium.org/447943002
TBR=aelias@chromium.org
Review URL: https://codereview.chromium.org/448243002
git-svn-id: svn://svn.chromium.org/chrome/branches/2062/src@288119 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | content/browser/renderer_host/render_widget_host_impl.cc | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/content/browser/renderer_host/render_widget_host_impl.cc b/content/browser/renderer_host/render_widget_host_impl.cc index d281bdf..6311fce 100644 --- a/content/browser/renderer_host/render_widget_host_impl.cc +++ b/content/browser/renderer_host/render_widget_host_impl.cc @@ -1200,6 +1200,7 @@ void RenderWidgetHostImpl::RendererExited(base::TerminationStatus status, // Reset some fields in preparation for recovering from a crash. ResetSizeAndRepaintPendingFlags(); current_size_.SetSize(0, 0); + is_hidden_ = false; // Reset this to ensure the hung renderer mechanism is working properly. in_flight_event_count_ = 0; |