summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorhajimehoshi@chromium.org <hajimehoshi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-11-18 18:41:38 +0000
committerhajimehoshi@chromium.org <hajimehoshi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-11-18 18:41:38 +0000
commit08f7c537e4d1516cfcb92bebab2c036d1443842b (patch)
tree057a02e5b08cfec54f9ceb096c09ecb756fdfda7
parent22217ed3bed2dbf77a8ab74ef96832171ebfd401 (diff)
downloadchromium_src-08f7c537e4d1516cfcb92bebab2c036d1443842b.zip
chromium_src-08f7c537e4d1516cfcb92bebab2c036d1443842b.tar.gz
chromium_src-08f7c537e4d1516cfcb92bebab2c036d1443842b.tar.bz2
Change the text of 'Always translate ...' and modify the layout
BUG=319572 TEST=manual Review URL: https://codereview.chromium.org/65043017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235771 0039d316-1c4b-4281-b951-d872f2087c98
-rw-r--r--chrome/app/generated_resources.grd2
-rw-r--r--chrome/browser/ui/views/translate/translate_bubble_view.cc21
2 files changed, 6 insertions, 17 deletions
diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd
index 2a87fbd..3a71250 100644
--- a/chrome/app/generated_resources.grd
+++ b/chrome/app/generated_resources.grd
@@ -13796,7 +13796,7 @@ Some features may be unavailable. Please check that the profile exists and you
Try again
</message>
<message name="IDS_TRANSLATE_BUBBLE_ALWAYS" desc="Text to show for the translate bubble checkbox to always translate from one language to another">
- Always translate <ph name="original_language">$1<ex>French</ex></ph> to <ph name="target_language">$2<ex>German</ex></ph>
+ Always translate
</message>
<message name="IDS_TRANSLATE_BUBBLE_COULD_NOT_TRANSLATE" desc="Text to show for the translate bubble label when the page could not be translated.">
This page could not be translated.
diff --git a/chrome/browser/ui/views/translate/translate_bubble_view.cc b/chrome/browser/ui/views/translate/translate_bubble_view.cc
index c777ad3..6077723 100644
--- a/chrome/browser/ui/views/translate/translate_bubble_view.cc
+++ b/chrome/browser/ui/views/translate/translate_bubble_view.cc
@@ -678,7 +678,6 @@ views::View* TranslateBubbleView::CreateViewAdvanced() {
enum {
COLUMN_SET_ID_LANGUAGES,
- COLUMN_SET_ID_ALWAYS_TRANSLATE,
COLUMN_SET_ID_BUTTONS,
};
@@ -690,13 +689,6 @@ views::View* TranslateBubbleView::CreateViewAdvanced() {
0, GridLayout::USE_PREF, 0, 0);
cs->AddPaddingColumn(1, 0);
- if (!is_in_incognito_window_) {
- cs = layout->AddColumnSet(COLUMN_SET_ID_ALWAYS_TRANSLATE);
- cs->AddColumn(GridLayout::LEADING, GridLayout::CENTER,
- 0, GridLayout::USE_PREF, 0, 0);
- cs->AddPaddingColumn(1, 0);
- }
-
cs = layout->AddColumnSet(COLUMN_SET_ID_BUTTONS);
cs->AddColumn(GridLayout::LEADING, GridLayout::CENTER,
0, GridLayout::USE_PREF, 0, 0);
@@ -718,9 +710,9 @@ views::View* TranslateBubbleView::CreateViewAdvanced() {
layout->AddView(target_language_combobox_);
if (!is_in_incognito_window_) {
- layout->AddPaddingRow(0, views::kUnrelatedControlVerticalSpacing);
-
- layout->StartRow(0, COLUMN_SET_ID_ALWAYS_TRANSLATE);
+ layout->AddPaddingRow(0, views::kRelatedControlVerticalSpacing);
+ layout->StartRow(0, COLUMN_SET_ID_LANGUAGES);
+ layout->SkipColumns(1);
layout->AddView(always_translate_checkbox_);
}
@@ -762,13 +754,10 @@ void TranslateBubbleView::UpdateAdvancedView() {
string16 target_language_name =
model_->GetLanguageNameAt(model_->GetTargetLanguageIndex());
- string16 message =
- l10n_util::GetStringFUTF16(IDS_TRANSLATE_BUBBLE_ALWAYS,
- source_language_name,
- target_language_name);
// "Always translate" checkbox doesn't exist in an incognito window.
if (always_translate_checkbox_) {
- always_translate_checkbox_->SetText(message);
+ always_translate_checkbox_->SetText(
+ l10n_util::GetStringUTF16(IDS_TRANSLATE_BUBBLE_ALWAYS));
always_translate_checkbox_->SetChecked(
model_->ShouldAlwaysTranslate());
}