Move more code from headers to implementation.

BUG=none
TEST=compiles

Review URL: http://codereview.chromium.org/5624002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68534 0039d316-1c4b-4281-b951-d872f2087c98

38 files changed, 218 insertions, 88 deletions

diff --git a/chrome/browser/automation/automation_provider_observers.cc b/chrome/browser/automation/automation_provider_observers.cc
index 3cbde95..d49f31b 100644
--- a/chrome/browser/automation/automation_provider_observers.cc
+++ b/chrome/browser/automation/automation_provider_observers.cc
@@ -1460,6 +1460,8 @@ NTPInfoObserver::NTPInfoObserver(
   }
 }
 
+NTPInfoObserver::~NTPInfoObserver() {}
+
 void NTPInfoObserver::Observe(NotificationType type,
                               const NotificationSource& source,
                               const NotificationDetails& details) {
diff --git a/chrome/browser/automation/automation_provider_observers.h b/chrome/browser/automation/automation_provider_observers.h
index 7287d05..f6dfaae5 100644
--- a/chrome/browser/automation/automation_provider_observers.h
+++ b/chrome/browser/automation/automation_provider_observers.h
@@ -932,6 +932,7 @@ class NTPInfoObserver : public NotificationObserver {
   NTPInfoObserver(AutomationProvider* automation,
                   IPC::Message* reply_message,
                   CancelableRequestConsumer* consumer);
+  virtual ~NTPInfoObserver();
 
   virtual void Observe(NotificationType type,
                        const NotificationSource& source,
diff --git a/chrome/browser/bug_report_data.cc b/chrome/browser/bug_report_data.cc
index c277d88..a0d9772 100644
--- a/chrome/browser/bug_report_data.cc
+++ b/chrome/browser/bug_report_data.cc
@@ -10,6 +10,43 @@
 #include "chrome/browser/chromeos/notifications/system_notification.h"
 #endif
 
+BugReportData::BugReportData()
+    : profile_(NULL),
+      problem_type_(0)
+#if defined(OS_CHROMEOS)
+    , sent_report_(false), send_sys_info_(false)
+#endif
+{
+}
+
+BugReportData::~BugReportData() {}
+
+void BugReportData::UpdateData(Profile* profile,
+                               const std::string& target_tab_url,
+                               const string16& target_tab_title,
+                               const int problem_type,
+                               const std::string& page_url,
+                               const std::string& description,
+                               const std::vector<unsigned char>& image
+#if defined(OS_CHROMEOS)
+                               , const std::string& user_email
+                               , const bool send_sys_info
+                               , const bool sent_report
+#endif
+                               ) {
+  profile_ = profile;
+  target_tab_url_ = target_tab_url;
+  target_tab_title_ = target_tab_title;
+  problem_type_ = problem_type;
+  page_url_ = page_url;
+  description_ = description;
+  image_ = image;
+#if defined(OS_CHROMEOS)
+  user_email_ = user_email;
+  send_sys_info_ = send_sys_info;
+  sent_report_ = sent_report;
+#endif
+}
 
 
 #if defined(OS_CHROMEOS)
diff --git a/chrome/browser/bug_report_data.h b/chrome/browser/bug_report_data.h
index 7752350..2c3a6dd 100644
--- a/chrome/browser/bug_report_data.h
+++ b/chrome/browser/bug_report_data.h
@@ -1,10 +1,10 @@
-// Copyright 2010 Google Inc. All Rights Reserved.
-// Author: rkc@google.com (Rahul Chaturvedi)
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_BUG_REPORT_DATA_H_
 #define CHROME_BROWSER_BUG_REPORT_DATA_H_
 
-
 #include <string>
 #include <vector>
 
@@ -23,43 +23,25 @@ class BugReportData {
   // don't want it to send the report either - this will make sure that if
   // SyslogsComplete gets called before UpdateData, we'll simply populate the
   // sys_info and zip_content fields and exit without disturbing anything else
-  BugReportData() : profile_(NULL),
-                    problem_type_(0)
-#if defined(OS_CHROMEOS)
-                    , sent_report_(false), send_sys_info_(false)
-#endif
-                    {
-  }
+  BugReportData();
+  ~BugReportData();
 
   // Defined in bug_report_ui.cc
   void SendReport();
 
-  void UpdateData(Profile* profile
-                  , const std::string& target_tab_url
-                  , const string16& target_tab_title
-                  , const int problem_type
-                  , const std::string& page_url
-                  , const std::string& description
-                  , const std::vector<unsigned char>& image
+  void UpdateData(Profile* profile,
+                  const std::string& target_tab_url,
+                  const string16& target_tab_title,
+                  const int problem_type,
+                  const std::string& page_url,
+                  const std::string& description,
+                  const std::vector<unsigned char>& image
 #if defined(OS_CHROMEOS)
                   , const std::string& user_email
                   , const bool send_sys_info
                   , const bool sent_report
 #endif
-                  ) {
-    profile_ = profile;
-    target_tab_url_ = target_tab_url;
-    target_tab_title_ = target_tab_title;
-    problem_type_ = problem_type;
-    page_url_ = page_url;
-    description_ = description;
-    image_ = image;
-#if defined(OS_CHROMEOS)
-    user_email_ = user_email;
-    send_sys_info_ = send_sys_info;
-    sent_report_ = sent_report;
-#endif
-  }
+                  );
 
 #if defined(OS_CHROMEOS)
   void SyslogsComplete(chromeos::LogDictionaryType* logs,
diff --git a/chrome/browser/extensions/extension_tts_api.cc b/chrome/browser/extensions/extension_tts_api.cc
index 1654b071..0d18faa 100644
--- a/chrome/browser/extensions/extension_tts_api.cc
+++ b/chrome/browser/extensions/extension_tts_api.cc
@@ -29,6 +29,8 @@ ExtensionTtsController::ExtensionTtsController()
       platform_impl_(NULL) {
 }
 
+ExtensionTtsController::~ExtensionTtsController() {}
+
 void ExtensionTtsController::SpeakOrEnqueue(
     Utterance* utterance, bool can_enqueue) {
   if (IsSpeaking() && can_enqueue) {
diff --git a/chrome/browser/extensions/extension_tts_api.h b/chrome/browser/extensions/extension_tts_api.h
index 0eedcc2..2f99f20 100644
--- a/chrome/browser/extensions/extension_tts_api.h
+++ b/chrome/browser/extensions/extension_tts_api.h
@@ -97,7 +97,7 @@ class ExtensionTtsController {
 
  private:
   ExtensionTtsController();
-  virtual ~ExtensionTtsController() {}
+  virtual ~ExtensionTtsController();
 
   // Get the platform TTS implementation (or injected mock).
   ExtensionTtsPlatformImpl* GetPlatformImpl();
diff --git a/chrome/browser/history/history_types.cc b/chrome/browser/history/history_types.cc
index eebe5a7..8a41ae8 100644
--- a/chrome/browser/history/history_types.cc
+++ b/chrome/browser/history/history_types.cc
@@ -335,6 +335,12 @@ Images::Images() {}
 
 Images::~Images() {}
 
+// TopSitesDelta --------------------------------------------------------------
+
+TopSitesDelta::TopSitesDelta() {}
+
+TopSitesDelta::~TopSitesDelta() {}
+
 // HistoryAddPageArgs ---------------------------------------------------------
 
 HistoryAddPageArgs::HistoryAddPageArgs(
@@ -366,7 +372,12 @@ HistoryAddPageArgs* HistoryAddPageArgs::Clone() const {
       visit_source, did_replace_entry);
 }
 
-MostVisitedThumbnails::MostVisitedThumbnails() {
-}
+ThumbnailMigration::ThumbnailMigration() {}
+
+ThumbnailMigration::~ThumbnailMigration() {}
+
+MostVisitedThumbnails::MostVisitedThumbnails() {}
+
+MostVisitedThumbnails::~MostVisitedThumbnails() {}
 
 }  // namespace history
diff --git a/chrome/browser/history/history_types.h b/chrome/browser/history/history_types.h
index 536064a..bc28dd1 100644
--- a/chrome/browser/history/history_types.h
+++ b/chrome/browser/history/history_types.h
@@ -610,6 +610,9 @@ struct MostVisitedURLWithRank {
 typedef std::vector<MostVisitedURLWithRank> MostVisitedURLWithRankList;
 
 struct TopSitesDelta {
+  TopSitesDelta();
+  ~TopSitesDelta();
+
   MostVisitedURLList deleted;
   MostVisitedURLWithRankList added;
   MostVisitedURLWithRankList moved;
@@ -619,6 +622,9 @@ typedef std::map<GURL, scoped_refptr<RefCountedBytes> > URLToThumbnailMap;
 
 // Used when migrating most visited thumbnails out of history and into topsites.
 struct ThumbnailMigration {
+  ThumbnailMigration();
+  ~ThumbnailMigration();
+
   MostVisitedURLList most_visited;
   URLToThumbnailMap url_to_thumbnail_map;
 };
@@ -629,6 +635,7 @@ class MostVisitedThumbnails
     : public base::RefCountedThreadSafe<MostVisitedThumbnails> {
  public:
   MostVisitedThumbnails();
+  virtual ~MostVisitedThumbnails();
 
   MostVisitedURLList most_visited;
   URLToImagesMap url_to_images_map;
diff --git a/chrome/browser/policy/configuration_policy_pref_store.cc b/chrome/browser/policy/configuration_policy_pref_store.cc
index 5a060b0..3ebbf2e 100644
--- a/chrome/browser/policy/configuration_policy_pref_store.cc
+++ b/chrome/browser/policy/configuration_policy_pref_store.cc
@@ -324,6 +324,8 @@ ConfigurationPolicyPrefStore::ConfigurationPolicyPrefStore(
       use_system_proxy_(false) {
 }
 
+ConfigurationPolicyPrefStore::~ConfigurationPolicyPrefStore() {}
+
 PrefStore::PrefReadError ConfigurationPolicyPrefStore::ReadPrefs() {
   proxy_disabled_ = false;
   proxy_configuration_specified_ = false;
diff --git a/chrome/browser/policy/configuration_policy_pref_store.h b/chrome/browser/policy/configuration_policy_pref_store.h
index be898a8..297d57d 100644
--- a/chrome/browser/policy/configuration_policy_pref_store.h
+++ b/chrome/browser/policy/configuration_policy_pref_store.h
@@ -31,7 +31,7 @@ class ConfigurationPolicyPrefStore : public PrefStore,
   // The ConfigurationPolicyPrefStore does not take ownership of the
   // passed-in |provider|.
   explicit ConfigurationPolicyPrefStore(ConfigurationPolicyProvider* provider);
-  virtual ~ConfigurationPolicyPrefStore() {}
+  virtual ~ConfigurationPolicyPrefStore();
 
   // PrefStore methods:
   virtual PrefReadError ReadPrefs();
diff --git a/chrome/browser/policy/device_management_policy_cache.cc b/chrome/browser/policy/device_management_policy_cache.cc
index 81af0f4..ab5dd15 100644
--- a/chrome/browser/policy/device_management_policy_cache.cc
+++ b/chrome/browser/policy/device_management_policy_cache.cc
@@ -70,6 +70,8 @@ DeviceManagementPolicyCache::DeviceManagementPolicyCache(
       is_device_unmanaged_(false) {
 }
 
+DeviceManagementPolicyCache::~DeviceManagementPolicyCache() {}
+
 void DeviceManagementPolicyCache::LoadPolicyFromFile() {
   if (!file_util::PathExists(backing_file_path_) || fresh_policy_)
     return;
diff --git a/chrome/browser/policy/device_management_policy_cache.h b/chrome/browser/policy/device_management_policy_cache.h
index 86ae845..9c09a07 100644
--- a/chrome/browser/policy/device_management_policy_cache.h
+++ b/chrome/browser/policy/device_management_policy_cache.h
@@ -28,6 +28,7 @@ namespace em = enterprise_management;
 class DeviceManagementPolicyCache {
  public:
   explicit DeviceManagementPolicyCache(const FilePath& backing_file_path);
+  ~DeviceManagementPolicyCache();
 
   // Loads policy information from the backing file. Non-existing or erroneous
   // cache files are ignored.
diff --git a/chrome/browser/policy/device_token_fetcher.cc b/chrome/browser/policy/device_token_fetcher.cc
index 8c9497e..ce7ee4b 100644
--- a/chrome/browser/policy/device_token_fetcher.cc
+++ b/chrome/browser/policy/device_token_fetcher.cc
@@ -57,6 +57,31 @@ namespace policy {
 
 namespace em = enterprise_management;
 
+DeviceTokenFetcher::ObserverRegistrar::ObserverRegistrar() {}
+
+DeviceTokenFetcher::ObserverRegistrar::~ObserverRegistrar() {
+  RemoveAll();
+}
+
+void DeviceTokenFetcher::ObserverRegistrar::Init(
+    DeviceTokenFetcher* token_fetcher) {
+  token_fetcher_ = token_fetcher;
+}
+
+void DeviceTokenFetcher::ObserverRegistrar::AddObserver(
+    DeviceTokenFetcher::Observer* observer) {
+  observers_.push_back(observer);
+  token_fetcher_->AddObserver(observer);
+}
+
+void DeviceTokenFetcher::ObserverRegistrar::RemoveAll() {
+  for (std::vector<DeviceTokenFetcher::Observer*>::iterator it =
+           observers_.begin(); it != observers_.end(); ++it) {
+    token_fetcher_->RemoveObserver(*it);
+  }
+  observers_.clear();
+}
+
 DeviceTokenFetcher::DeviceTokenFetcher(
     DeviceManagementBackend* backend,
     Profile* profile,
@@ -88,6 +113,8 @@ DeviceTokenFetcher::DeviceTokenFetcher(
 #endif
 }
 
+DeviceTokenFetcher::~DeviceTokenFetcher() {}
+
 void DeviceTokenFetcher::Observe(NotificationType type,
                                  const NotificationSource& source,
                                  const NotificationDetails& details) {
diff --git a/chrome/browser/policy/device_token_fetcher.h b/chrome/browser/policy/device_token_fetcher.h
index 9b991de..c36af5b 100644
--- a/chrome/browser/policy/device_token_fetcher.h
+++ b/chrome/browser/policy/device_token_fetcher.h
@@ -43,23 +43,12 @@ class DeviceTokenFetcher
 
   class ObserverRegistrar {
    public:
-    void Init(DeviceTokenFetcher* token_fetcher) {
-      token_fetcher_ = token_fetcher;
-    }
-    ~ObserverRegistrar() {
-      RemoveAll();
-    }
-    void AddObserver(DeviceTokenFetcher::Observer* observer) {
-      observers_.push_back(observer);
-      token_fetcher_->AddObserver(observer);
-    }
-    void RemoveAll() {
-      for (std::vector<DeviceTokenFetcher::Observer*>::iterator it =
-          observers_.begin(); it != observers_.end(); ++it) {
-        token_fetcher_->RemoveObserver(*it);
-      }
-      observers_.clear();
-    }
+    ObserverRegistrar();
+    ~ObserverRegistrar();
+
+    void Init(DeviceTokenFetcher* token_fetcher);
+    void AddObserver(DeviceTokenFetcher::Observer* observer);
+    void RemoveAll();
    private:
     DeviceTokenFetcher* token_fetcher_;
     std::vector<DeviceTokenFetcher::Observer*> observers_;
@@ -71,7 +60,7 @@ class DeviceTokenFetcher
   DeviceTokenFetcher(DeviceManagementBackend* backend,
                      Profile* profile,
                      const FilePath& token_path);
-  virtual ~DeviceTokenFetcher() {}
+  virtual ~DeviceTokenFetcher();
 
   // NotificationObserver method overrides:
   virtual void Observe(NotificationType type,
diff --git a/chrome/common/json_schema_validator.cc b/chrome/common/json_schema_validator.cc
index ee28a89..a76b2d9 100644
--- a/chrome/common/json_schema_validator.cc
+++ b/chrome/common/json_schema_validator.cc
@@ -159,6 +159,7 @@ JSONSchemaValidator::JSONSchemaValidator(DictionaryValue* schema,
   }
 }
 
+JSONSchemaValidator::~JSONSchemaValidator() {}
 
 bool JSONSchemaValidator::Validate(Value* instance) {
   errors_.clear();
diff --git a/chrome/common/json_schema_validator.h b/chrome/common/json_schema_validator.h
index 9af31fb..68030f8 100644
--- a/chrome/common/json_schema_validator.h
+++ b/chrome/common/json_schema_validator.h
@@ -113,6 +113,8 @@ class JSONSchemaValidator {
   // not be used with untrusted schemas.
   JSONSchemaValidator(DictionaryValue* schema, ListValue* types);
 
+  ~JSONSchemaValidator();
+
   // Whether the validator allows additional items for objects and lists, beyond
   // those defined by their schema, by default.
   //
diff --git a/chrome/common/metrics_helpers.cc b/chrome/common/metrics_helpers.cc
index 6462383..7296ce1 100644
--- a/chrome/common/metrics_helpers.cc
+++ b/chrome/common/metrics_helpers.cc
@@ -499,6 +499,10 @@ void MetricsServiceBase::SnapshotProblemResolved(int amount) {
                        std::abs(amount));
 }
 
+HistogramSender::HistogramSender() {}
+
+HistogramSender::~HistogramSender() {}
+
 void HistogramSender::TransmitAllHistograms(Histogram::Flags flag_to_set,
                                             bool send_only_uma) {
   StatisticsRecorder::Histograms histograms;
diff --git a/chrome/common/metrics_helpers.h b/chrome/common/metrics_helpers.h
index b261488..bd18b88 100644
--- a/chrome/common/metrics_helpers.h
+++ b/chrome/common/metrics_helpers.h
@@ -185,8 +185,8 @@ class MetricsLogBase {
 // onward.
 class HistogramSender {
  protected:
-  HistogramSender() {}
-  virtual ~HistogramSender() {}
+  HistogramSender();
+  virtual ~HistogramSender();
 
   // Snapshot all histograms, and transmit the delta.
   // The arguments allow a derived class to select only a subset for
diff --git a/chrome/service/cloud_print/cloud_print_url_fetcher.cc b/chrome/service/cloud_print/cloud_print_url_fetcher.cc
index 2e4fc55..feae6b7 100644
--- a/chrome/service/cloud_print/cloud_print_url_fetcher.cc
+++ b/chrome/service/cloud_print/cloud_print_url_fetcher.cc
@@ -133,6 +133,8 @@ void CloudPrintURLFetcher::StartRequestHelper(
   request_->Start();
 }
 
+CloudPrintURLFetcher::~CloudPrintURLFetcher() {}
+
 URLRequestContextGetter* CloudPrintURLFetcher::GetRequestContextGetter() {
   ServiceURLRequestContextGetter* getter =
       new ServiceURLRequestContextGetter();
diff --git a/chrome/service/cloud_print/cloud_print_url_fetcher.h b/chrome/service/cloud_print/cloud_print_url_fetcher.h
index 68499b4..5fc4fb1 100644
--- a/chrome/service/cloud_print/cloud_print_url_fetcher.h
+++ b/chrome/service/cloud_print/cloud_print_url_fetcher.h
@@ -92,6 +92,9 @@ class CloudPrintURLFetcher
                                   const ResponseCookies& cookies,
                                   const std::string& data);
  protected:
+  friend class base::RefCountedThreadSafe<CloudPrintURLFetcher>;
+  virtual ~CloudPrintURLFetcher();
+
   // Virtual for testing.
   virtual URLRequestContextGetter* GetRequestContextGetter();
 
diff --git a/media/base/filter_collection.cc b/media/base/filter_collection.cc
index bf74b43..b236b02 100644
--- a/media/base/filter_collection.cc
+++ b/media/base/filter_collection.cc
@@ -6,8 +6,9 @@
 
 namespace media {
 
-FilterCollection::FilterCollection() {
-}
+FilterCollection::FilterCollection() {}
+
+FilterCollection::~FilterCollection() {}
 
 void FilterCollection::AddDataSource(DataSource* filter) {
   AddFilter(DATA_SOURCE, filter);
diff --git a/media/base/filter_collection.h b/media/base/filter_collection.h
index 8a396e1..8dd5b04 100644
--- a/media/base/filter_collection.h
+++ b/media/base/filter_collection.h
@@ -17,6 +17,7 @@ namespace media {
 class FilterCollection {
  public:
   FilterCollection();
+  ~FilterCollection();
 
   // Adds a filter to the collection.
   void AddDataSource(DataSource* filter);
diff --git a/media/base/pipeline_impl.cc b/media/base/pipeline_impl.cc
index f73d14a..3b27943 100644
--- a/media/base/pipeline_impl.cc
+++ b/media/base/pipeline_impl.cc
@@ -16,6 +16,14 @@
 
 namespace media {
 
+class PipelineImpl::PipelineInitState {
+ public:
+  scoped_refptr<DataSource> data_source_;
+  scoped_refptr<Demuxer> demuxer_;
+  scoped_refptr<AudioDecoder> audio_decoder_;
+  scoped_refptr<VideoDecoder> video_decoder_;
+};
+
 PipelineImpl::PipelineImpl(MessageLoop* message_loop)
     : message_loop_(message_loop),
       clock_(new ClockImpl(&base::Time::Now)),
diff --git a/media/base/pipeline_impl.h b/media/base/pipeline_impl.h
index 32c1052..aa99f73 100644
--- a/media/base/pipeline_impl.h
+++ b/media/base/pipeline_impl.h
@@ -404,14 +404,7 @@ class PipelineImpl : public Pipeline, public FilterHost {
 
   // Helper class that stores filter references during pipeline
   // initialization.
-  class PipelineInitState {
-   public:
-    scoped_refptr<DataSource> data_source_;
-    scoped_refptr<Demuxer> demuxer_;
-    scoped_refptr<AudioDecoder> audio_decoder_;
-    scoped_refptr<VideoDecoder> video_decoder_;
-  };
-
+  class PipelineInitState;
   scoped_ptr<PipelineInitState> pipeline_init_state_;
 
   FRIEND_TEST_ALL_PREFIXES(PipelineImplTest, GetBufferedTime);
diff --git a/net/url_request/url_request_throttler_header_adapter.cc b/net/url_request/url_request_throttler_header_adapter.cc
index e453071c..368d6fe 100644
--- a/net/url_request/url_request_throttler_header_adapter.cc
+++ b/net/url_request/url_request_throttler_header_adapter.cc
@@ -13,6 +13,8 @@ URLRequestThrottlerHeaderAdapter::URLRequestThrottlerHeaderAdapter(
     : response_header_(headers) {
 }
 
+URLRequestThrottlerHeaderAdapter::~URLRequestThrottlerHeaderAdapter() {}
+
 std::string URLRequestThrottlerHeaderAdapter::GetNormalizedValue(
     const std::string& key) const {
   std::string return_value;
diff --git a/net/url_request/url_request_throttler_header_adapter.h b/net/url_request/url_request_throttler_header_adapter.h
index 599a9f6..35d363e 100644
--- a/net/url_request/url_request_throttler_header_adapter.h
+++ b/net/url_request/url_request_throttler_header_adapter.h
@@ -19,7 +19,7 @@ class URLRequestThrottlerHeaderAdapter
     : public URLRequestThrottlerHeaderInterface {
  public:
   explicit URLRequestThrottlerHeaderAdapter(net::HttpResponseHeaders* headers);
-  virtual ~URLRequestThrottlerHeaderAdapter() {}
+  virtual ~URLRequestThrottlerHeaderAdapter();
 
   // Implementation of URLRequestThrottlerHeaderInterface
   virtual std::string GetNormalizedValue(const std::string& key) const;
diff --git a/ppapi/cpp/paint_aggregator.cc b/ppapi/cpp/paint_aggregator.cc
index 7f54331..1138974 100644
--- a/ppapi/cpp/paint_aggregator.cc
+++ b/ppapi/cpp/paint_aggregator.cc
@@ -25,8 +25,13 @@
 
 namespace pp {
 
-PaintAggregator::InternalPaintUpdate::InternalPaintUpdate() {
-}
+PaintAggregator::PaintUpdate::PaintUpdate() {}
+
+PaintAggregator::PaintUpdate::~PaintUpdate() {}
+
+PaintAggregator::InternalPaintUpdate::InternalPaintUpdate() {}
+
+PaintAggregator::InternalPaintUpdate::~InternalPaintUpdate() {}
 
 Rect PaintAggregator::InternalPaintUpdate::GetScrollDamage() const {
   // Should only be scrolling in one direction at a time.
diff --git a/ppapi/cpp/paint_aggregator.h b/ppapi/cpp/paint_aggregator.h
index a73a998..3fe32a5 100644
--- a/ppapi/cpp/paint_aggregator.h
+++ b/ppapi/cpp/paint_aggregator.h
@@ -22,6 +22,9 @@ namespace pp {
 class PaintAggregator {
  public:
   struct PaintUpdate {
+    PaintUpdate();
+    ~PaintUpdate();
+
     // True if there is a scroll applied. This indicates that the scroll delta
     // and scroll_rect are nonzero (just as a convenience).
     bool has_scroll;
@@ -86,6 +89,7 @@ class PaintAggregator {
   class InternalPaintUpdate {
    public:
     InternalPaintUpdate();
+    ~InternalPaintUpdate();
 
     // Computes the rect damaged by scrolling within |scroll_rect| by
     // |scroll_delta|. This rect must be repainted. It is not included in
diff --git a/ppapi/proxy/plugin_var_tracker.cc b/ppapi/proxy/plugin_var_tracker.cc
index dabdf8f..f2bc5975 100644
--- a/ppapi/proxy/plugin_var_tracker.cc
+++ b/ppapi/proxy/plugin_var_tracker.cc
@@ -42,6 +42,8 @@ PluginVarTracker::PluginVarTracker(PluginDispatcher* dispatcher)
     : dispatcher_(dispatcher) {
 }
 
+PluginVarTracker::~PluginVarTracker() {}
+
 int64 PluginVarTracker::MakeString(const std::string& str) {
   RefCountedString* out = new RefCountedString(str);
   out->AddRef();
diff --git a/ppapi/proxy/plugin_var_tracker.h b/ppapi/proxy/plugin_var_tracker.h
index 1ae5b24..999f209 100644
--- a/ppapi/proxy/plugin_var_tracker.h
+++ b/ppapi/proxy/plugin_var_tracker.h
@@ -30,6 +30,8 @@ class PluginVarTracker {
   // which is probably just being created from our constructor.
   PluginVarTracker(PluginDispatcher* dispatcher);
 
+  ~PluginVarTracker();
+
   // Must be called after construction.
   void Init();
 
diff --git a/ppapi/proxy/serialized_structs.cc b/ppapi/proxy/serialized_structs.cc
index fa71f71..ab33bab 100644
--- a/ppapi/proxy/serialized_structs.cc
+++ b/ppapi/proxy/serialized_structs.cc
@@ -10,6 +10,19 @@
 namespace pp {
 namespace proxy {
 
+SerializedFontDescription::SerializedFontDescription()
+    : face(),
+      family(0),
+      size(0),
+      weight(0),
+      italic(PP_FALSE),
+      small_caps(PP_FALSE),
+      letter_spacing(0),
+      word_spacing(0) {
+}
+
+SerializedFontDescription::~SerializedFontDescription() {}
+
 void SerializedFontDescription::SetFromPPFontDescription(
     Dispatcher* dispatcher,
     const PP_FontDescription_Dev& desc,
@@ -49,5 +62,13 @@ void SerializedFontDescription::SetToPPFontDescription(
   desc->word_spacing = word_spacing;
 }
 
+PPBFlash_DrawGlyphs_Params::PPBFlash_DrawGlyphs_Params()
+    : pp_image_data(0),
+      font_desc(),
+      color(0) {
+}
+
+PPBFlash_DrawGlyphs_Params::~PPBFlash_DrawGlyphs_Params() {}
+
 }  // namespace proxy
 }  // namespace pp
diff --git a/ppapi/proxy/serialized_structs.h b/ppapi/proxy/serialized_structs.h
index 49fc222..d90926b 100644
--- a/ppapi/proxy/serialized_structs.h
+++ b/ppapi/proxy/serialized_structs.h
@@ -24,6 +24,9 @@ class Dispatcher;
 // PP_FontDescript_Dev has to be redefined with a SerializedVar in place of
 // the PP_Var used for the face name.
 struct SerializedFontDescription {
+  SerializedFontDescription();
+  ~SerializedFontDescription();
+
   // Converts a PP_FontDescription_Dev to a SerializedFontDescription.
   //
   // If source_owns_ref is true, the reference owned by the
@@ -80,6 +83,9 @@ struct PPBFont_DrawTextAt_Params {
 };
 
 struct PPBFlash_DrawGlyphs_Params {
+  PPBFlash_DrawGlyphs_Params();
+  ~PPBFlash_DrawGlyphs_Params();
+
   PP_Resource pp_image_data;
   SerializedFontDescription font_desc;
   uint32_t color;
diff --git a/remoting/base/compound_buffer.cc b/remoting/base/compound_buffer.cc
index 2808f6d..a766abe 100644
--- a/remoting/base/compound_buffer.cc
+++ b/remoting/base/compound_buffer.cc
@@ -17,6 +17,8 @@ CompoundBuffer::DataChunk::DataChunk(
       size(size_value) {
 }
 
+CompoundBuffer::DataChunk::~DataChunk() {}
+
 CompoundBuffer::CompoundBuffer()
     : total_bytes_(0),
       locked_(false) {
diff --git a/remoting/base/compound_buffer.h b/remoting/base/compound_buffer.h
index 1b0a546..eef8d13 100644
--- a/remoting/base/compound_buffer.h
+++ b/remoting/base/compound_buffer.h
@@ -83,6 +83,7 @@ class CompoundBuffer {
 
   struct DataChunk {
     DataChunk(net::IOBuffer* buffer, const char* start, int size);
+    ~DataChunk();
 
     scoped_refptr<net::IOBuffer> buffer;
     const char* start;
diff --git a/remoting/protocol/rtp_utils.cc b/remoting/protocol/rtp_utils.cc
index 3a6a9340..db04503 100644
--- a/remoting/protocol/rtp_utils.cc
+++ b/remoting/protocol/rtp_utils.cc
@@ -27,6 +27,28 @@ const int kRtcpReceiverReportTotalSize =
 const int kRtcpReceiverReportPacketType = 201;
 }  // namespace
 
+RtpHeader::RtpHeader()
+    : padding(false),
+      extension(false),
+      sources(0),
+      marker(false),
+      payload_type(0),
+      sequence_number(0),
+      timestamp(0),
+      sync_source_id(0) {
+}
+
+RtcpReceiverReport::RtcpReceiverReport()
+    : receiver_ssrc(0),
+      sender_ssrc(0),
+      loss_fraction(0),
+      total_lost_packets(0),
+      last_sequence_number(0),
+      jitter(0),
+      last_sender_report_timestamp(0),
+      last_sender_report_delay(0) {
+}
+
 static inline uint8 ExtractBits(uint8 byte, int bits_count, int shift) {
   return (byte >> shift) & ((1 << bits_count) - 1);
 }
diff --git a/remoting/protocol/rtp_utils.h b/remoting/protocol/rtp_utils.h
index 599ffaf..4441d78 100644
--- a/remoting/protocol/rtp_utils.h
+++ b/remoting/protocol/rtp_utils.h
@@ -11,16 +11,7 @@ namespace remoting {
 namespace protocol {
 
 struct RtpHeader {
-  RtpHeader()
-      : padding(false),
-        extension(false),
-        sources(0),
-        marker(false),
-        payload_type(0),
-        sequence_number(0),
-        timestamp(0),
-        sync_source_id(0) {
-  }
+  RtpHeader();
 
   // RTP version is always set to 2.
   // version = 2
@@ -36,16 +27,7 @@ struct RtpHeader {
 };
 
 struct RtcpReceiverReport {
-  RtcpReceiverReport()
-      : receiver_ssrc(0),
-        sender_ssrc(0),
-        loss_fraction(0),
-        total_lost_packets(0),
-        last_sequence_number(0),
-        jitter(0),
-        last_sender_report_timestamp(0),
-        last_sender_report_delay(0) {
-  }
+  RtcpReceiverReport();
 
   uint32 receiver_ssrc;
   uint32 sender_ssrc;
diff --git a/webkit/fileapi/sandboxed_file_system_operation.cc b/webkit/fileapi/sandboxed_file_system_operation.cc
index 7f9dd38..ef7c752 100644
--- a/webkit/fileapi/sandboxed_file_system_operation.cc
+++ b/webkit/fileapi/sandboxed_file_system_operation.cc
@@ -22,6 +22,8 @@ SandboxedFileSystemOperation::SandboxedFileSystemOperation(
   DCHECK(file_system_context_);
 }
 
+SandboxedFileSystemOperation::~SandboxedFileSystemOperation() {}
+
 void SandboxedFileSystemOperation::OpenFileSystem(
     const GURL& origin_url, fileapi::FileSystemType type, bool create) {
 #ifndef NDEBUG
diff --git a/webkit/fileapi/sandboxed_file_system_operation.h b/webkit/fileapi/sandboxed_file_system_operation.h
index 8794a9d..c6c905d 100644
--- a/webkit/fileapi/sandboxed_file_system_operation.h
+++ b/webkit/fileapi/sandboxed_file_system_operation.h
@@ -29,6 +29,7 @@ class SandboxedFileSystemOperation : public FileSystemOperation {
   SandboxedFileSystemOperation(FileSystemCallbackDispatcher* dispatcher,
                                scoped_refptr<base::MessageLoopProxy> proxy,
                                SandboxedFileSystemContext* file_system_context);
+  virtual ~SandboxedFileSystemOperation();
 
   void OpenFileSystem(const GURL& origin_url,
                       fileapi::FileSystemType type,