diff options
| author | jshin@chromium.org <jshin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-27 22:56:39 +0000 |
|---|---|---|
| committer | jshin@chromium.org <jshin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-27 22:56:39 +0000 |
| commit | b8649e0399b964cd0aa7e5c76d0996ff7bda3e2e (patch) | |
| tree | 678c2323ae7e8f07cd3068ea9008a3c9aaf63567 | |
| parent | 8098d2d7169e5f3d004194d10b3aafa83b445637 (diff) | |
| download | chromium_src-b8649e0399b964cd0aa7e5c76d0996ff7bda3e2e.zip chromium_src-b8649e0399b964cd0aa7e5c76d0996ff7bda3e2e.tar.gz chromium_src-b8649e0399b964cd0aa7e5c76d0996ff7bda3e2e.tar.bz2 | |
With an upcoming ICU 4.2 upgrade, the way 'search' works has changed and FiP doesn't make a hit for
a stand-alone dependent vowel sign of Indic scripts, which is OK according to a native Malayalam speaker.
Revise FindInPageControllerTest.FindCrash_Issue1341577 to run FindInPage (U+0D4C) without checking the return value because the test was devised to test the 'crash' issue.
BUG=8198
TEST=FindInPageControllerTest.FindCrash_Issue1341577 pass before and after ICU upgrade to 4.2
Review URL: http://codereview.chromium.org/174629
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24686 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/browser/views/find_bar_win_browsertest.cc | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/chrome/browser/views/find_bar_win_browsertest.cc b/chrome/browser/views/find_bar_win_browsertest.cc index 22db8aa..3995293 100644 --- a/chrome/browser/views/find_bar_win_browsertest.cc +++ b/chrome/browser/views/find_bar_win_browsertest.cc @@ -347,11 +347,15 @@ IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, FindCrash_Issue1341577) { // This would crash the tab. These must be the first two find requests issued // against the frame, otherwise an active frame pointer is set and it wont // produce the crash. + // We used to check the return value and |ordinal|. With ICU 4.2, FiP does + // not find a stand-alone dependent vowel sign of Indic scripts. So, the + // exptected values are all 0. To make this test pass regardless of + // ICU version, we just call FiP and see if there's any crash. + // TODO(jungshik): According to a native Malayalam speaker, it's ok not + // to find U+0D4C. Still need to investigate further this issue. int ordinal = 0; - EXPECT_EQ(1, FindInPage(L"\u0D4C", FWD, IGNORE_CASE, &ordinal)); - EXPECT_EQ(1, ordinal); - EXPECT_EQ(1, FindInPage(L"\u0D4C", FWD, IGNORE_CASE, &ordinal)); - EXPECT_EQ(1, ordinal); + FindInPage(L"\u0D4C", FWD, IGNORE_CASE, &ordinal); + FindInPage(L"\u0D4C", FWD, IGNORE_CASE, &ordinal); // This should work fine. EXPECT_EQ(1, FindInPage(L"\u0D24\u0D46", FWD, IGNORE_CASE, &ordinal)); |