diff options
| author | bryner@chromium.org <bryner@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-30 20:52:36 +0000 |
|---|---|---|
| committer | bryner@chromium.org <bryner@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-30 20:52:36 +0000 |
| commit | dd9b904b47f8c529e20e9f4f87d8f019e2a594bc (patch) | |
| tree | 93ebdbf2b428bf6ce7210c7cf7be1271a3441fba | |
| parent | 1bc6c551f14f237d5d56b18afb87ea1570483c1c (diff) | |
| download | chromium_src-dd9b904b47f8c529e20e9f4f87d8f019e2a594bc.zip chromium_src-dd9b904b47f8c529e20e9f4f87d8f019e2a594bc.tar.gz chromium_src-dd9b904b47f8c529e20e9f4f87d8f019e2a594bc.tar.bz2 | |
Initialize salt_ to zero in VisitedLinkCommon.
Previously, this memory would remain uninitialized until the renderer received
a VisitedLink_NewTable message. This was causing valgrind errors in
PhishingDOMFeatureExtractorTest when WebKit computed URL fingerprints, since
the test never sends a VisitedLink_NewTable message.
BUG=none
TEST=no valgrind errors in PhishingDOMFeatureExtractorTest
Review URL: http://codereview.chromium.org/2873081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54376 0039d316-1c4b-4281-b951-d872f2087c98
| -rw-r--r-- | chrome/common/visitedlink_common.cc | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/chrome/common/visitedlink_common.cc b/chrome/common/visitedlink_common.cc index 899e7a6..9cd1e84 100644 --- a/chrome/common/visitedlink_common.cc +++ b/chrome/common/visitedlink_common.cc @@ -4,6 +4,8 @@ #include "chrome/common/visitedlink_common.h" +#include <string.h> // for memset() + #include "base/logging.h" #include "base/md5.h" #include "googleurl/src/gurl.h" @@ -14,6 +16,7 @@ const VisitedLinkCommon::Hash VisitedLinkCommon::null_hash_ = -1; VisitedLinkCommon::VisitedLinkCommon() : hash_table_(NULL), table_length_(0) { + memset(salt_, 0, sizeof(salt_)); } VisitedLinkCommon::~VisitedLinkCommon() { |