diff options
| author | hamaji@chromium.org <hamaji@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-06 17:28:28 +0000 |
|---|---|---|
| committer | hamaji@chromium.org <hamaji@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-06 17:28:28 +0000 |
| commit | e2ffeae017f1c85d472e3f04e62e4cba21f6e9a8 (patch) | |
| tree | 8d09cddd7f594d4508ff7f79f5d156aad5c512c4 | |
| parent | 222e5b5d7ce53e46b615f26281f7dcc374c1bfcf (diff) | |
| download | chromium_src-e2ffeae017f1c85d472e3f04e62e4cba21f6e9a8.zip chromium_src-e2ffeae017f1c85d472e3f04e62e4cba21f6e9a8.tar.gz chromium_src-e2ffeae017f1c85d472e3f04e62e4cba21f6e9a8.tar.bz2 | |
Always output 32bit integer values in header of CRX file.
It seems that 'l' data type of Python's array uses long, which is 64bit integer in LP64 environemnts. This means that this script generates corrupt headers in LP64 environments such as AMD64. Let's just use 'i' data type for 32bit integer.
http://docs.python.org/library/array.html
Review URL: http://codereview.chromium.org/119283
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17835 0039d316-1c4b-4281-b951-d872f2087c98
| -rwxr-xr-x | chrome/tools/extensions/chromium_extension.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chrome/tools/extensions/chromium_extension.py b/chrome/tools/extensions/chromium_extension.py index f6ecebc4..f30bc5a 100755 --- a/chrome/tools/extensions/chromium_extension.py +++ b/chrome/tools/extensions/chromium_extension.py @@ -104,7 +104,7 @@ class ExtensionDir: out.write("Cr24") # Extension file magic number # The rest of the header is currently made up of three ints: # version, header size, manifest size - header = array.array("l") + header = array.array("i") header.append(1) # version header.append(16) # header size manifest_json = json.dumps(manifest); |